Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
e4a6d69
)
Fix bihash bucket double unlock.
36/18336/4
author
Tom Seidenberg
<tseidenb@cisco.com>
Fri, 15 Mar 2019 14:15:26 +0000
(10:15 -0400)
committer
Dave Barach
<openvpp@barachs.net>
Fri, 15 Mar 2019 20:15:24 +0000
(20:15 +0000)
Change-Id: Icc9bef32d1bb2b8f277598c50c69343c81f22cd2
Signed-off-by: Tom Seidenberg <tseidenb@cisco.com>
src/vppinfra/bihash_template.c
patch
|
blob
|
history
diff --git
a/src/vppinfra/bihash_template.c
b/src/vppinfra/bihash_template.c
index
6980538
..
6e910fe
100644
(file)
--- a/
src/vppinfra/bihash_template.c
+++ b/
src/vppinfra/bihash_template.c
@@
-441,8
+441,7
@@
static inline int BV (clib_bihash_add_del_inline)
tmp_b.refcnt = 1;
CLIB_MEMORY_BARRIER ();
- b->as_u64 = tmp_b.as_u64;
- BV (clib_bihash_unlock_bucket) (b);
+ b->as_u64 = tmp_b.as_u64; /* unlocks the bucket */
return (0);
}