ip: coverity woes

coverity complains about logically dead code for the statement if (error) because
error was assigned to 0 prior to the check. I believe error was meant to get the
return status of the call vnet_punt_socket_add.

Change-Id: I794167493f63cb898d3618c2c28817823f46b765
Signed-off-by: Steven Luong <sluong@cisco.com>

diff --git a/src/vnet/ip/punt_api.c b/src/vnet/ip/punt_api.c
index 3ca9621..ecb461b 100644 (file)
--- a/src/vnet/ip/punt_api.c
+++ b/src/vnet/ip/punt_api.c
@@ -80,10 +80,10 @@ vl_api_punt_socket_register_t_handler (vl_api_punt_socket_register_t * mp)
   clib_error_t *error;
   vl_api_registration_t *reg;
 
-  error = 0;
-  vnet_punt_socket_add (vm, ntohl (mp->header_version),
-                       mp->punt.ipv, mp->punt.l4_protocol,
-                       ntohs (mp->punt.l4_port), (char *) mp->pathname);
+  error = vnet_punt_socket_add (vm, ntohl (mp->header_version),
+                               mp->punt.ipv, mp->punt.l4_protocol,
+                               ntohs (mp->punt.l4_port),
+                               (char *) mp->pathname);
   if (error)
     {
       rv = -1;