acl-plugin: fix the high cpu usage caused by the connection cleaner 59/13059/3
authorAndrew Yourtchenko <ayourtch@gmail.com>
Thu, 14 Jun 2018 16:36:41 +0000 (18:36 +0200)
committerDamjan Marion <dmarion@me.com>
Sun, 17 Jun 2018 12:07:11 +0000 (12:07 +0000)
The commit 4bc1796b346efd10f3fb19b176ff089179263a24 had incorrect
calculation of the session lists minimal timeout, resulting
in returned value of 0 which resulted in existing sessions
constantly requeued, taking up the CPU. Fix this calculation.

Change-Id: I9a789739f96a1f01522c68f91b0a02db2417837f
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
src/plugins/acl/sess_mgmt_node.c

index bfc357f..abb1e7c 100644 (file)
@@ -38,7 +38,8 @@ fa_session_get_shortest_timeout (acl_main_t * am)
 {
   int timeout_type;
   u64 timeout = ~0LL;
-  for (timeout_type = 0; timeout_type <= ACL_N_USER_TIMEOUTS; timeout_type++)
+  for (timeout_type = ACL_TIMEOUT_UDP_IDLE;
+       timeout_type < ACL_N_USER_TIMEOUTS; timeout_type++)
     {
       if (timeout > am->session_timeout_sec[timeout_type])
        {