ip: don't export useless error counters for ip6 rewrite

the error node is set to ip6_input in the inline funcition
associated with ip6_rewrite. Thus, error counters defined
for node ip6 rewrite are never used.

Type: fix
Change-Id: Id6bef633928b0fff9069498c2e39e9f5bea2cf9b
Signed-off-by: Arthur de Kerhor <arthurdekerhor@gmail.com>

diff --git a/src/vnet/ip/ip6_forward.c b/src/vnet/ip/ip6_forward.c
index 84ea5a0..2171cb8 100644 (file)
--- a/src/vnet/ip/ip6_forward.c
+++ b/src/vnet/ip/ip6_forward.c
@@ -2256,8 +2256,6 @@ VLIB_REGISTER_NODE (ip6_rewrite_node) =
   .name = "ip6-rewrite",
   .vector_size = sizeof (u32),
   .format_trace = format_ip6_rewrite_trace,
-  .n_errors = IP6_N_ERROR,
-  .error_counters = ip6_error_counters,
   .n_next_nodes = IP6_REWRITE_N_NEXT,
   .next_nodes =
   {

diff --git a/test/test_mtu.py b/test/test_mtu.py
index 4159deb..ed4fcb5 100644 (file)
--- a/test/test_mtu.py
+++ b/test/test_mtu.py
@@ -113,6 +113,8 @@ class TestMTU(VppTestCase):
             # n.show2()
             self.validate_bytes(bytes(p[1]), icmp4_reply)
 
+        self.assert_error_counter_equal("/err/ip4-input/mtu_exceeded", 11)
+
         # Now with DF off. Expect fragments.
         # First go with 1500 byte packets.
         p_payload = UDP(sport=1234, dport=1234) / self.payload(1500 - 20 - 8)
@@ -191,6 +193,8 @@ class TestMTU(VppTestCase):
         for p in rx:
             self.validate_bytes(bytes(p[1]), icmp6_reply_str)
 
+        self.assert_error_counter_equal("/err/ip6-input/mtu_exceeded", 9)
+
         # Reset MTU
         self.vapi.sw_interface_set_mtu(self.pg1.sw_if_index, [current_mtu, 0, 0, 0])