session: fix double free in CLI 30/36330/2
authorFilip Tehlar <ftehlar@cisco.com>
Fri, 3 Jun 2022 12:21:16 +0000 (12:21 +0000)
committerFilip Tehlar <ftehlar@cisco.com>
Fri, 3 Jun 2022 12:30:18 +0000 (12:30 +0000)
Type: fix

Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Change-Id: I646ac946d0b07929dfdd1966a4f4a3b697768040

src/vnet/session/session_cli.c

index da2df33..344937c 100644 (file)
@@ -841,7 +841,6 @@ session_enable_disable_fn (vlib_main_t * vm, unformat_input_t * input,
                           vlib_cli_command_t * cmd)
 {
   u8 is_en = 2;
-  clib_error_t *error;
 
   while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
     {
@@ -850,12 +849,8 @@ session_enable_disable_fn (vlib_main_t * vm, unformat_input_t * input,
       else if (unformat (input, "disable"))
        is_en = 0;
       else
-       {
-         error = clib_error_return (0, "unknown input `%U'",
-                                    format_unformat_error, input);
-         unformat_free (input);
-         return error;
-       }
+       return clib_error_return (0, "unknown input `%U'",
+                                 format_unformat_error, input);
     }
 
   if (is_en > 1)