GBP: fix for coverity found errors

Change-Id: Id69678adb578b323ae18034d1b1fddb7417bcc08
Signed-off-by: Neale Ranns <nranns@cisco.com>

diff --git a/src/plugins/gbp/gbp_endpoint.c b/src/plugins/gbp/gbp_endpoint.c
index 79c140f..47adbb5 100644 (file)
--- a/src/plugins/gbp/gbp_endpoint.c
+++ b/src/plugins/gbp/gbp_endpoint.c
@@ -235,7 +235,9 @@ gbp_endpoint_alloc (epg_id_t epg_id,
        case GBP_VXLAN_TEMPLATE_TUNNEL:
          ge->tun.ge_parent_sw_if_index = sw_if_index;
          ge->ge_sw_if_index =
-           gbp_vxlan_tunnel_clone_and_lock (sw_if_index, tun_src, tun_dst);
+           gbp_vxlan_tunnel_clone_and_lock (sw_if_index,
+                                            &ge->tun.ge_src,
+                                            &ge->tun.ge_dst);
          break;
        case VXLAN_GBP_TUNNEL:
          ge->tun.ge_parent_sw_if_index =
@@ -354,9 +356,9 @@ gbp_endpoint_update (u32 sw_if_index,
                                       tun_src, tun_dst);
              ge->ge_itf = gbp_itf_add_and_lock (sw_if_index, ~0);
            }
-         else
-           /* L2 EP with IPs */
-           gei = gbp_endpoint_index (ge);
+         /* else
+          *   L2 EP with IPs
+          */
        }
       else
        {

diff --git a/src/plugins/gbp/gbp_route_domain.c b/src/plugins/gbp/gbp_route_domain.c
index 5518cc1..c030ee5 100644 (file)
--- a/src/plugins/gbp/gbp_route_domain.c
+++ b/src/plugins/gbp/gbp_route_domain.c
@@ -291,9 +291,9 @@ gbp_route_domain_cli (vlib_main_t * vm,
       else if (unformat (input, "ip6-uu %U", unformat_vnet_sw_interface,
                         vnm, &ip6_uu_sw_if_index))
        ;
-      else if (unformat (input, "ip4-table-id %d", ip4_table_id))
+      else if (unformat (input, "ip4-table-id %d", &ip4_table_id))
        ;
-      else if (unformat (input, "ip6-table-id %d", ip6_table_id))
+      else if (unformat (input, "ip6-table-id %d", &ip6_table_id))
        ;
       else if (unformat (input, "add"))
        add = 1;