stats: memory leak with per-node-counters on 31/21731/2
authorOle Troan <ot@cisco.com>
Tue, 3 Sep 2019 18:58:08 +0000 (20:58 +0200)
committerDamjan Marion <dmarion@me.com>
Tue, 3 Sep 2019 20:02:36 +0000 (20:02 +0000)
vlib_node_get_nodes() creates a duplicate node structure which was never freed.

Type: fix
Fixes: 1ddbc0138b
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib1200854937faaa694b398607d2f0ba65aa81c01

src/vpp/stats/stat_segment.c

index bf97050..bb533d1 100644 (file)
@@ -527,7 +527,10 @@ update_node_counters (stat_segment_main_t * sm)
          c[n->index] =
            n->stats_total.suspends - n->stats_last_clear.suspends;
        }
+      vec_free (node_dups[j]);
     }
+  vec_free (node_dups);
+  vec_free (stat_vms);
 }
 
 static void