api: Do not assert of short message lengths

Type: improvement

Short message lengths are correctly handled by the code, asserting makes unit tests that verify this behaviour (e.g. test_ip_punt_api_validation) fail/crash with a debug image.

Signed-off-by: Neale Ranns <neale@graphiant.com>
Change-Id: Ib3a377e5d49fde0eee252b92f0e58a8a0d0d83ec

diff --git a/src/vlibapi/api_shared.c b/src/vlibapi/api_shared.c
index 7727843..17560e5 100644 (file)
--- a/src/vlibapi/api_shared.c
+++ b/src/vlibapi/api_shared.c
@@ -551,7 +551,6 @@ msg_handler_internal (api_main_t *am, void *the_msg, uword msg_len,
       if (calc_size_fp)
        {
          calc_size = (*calc_size_fp) (the_msg);
-         ASSERT (calc_size <= msg_len);
          if (calc_size > msg_len)
            {
              clib_warning (