abf: return status of attachment add/del 67/37367/2
authorMatthew Smith <mgsmith@netgate.com>
Thu, 6 Oct 2022 18:01:23 +0000 (18:01 +0000)
committerNeale Ranns <neale@graphiant.com>
Fri, 7 Oct 2022 04:16:36 +0000 (04:16 +0000)
Type: fix

The handler for abf_itf_attach_add_del was always returning 0. Set rv to
the return value of call to abf_itf_attach() or abf_itf_detach().

Signed-off-by: Matthew Smith <mgsmith@netgate.com>
Change-Id: Ibb888bb148e6e03fc2776e2384b3a6e26148a429

src/plugins/abf/abf_api.c

index 222e1f4..ffb32d5 100644 (file)
@@ -113,16 +113,14 @@ vl_api_abf_itf_attach_add_del_t_handler (vl_api_abf_itf_attach_add_del_t * mp)
 
   if (mp->is_add)
     {
-      abf_itf_attach (fproto,
-                     ntohl (mp->attach.policy_id),
-                     ntohl (mp->attach.priority),
-                     ntohl (mp->attach.sw_if_index));
+      rv = abf_itf_attach (fproto, ntohl (mp->attach.policy_id),
+                          ntohl (mp->attach.priority),
+                          ntohl (mp->attach.sw_if_index));
     }
   else
     {
-      abf_itf_detach (fproto,
-                     ntohl (mp->attach.policy_id),
-                     ntohl (mp->attach.sw_if_index));
+      rv = abf_itf_detach (fproto, ntohl (mp->attach.policy_id),
+                          ntohl (mp->attach.sw_if_index));
     }
 
   REPLY_MACRO (VL_API_ABF_ITF_ATTACH_ADD_DEL_REPLY);