vppapigen: require reply/details messages for requests/dumps 77/10977/7
authorMarek Gradzki <mgradzki@cisco.com>
Tue, 6 Mar 2018 11:25:02 +0000 (12:25 +0100)
committerMarek Gradzki <mgradzki@cisco.com>
Thu, 8 Mar 2018 06:59:16 +0000 (06:59 +0000)
Throw exception if details/reply is not defined instead
of logger warning.

Change-Id: I6eb39c51eecca6521e5f563ba09dfd62311b45ec
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
src/tools/vppapigen/vppapigen.py

index 628bb09..0779e80 100755 (executable)
@@ -608,8 +608,8 @@ class VPPAPI(object):
                 if d[:-6] in svcs:
                     continue
                 if d[:-6] not in msgs:
-                    self.logger.warning('{} missing calling message'
-                                        .format(d))
+                    raise ValueError('{} missing calling message'
+                                     .format(d))
                 continue
             if d.endswith('_dump'):
                 if d in svcs:
@@ -618,14 +618,14 @@ class VPPAPI(object):
                     s['services'].append(Service(d, d[:-5]+'_details',
                                                  stream=True))
                 else:
-                    self.logger.error('{} missing details message'
-                                      .format(d))
+                    raise ValueError('{} missing details message'
+                                     .format(d))
                 continue
 
             if d.endswith('_details'):
                 if d[:-8]+'_dump' not in msgs:
-                    self.logger.error('{} missing dump message'
-                                      .format(d))
+                    raise ValueError('{} missing dump message'
+                                     .format(d))
                 continue
 
             if d in svcs: