tcp: fix listener trace coverity warning 04/29404/3
authorFlorin Coras <fcoras@cisco.com>
Tue, 13 Oct 2020 02:03:52 +0000 (19:03 -0700)
committerDave Barach <openvpp@barachs.net>
Tue, 13 Oct 2020 16:50:15 +0000 (16:50 +0000)
Type: fix

Change-Id: I75c0bd862260e188f625271c3bd545a7ab37af5d
Signed-off-by: Florin Coras <fcoras@cisco.com>
src/vnet/tcp/tcp_input.c

index 948383b..91a4fca 100644 (file)
@@ -2650,12 +2650,8 @@ tcp46_listen_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
 
       if (PREDICT_FALSE (b->flags & VLIB_BUFFER_IS_TRACED))
        {
-         tcp_rx_trace_t *t;
-         t = vlib_add_trace (vm, node, b, sizeof (*t));
-         clib_memcpy_fast (&t->tcp_header, tcp_buffer_hdr (b),
-                           sizeof (t->tcp_header));
-         clib_memcpy_fast (&t->tcp_connection, lc,
-                           sizeof (t->tcp_connection));
+         tcp_rx_trace_t *t = vlib_add_trace (vm, node, b, sizeof (*t));
+         tcp_set_rx_trace_data (t, lc, tcp_buffer_hdr (b), b, is_ip4);
        }
 
       n_syns += (error == TCP_ERROR_NONE);