tests: explicitly close subprocess files 53/30453/3
authorPaul Vinciguerra <pvinci@vinciconsulting.com>
Thu, 17 Dec 2020 02:03:16 +0000 (21:03 -0500)
committerOle Tr�an <otroan@employees.org>
Mon, 15 Feb 2021 09:57:11 +0000 (09:57 +0000)
Resolve the following error:
/vpp/test/framework.py:657: ResourceWarning: unclosed file <_io.BufferedReader name=6>
  del cls.vpp
Object allocated at (most recent call last):
  File "/usr/lib/python3.8/subprocess.py", lineno 844
    self.stdout = io.open(c2pread, 'rb', bufsize)

Type: test

Change-Id: Ia2974da594f0582dcff1f4bdf40d25475769c46c
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
test/framework.py

index c9ecafd..9bb3e01 100644 (file)
@@ -679,6 +679,8 @@ class VppTestCase(unittest.TestCase):
                 cls.vpp.communicate()
             cls.logger.debug("Deleting class vpp attribute on %s",
                              cls.__name__)
+            cls.vpp.stdout.close()
+            cls.vpp.stderr.close()
             del cls.vpp
 
         if cls.vpp_startup_failed: