fix IP directed broadcast node declarations 93/13593/2
authorMatthew Smith <mgsmith@netgate.com>
Fri, 20 Jul 2018 16:52:05 +0000 (11:52 -0500)
committerDave Barach <openvpp@barachs.net>
Sat, 21 Jul 2018 11:56:10 +0000 (11:56 +0000)
The dev build ('make build') was failing because
ip4_rewrite_bcast() and ip6_rewrite_bcast() are declared static
and were not referenced.

The node functions that were set for directed broadcast rewrite:

ip4_rewrite_bcast_node - ip4_rewrite()
ip6_rewrite_bcast_node - ip6_rewrite()

Changed to:

ip4_rewrite_bcast_node - ip4_rewrite_bcast()
ip6_rewrite_bcast_node - ip6_rewrite_bcast()

The release build ('make build-release') succeeds because there is
a VLIB_NODE_FUNCTION_MULTIARCH() call referencing the function. That
macro is empty for dev builds.

Change-Id: I2a05f00ca43d0eae8ff2e3026991e69917003fe1
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
src/vnet/ip/ip4_forward.c
src/vnet/ip/ip6_forward.c

index 000710e..8d4aead 100644 (file)
@@ -2652,7 +2652,7 @@ VLIB_REGISTER_NODE (ip4_rewrite_node) = {
 };
 
 VLIB_REGISTER_NODE (ip4_rewrite_bcast_node) = {
-  .function = ip4_rewrite,
+  .function = ip4_rewrite_bcast,
   .name = "ip4-rewrite-bcast",
   .vector_size = sizeof (u32),
 
index 888b526..efd5e0d 100644 (file)
@@ -2013,7 +2013,7 @@ VLIB_REGISTER_NODE (ip6_rewrite_node) =
 VLIB_NODE_FUNCTION_MULTIARCH (ip6_rewrite_node, ip6_rewrite);
 
 VLIB_REGISTER_NODE (ip6_rewrite_bcast_node) = {
-  .function = ip6_rewrite,
+  .function = ip6_rewrite_bcast,
   .name = "ip6-rewrite-bcast",
   .vector_size = sizeof (u32),