pppoe: fix coverity 218437, 218401 55/37055/3
authorAndrew Yourtchenko <ayourtch@gmail.com>
Wed, 31 Aug 2022 14:20:40 +0000 (14:20 +0000)
committerBeno�t Ganne <bganne@cisco.com>
Wed, 31 Aug 2022 15:29:35 +0000 (15:29 +0000)
Initialize the session index in case of error to ~0,
so is defined in case trace needs to copy it.

Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: Iddf6df42c09d2abc11e5821944eb4f41692e6e3e

src/plugins/pppoe/pppoe_decap.c

index fe83c3a..a1c37f6 100644 (file)
@@ -154,6 +154,7 @@ VLIB_NODE_FN (pppoe_input_node) (vlib_main_t * vm,
                    vlib_buffer_advance(b0, sizeof(*h0)+sizeof(*vlan0));
              error0 = PPPOE_ERROR_CONTROL_PLANE;
              next0 = PPPOE_INPUT_NEXT_CP_INPUT;
+             result0.fields.session_index = ~0;
              goto trace0;
             }
 
@@ -251,6 +252,7 @@ VLIB_NODE_FN (pppoe_input_node) (vlib_main_t * vm,
                    vlib_buffer_advance(b1, sizeof(*h1)+sizeof(*vlan1));
              error1 = PPPOE_ERROR_CONTROL_PLANE;
              next1 = PPPOE_INPUT_NEXT_CP_INPUT;
+             result1.fields.session_index = ~0;
              goto trace1;
             }
 
@@ -378,6 +380,7 @@ VLIB_NODE_FN (pppoe_input_node) (vlib_main_t * vm,
                    vlib_buffer_advance(b0, sizeof(*h0)+sizeof(*vlan0));
              error0 = PPPOE_ERROR_CONTROL_PLANE;
              next0 = PPPOE_INPUT_NEXT_CP_INPUT;
+             result0.fields.session_index = ~0;
              goto trace00;
             }