quic: fix wrong error checking 49/23149/2
authorDave Wallace <dwallacelf@gmail.com>
Thu, 31 Oct 2019 16:21:27 +0000 (12:21 -0400)
committerDamjan Marion <dmarion@me.com>
Thu, 31 Oct 2019 18:39:45 +0000 (18:39 +0000)
- Revert error checking to previous ASSERT

Type: fix
Fixes: 7c7fa9066

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I6d915d88bf932c74f9b866aec3bd1531e0cb47f4

src/plugins/quic/quic.c

index 076fd5e..66796c7 100644 (file)
@@ -509,12 +509,7 @@ quic_on_receive (quicly_stream_t * stream, size_t off, const void *src,
       /* Streams live on the same thread so (f, stream_data) should stay consistent */
       rlen = svm_fifo_enqueue (f, len, (u8 *) src);
       stream_data->app_rx_data_len += rlen;
-      if (PREDICT_FALSE (rlen != len))
-       {
-         clib_warning ("ERROR: Could not enqueue all data (rlen %u, len %u)",
-                       rlen, len);
-         ASSERT (rlen == len);
-       }
+      ASSERT (rlen >= len);
       app_wrk = app_worker_get_if_valid (stream_session->app_wrk_index);
       if (PREDICT_TRUE (app_wrk != 0))
        app_worker_lock_and_send_event (app_wrk, stream_session,