fix uninitialized ip6 keys within session.c 37/5637/2
authorGabriel Ganne <gabriel.ganne@enea.com>
Mon, 6 Mar 2017 14:31:18 +0000 (15:31 +0100)
committerDamjan Marion <dmarion.lists@gmail.com>
Tue, 7 Mar 2017 12:15:07 +0000 (12:15 +0000)
fix for functions:
- stream_session_lookup_listener6
- stream_session_lookup6
- stream_session_lookup_transport6
- stream_session_connect_notify

eg.
~/vpp/build-data/../src/vnet/session/session.c: In function 'stream_session_lookup_listener6':
~/vpp/build-data/../src/vnet/session/session.c:222:17: error: 'kv6.key[3]' is used uninitialized in this function [-Werror=uninitialized]
   session_kv6_t kv6;
                 ^
~/vpp/build-data/../src/vnet/session/session.c:222:17: error: 'kv6.key[2]' is used uninitialized in this function [-Werror=uninitialized]
~/vpp/build-data/../src/vnet/session/session.c:222:17: error: 'kv6.key[5]' is used uninitialized in this function [-Werror=uninitialized]
~/vpp/build-data/../src/vnet/session/session.c:222:17: error: 'kv6.key[4]' is used uninitialized in this function [-Werror=uninitialized]

Change-Id: I221cafbaf4effa43662ffcc7bf5f9581e28f9db9
Signed-off-by: Gabriel Ganne <gabriel.ganne@enea.com>
src/vnet/session/transport.h

index 2d4415b..f486dbb 100644 (file)
@@ -189,6 +189,10 @@ make_v6_ss_kv (session_kv6_t * kv, ip6_address_t * lcl, ip6_address_t * rmt,
 
   kv->key[0] = key.as_u64[0];
   kv->key[1] = key.as_u64[1];
+  kv->key[2] = 0;
+  kv->key[3] = 0;
+  kv->key[4] = 0;
+  kv->key[5] = 0;
   kv->value = ~0ULL;
 }
 
@@ -209,6 +213,10 @@ make_v6_listener_kv (session_kv6_t * kv, ip6_address_t * lcl, u16 lcl_port,
 
   kv->key[0] = key.as_u64[0];
   kv->key[1] = key.as_u64[1];
+  kv->key[2] = 0;
+  kv->key[3] = 0;
+  kv->key[4] = 0;
+  kv->key[5] = 0;
   kv->value = ~0ULL;
 }