Fix coverity issue introduced with IP checksum offload commit 44/7644/3
authorDamjan Marion <damarion@cisco.com>
Wed, 19 Jul 2017 13:07:10 +0000 (15:07 +0200)
committerFlorin Coras <florin.coras@gmail.com>
Thu, 20 Jul 2017 21:47:57 +0000 (21:47 +0000)
Change-Id: Ib5ad1369678389534426902ce698bccf7a6d9ec2
Signed-off-by: Damjan Marion <damarion@cisco.com>
src/vnet/ip/ip4_forward.c

index 4a9e791..4b05bf1 100755 (executable)
@@ -2458,7 +2458,7 @@ ip4_rewrite_inline (vlib_main_t * vm,
 
              /* Verify checksum. */
              ASSERT ((ip0->checksum == ip4_header_checksum (ip0)) ||
-                     (p0->flags | VNET_BUFFER_F_OFFLOAD_IP_CKSUM));
+                     (p0->flags & VNET_BUFFER_F_OFFLOAD_IP_CKSUM));
            }
          else
            {
@@ -2494,7 +2494,7 @@ ip4_rewrite_inline (vlib_main_t * vm,
 
              /* Verify checksum. */
              ASSERT ((ip1->checksum == ip4_header_checksum (ip1)) ||
-                     (p1->flags | VNET_BUFFER_F_OFFLOAD_IP_CKSUM));
+                     (p1->flags & VNET_BUFFER_F_OFFLOAD_IP_CKSUM));
            }
          else
            {
@@ -2633,7 +2633,7 @@ ip4_rewrite_inline (vlib_main_t * vm,
              ip0->ttl = ttl0;
 
              ASSERT ((ip0->checksum == ip4_header_checksum (ip0)) ||
-                     (p0->flags | VNET_BUFFER_F_OFFLOAD_IP_CKSUM));
+                     (p0->flags & VNET_BUFFER_F_OFFLOAD_IP_CKSUM));
 
              if (PREDICT_FALSE (ttl0 <= 0))
                {