Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
4585bb1
)
vlib: deuglify the offset finding loop in pci.c
36/39436/2
author
Vratko Polak
<vrpolak@cisco.com>
Wed, 23 Aug 2023 16:39:25 +0000
(18:39 +0200)
committer
Damjan Marion
<dmarion@0xa5.net>
Wed, 13 Sep 2023 12:17:53 +0000
(12:17 +0000)
Type: style
Fixes:
054229ebbdeb3f87d96c1abf93b511c86cd6ff0f
Change-Id: I7c3080db94566af249e5082d59a4e6373c616888
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
src/vlib/pci/pci.c
patch
|
blob
|
history
diff --git
a/src/vlib/pci/pci.c
b/src/vlib/pci/pci.c
index
1845a62
..
cd580f0
100644
(file)
--- a/
src/vlib/pci/pci.c
+++ b/
src/vlib/pci/pci.c
@@
-176,11
+176,7
@@
vlib_pci_function_level_reset (vlib_main_t *vm, vlib_pci_dev_handle_t h)
return err;
offset = cfg.cap_ptr;
- /* Make gcc happy, otherwise gcc fails build due to cap not set if offset ==
- * 0 */
- cap = (pci_capability_pcie_t *) (cfg.data + offset);
-
- while (offset)
+ do
{
cap = (pci_capability_pcie_t *) (cfg.data + offset);
@@
-189,6
+185,7
@@
vlib_pci_function_level_reset (vlib_main_t *vm, vlib_pci_dev_handle_t h)
offset = cap->next_offset;
}
+ while (offset);
if (cap->capability_id != PCI_CAP_ID_PCIE)
return clib_error_return (0, "PCIe capability config not found");