vpp.git
5 years agoGBP: Counters per-contract 76/18676/3
Neale Ranns [Thu, 4 Apr 2019 07:35:37 +0000 (00:35 -0700)]
GBP: Counters per-contract

Change-Id: I28bb9e3d3ea3a99a9e24801ef5241a0099186108
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agotcp: shorten wait in fin-wait-1 with fin rcvd 59/18659/6
Florin Coras [Wed, 3 Apr 2019 02:03:23 +0000 (19:03 -0700)]
tcp: shorten wait in fin-wait-1 with fin rcvd

Change-Id: Ifddc32ab3da0e691ac3df74ff26e19f6fa00fef7
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoAdd crypto_ia32 plugin 45/18645/9
Damjan Marion [Tue, 2 Apr 2019 17:06:50 +0000 (19:06 +0200)]
Add crypto_ia32 plugin

Currently this plugin provies AES CBC optimized code. Encryption code
supports parallel encryption of 4 buffers with different size and key
which improves performance 4x compared to standard serialized aproach.

On Skylake Server measured performance is around 0.71 clocks/byte with
256 buffers with size in range between 7000 and 8000 bytes.
Measured performance includes overhead of processing crypto ops.

Change-Id: I5ec2afee708fcdf16a4234926534dd64ff1155c3
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agogbp: Add bd flags 84/18484/6
Mohsin Kazmi [Fri, 22 Mar 2019 14:13:31 +0000 (15:13 +0100)]
gbp: Add bd flags

Add flags for unknown unicast drop, multicast and broadcast
drop and arp unicast.

Change-Id: I1203137510b8bee0a20ecfe5f2efad8043d4bac6
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoFix problem building rdma-core. 00/18600/3
Thomas F Herbert [Fri, 29 Mar 2019 19:41:48 +0000 (15:41 -0400)]
Fix problem building rdma-core.

Recent patches add rdma-core.
They are not building in Centos because of differences
in cmake. This patch fixes that problem by defining
CMAKE for all external builds.

Change-Id: I3eea869226385207500c5a1217bd7330140ca462
Signed-off-by: Thomas F Herbert <therbert@redhat.com>
5 years agolacp: passive mode support [VPP-1551] 35/18035/4
Steven Luong [Tue, 5 Mar 2019 17:38:33 +0000 (09:38 -0800)]
lacp: passive mode support [VPP-1551]

By definition, passive mode means the node does not start sending lacp pdu until
it first hears from the partner or remote.

- Rename ptx machine's BEGIN state to NO_PERIODIC state.
- Put periodic machine in NO_PERIDOIC state when the interface is enabled for
lacp. ptx machine will transition out of NO_PERIODIC state when the local node
hears from the remote or when the local node is configured for active mode.
- Also add send and receive statistics for debugging.

Change-Id: I747953b9595ed31328b2f4f3e7a8d15d01e04d7f
Signed-off-by: Steven Luong <sluong@cisco.com>
5 years agoIPSEC: correctly size per-thread data 67/18667/2
Neale Ranns [Wed, 3 Apr 2019 13:36:56 +0000 (13:36 +0000)]
IPSEC: correctly size per-thread data

Change-Id: Idfc05cd0e09b50a26eaf747b7c49f720b009159a
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agovirtio: Add support for multiqueue 06/17306/8
Mohsin Kazmi [Tue, 2 Apr 2019 11:45:08 +0000 (11:45 +0000)]
virtio: Add support for multiqueue

Change-Id: Id71ffa77e977651f219ac09d1feef334851209e1
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agopci: Fix the crash on deleting the pci device 35/18635/2
Mohsin Kazmi [Tue, 2 Apr 2019 11:09:49 +0000 (11:09 +0000)]
pci: Fix the crash on deleting the pci device

clib_file_index is 0 if it is not initialized result in
following assertion on deleteing the pci device.

vpp/src/vppinfra/file.h:122 (clib_file_del_by_index) assertion `! pool_is_free (um->file_pool, _e)' fails

This patch fixes the issue by initializing the clib_file_index to -1.

Change-Id: I51d23f18e7ccf3143a4765d05aafc1363a007737
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agordma: tx: fix stats and add batching 63/18663/3
Benoît Ganne [Mon, 1 Apr 2019 14:05:22 +0000 (16:05 +0200)]
rdma: tx: fix stats and add batching

Tx stats are no longer counted twice.
Submit tx packets as a single batch per vector instead of per-packet

Change-Id: I26820b21f23842b3a67ace0b939095f3550d3856
Signed-off-by: Benoît Ganne <bganne@cisco.com>
5 years agoIPSEC: show CLI improvements 65/18665/2
Neale Ranns [Wed, 3 Apr 2019 13:17:50 +0000 (13:17 +0000)]
IPSEC: show CLI improvements

Change-Id: I48a4b0a16f71cbab04dd0955d3ec4001074b57ed
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoGBP: iVXLAN reflection check 91/18591/4
Neale Ranns [Fri, 29 Mar 2019 12:08:27 +0000 (05:08 -0700)]
GBP: iVXLAN reflection check

packets should not egress on an iVXLAN tunnel if they
arrived on one.

Change-Id: I9adca30252364b4878f99e254aebc73b70a5d4d6
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoQUIC: Build system update 19/18619/3
Aloys Augustin [Mon, 1 Apr 2019 14:43:29 +0000 (16:43 +0200)]
QUIC: Build system update

Download a single tarball with the sources of quicly and its dependencies from github instead of cloning submodules.

Change-Id: Id9955565d46f595b3a14ba3408c24045d4acd296
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
5 years agosession: allow more fifos in preallocated segments 56/18656/4
Florin Coras [Tue, 2 Apr 2019 23:45:50 +0000 (16:45 -0700)]
session: allow more fifos in preallocated segments

Change-Id: I335c092a8965c5dbec58603e9f5063dc8e3fc3ed
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agosession: fix cli for sessions in created state 58/18658/3
Florin Coras [Wed, 3 Apr 2019 00:47:03 +0000 (17:47 -0700)]
session: fix cli for sessions in created state

Change-Id: Ie154afdc20000b905ff71e39823154db4d23eea4
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agosession: do not enable pre-input node with 0 workers 57/18657/2
Florin Coras [Wed, 3 Apr 2019 00:06:05 +0000 (17:06 -0700)]
session: do not enable pre-input node with 0 workers

Change-Id: I5c9e27b664ff1a8a74a6c1388f98af63571db7a5
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agostat-segment: scaling improvement 39/18639/2
Neale Ranns [Tue, 2 Apr 2019 11:53:26 +0000 (11:53 +0000)]
stat-segment: scaling improvement

don't walk the entire list of entries each time a new one is added

approximate/indicative numbers recorded on a VM:
after:
  50000 tunnels in 1.124443 secs, 44466.45 tunnels/sec
before:
  50000 tunnels in 5.202779 secs, 9610.25 tunnels/sec

Change-Id: Ie1155416be76f55f2a0a88360ce53e15aeace785
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agosession: remove session logic from io rx evt sender 46/18646/3
Florin Coras [Tue, 2 Apr 2019 17:17:48 +0000 (10:17 -0700)]
session: remove session logic from io rx evt sender

Change-Id: I54fff6986ea6455aff25e0cf1b83117860859e10
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agosession: use app cb function wrappers 51/18651/2
Florin Coras [Tue, 2 Apr 2019 18:38:51 +0000 (11:38 -0700)]
session: use app cb function wrappers

Change-Id: I77ad9eb4d4c7699397aa4be6a973ef37c60db4c5
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agovppinfra: add u32x4 min / max sse4.2 inlines 44/18644/1
Damjan Marion [Tue, 2 Apr 2019 17:06:50 +0000 (19:06 +0200)]
vppinfra: add u32x4 min / max sse4.2 inlines

Change-Id: I38e0be777199654ece286fdd1a42931ed99bbe8a
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agotcp: improve rcv process ack processing 12/18612/8
Florin Coras [Mon, 1 Apr 2019 00:17:11 +0000 (17:17 -0700)]
tcp: improve rcv process ack processing

- Avoid doing cc in closing states.
- Rest connections closed with unread data

Change-Id: I97d46b0459f03ea5439eeb0f233b6c17d3e06dfd
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agolisp: use crypto lib instead of openssl directly 38/18638/2
Filip Tehlar [Thu, 21 Mar 2019 12:56:59 +0000 (05:56 -0700)]
lisp: use crypto lib instead of openssl directly

Change-Id: I9667ed16939dede55b24959045737742d1c7c449
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
5 years agoIPSEC-GRE; tests 03/18603/3
Neale Ranns [Fri, 29 Mar 2019 20:23:58 +0000 (20:23 +0000)]
IPSEC-GRE; tests

failing test disabled on ARM

Change-Id: I6b7535cd8f51fdaf9786ba77f9f61a7d8d049bbd
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoIPSEC: tunnel scaling - don't stack the inbould SA 32/18632/3
Neale Ranns [Tue, 2 Apr 2019 10:15:40 +0000 (10:15 +0000)]
IPSEC: tunnel scaling - don't stack the inbould SA

Change-Id: I0b47590400aebea09aa1b27de753be638e1ba870
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoIPSEC: remove pointless feature ordering 36/18636/1
Neale Ranns [Tue, 2 Apr 2019 12:43:34 +0000 (05:43 -0700)]
IPSEC: remove pointless feature ordering

Change-Id: Ic1b657794d23cb4d1664fc749ad2468339e376df
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agodpdk: fix build error when mlx support enabled 26/18626/2
Matthew Smith [Mon, 1 Apr 2019 23:38:59 +0000 (18:38 -0500)]
dpdk: fix build error when mlx support enabled

When building with environment variables set to enable mlx PMD
support in DPDK, an error occurs:

CMake Error at plugins/dpdk/CMakeLists.txt:104 (vpp_plugin_find_library):
  vpp_plugin_find_library Macro invoked with incorrect arguments for macro
  named: vpp_plugin_find_library

Update a call to vpp_plugin_find_library() to include the right
number of parameters.

Change-Id: Ia0d66f93c6f94fdf822e2c3c4fe3f0ad01a90d57
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
5 years agovppinfra: fix sparse_vec_index() returning non-zero index for some nonexistent elements 79/18579/6
Andrew Yourtchenko [Thu, 28 Mar 2019 19:36:56 +0000 (20:36 +0100)]
vppinfra: fix sparse_vec_index() returning non-zero index for some nonexistent elements

If we are testing for an index whose membership bitmask happens to sit in LSB of uword,
and there is nothing else set in that uword in the member bitmask, the shortcut path
returning the valid index is taken even if the element with a given index doesn't
exist in the sparse vector. This happens because the count of leading zeroes on the
value of 0 is zero, which is equal to the value taken modulo bitsize uword.

Take care of that case.

Also add unittests showing the problem and verifying that sparse_vec_index2 does not
have the same issue.

Change-Id: I19117e13817c3e5de579b9250bb741de42491985
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agodpdk 19.02: fixed speed capability error issue 59/18559/2
Chenmin Sun [Thu, 28 Mar 2019 13:36:45 +0000 (21:36 +0800)]
dpdk 19.02: fixed speed capability error issue

Device speed capability should be specified based on different phy types
instead of a fixed value, this patch fix the issue.

Change-Id: Ia76231aefbcb0fe8370867b6e86a0d3bb9e169a0
Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
5 years agoEnhance vlib_buffer_clone to change headroom space for packet 20/18620/1
John Lo [Mon, 1 Apr 2019 15:30:07 +0000 (11:30 -0400)]
Enhance vlib_buffer_clone to change headroom space for packet

Add function vlib_buffer_clone_at_offset() so that the cloned
packets' 1st buffer will have the original packet header copied
at the specified offset (instead of current_data). This can be
used to increase headroom in the cloned packet to allow large
header encaps in case the stdandard 128B predata is not enough.
The original vlib_buffer_clone() still works the same as before.

Change-Id: I3b50c8ad7e3952568bc141710567c99a3dacddce
Signed-off-by: John Lo <loj@cisco.com>
5 years agoVPP-1576: fix a class of spurious warnings 11/18611/2
Dave Barach [Sat, 30 Mar 2019 14:24:28 +0000 (10:24 -0400)]
VPP-1576: fix a class of spurious warnings

Change-Id: I52198e97397bb6f3b5c0c30c44aac34c17650d4d
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agovppinfra: add few more cpuid flags 10/18610/1
Damjan Marion [Sat, 30 Mar 2019 11:56:37 +0000 (12:56 +0100)]
vppinfra: add few more cpuid flags

Change-Id: Ic2a61c45face18b6dd23d5509d75367d3b2441e9
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoSPAN: Add pending frame on current thread, not on main 07/18607/1
Igor Mikhailov (imichail) [Sat, 30 Mar 2019 02:25:15 +0000 (19:25 -0700)]
SPAN: Add pending frame on current thread, not on main

Previously, all frames were put for next node on the main thread,
even if the execution was happening on a worker thread.

Also, refactor to use API function vnet_get_main()

Change-Id: Ibefb1b3871563a78aa30352a37b9216537e15bf7
Signed-off-by: Igor Mikhailov (imichail) <imichail@cisco.com>
5 years agoConvince Coverity that s = format (0, ...) is OK 05/18605/1
Dave Barach [Fri, 29 Mar 2019 23:41:50 +0000 (19:41 -0400)]
Convince Coverity that s = format (0, ...) is OK

Change-Id: Ia88c7228a46e251b8a7815240da6ddbbcde08bc7
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoMinor bug fixes 99/18599/3
Dave Barach [Fri, 29 Mar 2019 18:08:45 +0000 (14:08 -0400)]
Minor bug fixes

Drop the session reader lock across vlib_process_suspend(...) calls.
Fix the debug CLI command.

Change-Id: Ic0266dda1fdfa90971f2cb935248941317c01205
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agorevert quicly related build/external changes 01/18601/1
Damjan Marion [Fri, 29 Mar 2019 20:22:09 +0000 (21:22 +0100)]
revert quicly related build/external changes

We dont't want git pull there, there is simple way to grab tarball
from github for every single commit

Change-Id: I7a98cab7660750e48084279d8b9892cdf229bceb
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoIPSEC-GRE: fixes and API update to common types. 91/17691/14
Neale Ranns [Tue, 19 Feb 2019 15:22:46 +0000 (15:22 +0000)]
IPSEC-GRE: fixes and API update to common types.

Change-Id: Icdcbac7453baa837a9c0c4a2401dff4a6aa6cba0
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agotests: test/vpp_l2.py fix missing name. 82/18582/2
Paul Vinciguerra [Thu, 28 Mar 2019 20:07:00 +0000 (13:07 -0700)]
tests: test/vpp_l2.py fix missing name.

test/vpp_l2.py:213:26: F821 undefined name 'L2_VTR_OP'
        self.itf.set_vtr(L2_VTR_OP.L2_DISABLED)

Move L2_VTR_OP enum to vpp_sub_interface.py where the VTR code is found.

Change-Id: I9eb9a3a2c679813c221ce1d0c4fa8aac6076c443
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agovls: add pthread check on vls_attr 97/18597/3
Florin Coras [Fri, 29 Mar 2019 15:29:25 +0000 (08:29 -0700)]
vls: add pthread check on vls_attr

Change-Id: I455d108dfe52d45d040167fecb37b33e9d630c3c
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agotests: refactor vpp_object.py 78/18578/3
Paul Vinciguerra [Thu, 28 Mar 2019 16:53:44 +0000 (09:53 -0700)]
tests: refactor vpp_object.py

Move __str__ to super for all subclasses of VppObject
Implement __repr__ in VppObject
Implement __hash__ and __eq__

Change-Id: Ibd4ea37b84b17f499ab86630fb5b9ed9c8b4b1c2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agoIntegrate first QUIC protocol implementation 78/18378/11
Nathan Skrzypczak [Tue, 19 Mar 2019 12:57:31 +0000 (13:57 +0100)]
Integrate first QUIC protocol implementation

Currently supports on single stream exposed through standard internal APIs
Based on libquicly & picotls by h2o

Change-Id: I7bc1ec0e399d1fb02bfd1da91aa7410076d08d14
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
5 years agoVOM: recurive route update fix 93/18593/2
Neale Ranns [Fri, 29 Mar 2019 12:59:01 +0000 (05:59 -0700)]
VOM: recurive route update fix

Change-Id: Iff61904804d8218c4e02897521368f696002343d
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoBVI: coverity error fix 89/18589/2
Neale Ranns [Fri, 29 Mar 2019 11:37:59 +0000 (11:37 +0000)]
BVI: coverity error fix

Change-Id: Idc1e1747035638777240b7ea9afcf675b22be7f1
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoUpdate MAINTAINERS 90/18590/1
Dave Barach [Fri, 29 Mar 2019 12:17:20 +0000 (08:17 -0400)]
Update MAINTAINERS

Change-Id: I1b041edb6f20a9f9c867fb243922985398485054
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoipsec: esp-decrypt rework 38/18538/7
Damjan Marion [Mon, 25 Mar 2019 14:54:40 +0000 (15:54 +0100)]
ipsec: esp-decrypt rework

Change-Id: Icf83c876d0880d1872b84e0a3d34be654b76149f
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoIPSEC: tunnel fragmentation 68/18568/4
Neale Ranns [Thu, 28 Mar 2019 08:56:10 +0000 (08:56 +0000)]
IPSEC: tunnel fragmentation

Change-Id: I63741a22bc82f5f861e1c0f26a93b5569cc52061
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agotcp: remove sent rcv wnd 0 flag 87/18587/2
Florin Coras [Thu, 28 Mar 2019 23:31:52 +0000 (16:31 -0700)]
tcp: remove sent rcv wnd 0 flag

Change-Id: If6c672d1caa8884eb5d819311606a79a3de81200
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agodhcp: only register UDP ports that are needed 54/18554/3
Matthew Smith [Wed, 27 Mar 2019 17:30:29 +0000 (12:30 -0500)]
dhcp: only register UDP ports that are needed

When configuring a DHCP client, both the UDP ports for DHCP client
and server are registered. Packets to the server port end up being
dropped unless you have also configured a DHCP proxy.

This breaks a common home/office gateway use case where the WAN
interface gets configured using a DHCP client and devices attached
to a LAN interface attempt to configure themselves using DHCP. If
you try to punt to an external DHCP daemon to handle the LAN client
requests, the packets never make it to the external daemon because
of the server port being registered.

Modify dhcp_maybe_register_udp_ports() to accept a parameter that
controls which ports get registered. For a DHCP client, only the
client port is registered. For a DHCP proxy, both client and server
ports are registered.

Change-Id: I2182d9827e4c7424b03ebb94952c3d2dc37abdb6
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
5 years agotcp: improve updating of rcv wnd 81/18581/2
Florin Coras [Thu, 28 Mar 2019 20:21:19 +0000 (13:21 -0700)]
tcp: improve updating of rcv wnd

Change-Id: I0b8a311979d3ccd15f3854e7ac44ca9951dc6ce4
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agordma: add option to specify inteface name 86/18586/2
Damjan Marion [Thu, 28 Mar 2019 22:34:56 +0000 (23:34 +0100)]
rdma: add option to specify inteface name

Change-Id: Ic6244511b88bdd42756f74e3163a70b8014e8547
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocrypto: add vnet_crypto_op_init (...) 83/18583/3
Damjan Marion [Thu, 28 Mar 2019 20:40:48 +0000 (21:40 +0100)]
crypto: add vnet_crypto_op_init (...)

Change-Id: I2018d8367bb010e1ab30d9c7c23d9501fc38a2e5
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoipsec: USE_EXTENDED_SEQ_NUM -> USE_ESN 66/18566/6
Damjan Marion [Thu, 28 Mar 2019 09:58:59 +0000 (10:58 +0100)]
ipsec: USE_EXTENDED_SEQ_NUM -> USE_ESN

Change-Id: Ib828ea5106f3ae280e4ce233f2462dee363580b7
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agocmake: add vpp_plugin_find_library macro 80/18580/2
Damjan Marion [Thu, 28 Mar 2019 19:54:47 +0000 (20:54 +0100)]
cmake: add vpp_plugin_find_library macro

Change-Id: I0b996460e05c40e74766563fb2a94c62a65063ce
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoPunt Infra 48/15148/15
Neale Ranns [Fri, 28 Sep 2018 15:16:14 +0000 (15:16 +0000)]
Punt Infra

A punt/exception path that provides:
 1) clients that use the infra
 2) clients can create punt reasons
 3) clients can register to recieve packets that are punted
    for a given reason to be sent to the desired node.
 4) nodes which punt packets fill in the {reason,protocol} of the
    buffere (in the meta-data) and send to the new node "punt-dispatch"
 5) punt-dispatch sends packets to the registered nodes or drops

Change-Id: Ia4f144337f1387cbe585b4f375d0842aefffcde5
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoipsec: anti-replay code cleanup 77/18577/3
Damjan Marion [Thu, 28 Mar 2019 18:19:31 +0000 (19:19 +0100)]
ipsec: anti-replay code cleanup

Change-Id: Ib73352d6be26d639a7f9d47ca0570a1248bff04a
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agosession: remove unused tx context field 73/18573/2
Florin Coras [Thu, 28 Mar 2019 15:34:25 +0000 (08:34 -0700)]
session: remove unused tx context field

Change-Id: I4a119937842eb188f5e5a7706cbe70e91ae4def8
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoAdd RDMA ibverb driver plugin 43/17643/11
Benoît Ganne [Mon, 25 Mar 2019 10:41:34 +0000 (11:41 +0100)]
Add RDMA ibverb driver plugin

RDMA ibverb is a userspace API to efficiently rx/tx packets. This is an
initial, unoptimized driver targeting Mellanox cards.
Next steps should include batching, multiqueue and additional cards.

Change-Id: I0309c7a543f75f2f9317eaf63ca502ac7a093ef9
Signed-off-by: Benoît Ganne <bganne@cisco.com>
5 years agosession: cap max burst to a constant 57/18557/4
Florin Coras [Thu, 28 Mar 2019 01:55:11 +0000 (18:55 -0700)]
session: cap max burst to a constant

Change-Id: I1919d3844936486f04f2bfde24dc7e0d9121927a
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoAvoid overwrite in clib_memcpy_le{32,64} 71/18571/2
Damjan Marion [Thu, 28 Mar 2019 15:19:24 +0000 (16:19 +0100)]
Avoid overwrite in clib_memcpy_le{32,64}

Change-Id: Id4a8b6a31fc3e88af2f075cb97c85d3f9b738d9e
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoVXLAN-GBP: format flags in encap trace 70/18570/2
Neale Ranns [Thu, 28 Mar 2019 15:01:47 +0000 (08:01 -0700)]
VXLAN-GBP: format flags in encap trace

Change-Id: I561fd187b4865345f3bff86b3d6e67b0f0e97557
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agotcp: remove unused buffer flags 74/18574/1
Florin Coras [Thu, 28 Mar 2019 15:39:01 +0000 (08:39 -0700)]
tcp: remove unused buffer flags

Change-Id: I86e71f32dee3cc48f680e6432a96caef0a7f66a1
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoIPSEC: 4o6 and 6o4 for tunnel interfaces 60/18560/2
Neale Ranns [Wed, 27 Mar 2019 13:40:35 +0000 (13:40 +0000)]
IPSEC: 4o6 and 6o4 for tunnel interfaces

Change-Id: I4d3ba18ab5205317219989de55b6e50d3b1d8a79
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoIPSEC: fix build breakage from ships in the night merges 61/18561/1
Neale Ranns [Thu, 28 Mar 2019 08:59:12 +0000 (08:59 +0000)]
IPSEC: fix build breakage from ships in the night merges

Change-Id: Iec7da9adc970d005cd7d3d42839b5e51b0b5f5c3
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agovat:ignore SIGWINCH signal 24/18524/4
ezkexma [Tue, 26 Mar 2019 14:24:38 +0000 (10:24 -0400)]
vat:ignore SIGWINCH signal

vpp/src/vat/main.c
When change the window size,the vat will get the SIGWINCH signal and then exit.
It is not a exit action,so we can ignore it.

Change-Id: If796762216910e23cace09406d413331f505d990
Signed-off-by: ezkexma <maqi.z.ke@ericsson.com>
5 years agoAppImage packaging 95/18495/3
Dave Barach [Sun, 24 Mar 2019 20:25:03 +0000 (16:25 -0400)]
AppImage packaging

Disabled by default. To kick the the tires:

wget https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-x86_64.AppImage
sudo mv linuxdeploy-x86_64.AppImage /usr/local/bin/linuxdeploy
sudo chmod +x linuxdeploy-x86_64.AppImage

Enable VPP_BUILD_APPIMAGE e.g. in ccmake
make build | make build-release

The vpp AppImage lands in .../install-xxx-native/VPP-x86_64.AppImage. To run it:

./VPP-x86_64.AppImage vpp unix interactive

To run it (as root) and inhale the usual startup.conf:

sudo ./VPP-x86_64.AppImage \${HERE}/bin/vpp -c \${HERE}/etc/vpp/startup.conf

To run vppctl, or any of the usual vpp binaries:

./VPP-x86_64.AppImage vppctl [etc]

Change-Id: Ide8cf4658cbb56f1d36a1ce7fc8f7338f8d38278
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoIPSEC: run encrpyt as a feautre on the tunnel 37/18537/3
Neale Ranns [Fri, 22 Mar 2019 08:12:48 +0000 (08:12 +0000)]
IPSEC: run encrpyt as a feautre on the tunnel

Change-Id: I6527e3fd8bbbca2d5f728621fc66b3856b39d505
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoTypos. A bunch of typos I've been collecting. 56/18556/3
Paul Vinciguerra [Wed, 27 Mar 2019 18:25:48 +0000 (11:25 -0700)]
Typos.  A bunch of typos I've been collecting.

Change-Id: I53ab8d17914e6563110354e4052109ac02bf8f3b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agomake-test: fix ValueError raised by hook in python3 55/18555/2
Naveen Joy [Wed, 27 Mar 2019 21:28:50 +0000 (14:28 -0700)]
make-test: fix ValueError raised by hook in python3

Without this patch, the hook module raises a ValueError
when tests are run using python3. This patch updates the
exception being caught by ipaddress to ValueError.

Change-Id: I5e11e292a05ddf350fc04ebaf19cfd7dad2bd9d0
Signed-off-by: Naveen Joy <najoy@cisco.com>
5 years agoVOM: routes support multipath so set is_multipath in route update 48/18548/2
Neale Ranns [Wed, 27 Mar 2019 12:32:03 +0000 (05:32 -0700)]
VOM: routes support multipath so set is_multipath in route update

Change-Id: Ib0249aec00c8a8306f2cf25394d39b4b7850d8f7
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoGBP: fixes for l3-out routing 47/18547/3
Neale Ranns [Wed, 27 Mar 2019 12:06:47 +0000 (05:06 -0700)]
GBP: fixes for l3-out routing

Change-Id: I4d73b712da911588d511a8401b73cdc3c66346fe
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoipsec: compress ipsec_sa_t so data used by dataplane code fits in cacheline 31/18531/3
Damjan Marion [Tue, 26 Mar 2019 12:16:42 +0000 (13:16 +0100)]
ipsec: compress ipsec_sa_t so data used by dataplane code fits in cacheline

Change-Id: I81ecdf9fdcfcb017117b47dc031f93208e004d7c
Signed-off-by: Damjan Marion <damarion@cisco.com>
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agotcp: add cc algo lookup table 40/18540/2
Florin Coras [Tue, 26 Mar 2019 21:05:38 +0000 (14:05 -0700)]
tcp: add cc algo lookup table

Change-Id: Ie7be0136c182cdc35193e47dd3249153c2f8d65e
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agovom: Add support for BVI interface 18/18518/3
Mohsin Kazmi [Mon, 25 Mar 2019 15:41:01 +0000 (16:41 +0100)]
vom: Add support for BVI interface

Change-Id: Ie93f3a2107df0452f7a7436b78c337f482904899
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoFIB: do debug before remvoing last source 35/18535/2
Neale Ranns [Tue, 26 Mar 2019 14:25:11 +0000 (07:25 -0700)]
FIB: do debug before remvoing last source

Change-Id: I4e1cde754eb4d6406cd6cd51f37d89552bdb6a53
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoGBP: missing L3-out type coversion 36/18536/2
Neale Ranns [Tue, 26 Mar 2019 15:54:32 +0000 (08:54 -0700)]
GBP: missing L3-out type coversion

Change-Id: Ic6455a930fcb21b055bcf093359bc8328f88140a
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoAdd missing OpenSUSE Leap 15.0 build deps 30/18530/2
Benoît Ganne [Tue, 26 Mar 2019 09:27:57 +0000 (10:27 +0100)]
Add missing OpenSUSE Leap 15.0 build deps

Fresh OpenSUSE Leap 15.0 containers are missing build dependencies.

Change-Id: I9b62f36c658862d8f32db5547d2176e6f56df4ea
Signed-off-by: Benoît Ganne <bganne@cisco.com>
5 years agoADJ: midchain delegate to performing stacking 26/18526/4
Neale Ranns [Tue, 26 Mar 2019 07:02:58 +0000 (07:02 +0000)]
ADJ: midchain delegate to performing stacking

this can be used by e.g. tunnels so it doesn't need to be
implemented for each tunnel type.

Change-Id: I0790f89aa49f83421612b35108cce67693285999
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoIPSEC: more expressive API errors 27/18527/3
Neale Ranns [Tue, 26 Mar 2019 08:21:25 +0000 (08:21 +0000)]
IPSEC: more expressive API errors

Change-Id: I517a7bdae03abfea58451819e7854974397d77f8
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agonode: vector must be checked with vec_header 72/18172/2
Kingwel Xie [Mon, 11 Mar 2019 07:53:48 +0000 (03:53 -0400)]
node: vector must be checked with vec_header

see register_node, node-name might be a vector

Change-Id: I883ec51c1fa9aa4da4ba6cba415a39bb6a4331e1
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
5 years agoVPP-1508: Tests: Update version of syslog_rfc5424_parser. 02/18402/2
Paul Vinciguerra [Wed, 20 Mar 2019 01:58:35 +0000 (18:58 -0700)]
VPP-1508: Tests: Update version of syslog_rfc5424_parser.

Bump to version v0.3.1.
Fixes an issue with stdlib enum imports under python3.5.

Change-Id: I7d8cb9e8ae9321beb4cb2ba052b08e776590c75d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
5 years agocrypto: add set crypto handler CLI 19/18519/4
Filip Tehlar [Mon, 25 Mar 2019 16:04:41 +0000 (09:04 -0700)]
crypto: add set crypto handler CLI

Change-Id: I40124f8d6e529256b1ccc6eb78dda9c5119b8951
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
5 years agoperfmon: fix pmc hw indices out-dated when multiple pmc 47/18447/2
Su Wang [Thu, 21 Mar 2019 04:14:14 +0000 (00:14 -0400)]
perfmon: fix pmc hw indices out-dated when multiple pmc

When adding two or more events using a single "set pmc",
the pmc hardware indices might be out-dated due to kernel
reschdeduling the perf_event hardware counters.
E.g. set pmc cpu-cycles cache-misses

Solution:
Open and enable all the events first, then aquire the
indices from the kernel.

Change-Id: I6913a871ab169e3b2855ac6159f527a1fca343e9
Signed-off-by: Su Wang <su.z.wang@ericsson.com>
5 years agoip6-rewrite: bug fix buffer->error in dual loop 08/18408/3
Kingwel Xie [Wed, 20 Mar 2019 07:45:47 +0000 (03:45 -0400)]
ip6-rewrite: bug fix buffer->error in dual loop

error should be recorded in buffer so that
process-error-punt can handle them correctly

Per Damjan's comments, move counter to under
else clause of last error0==NONE check. Both
v4 and v6 are changed.

Change-Id: I707c7877ccb12589337155173fc4a5200b42ee93
Signed-off-by: Kingwel Xie <kingwel.xie@ericsson.com>
5 years agoipsec: esp-encrypt rework 98/18398/18
Damjan Marion [Tue, 19 Mar 2019 14:38:40 +0000 (15:38 +0100)]
ipsec: esp-encrypt rework

Change-Id: Ibe7f806b9d600994e83c9f1be526fdb0a1ef1833
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoConvert GRE nodes to new buffer APIs and multiarch 66/17966/5
Benoît Ganne [Fri, 1 Mar 2019 13:19:55 +0000 (14:19 +0100)]
Convert GRE nodes to new buffer APIs and multiarch

Change-Id: I3b3c8333287bb704ac7b0bbc81b3dbb059e8d2ac
Signed-off-by: Benoît Ganne <bganne@cisco.com>
5 years agoSimplify adjacency rewrite code 68/17968/4
Benoît Ganne [Fri, 1 Mar 2019 13:14:10 +0000 (14:14 +0100)]
Simplify adjacency rewrite code

Using memcpy instead of complex specific copy logic. This simplify
the implementation and also improve perf slightly.
Also move adjacency data from tail to head of buffer, which improves
cache locality (header and data share the same cacheline)
Finally, fix VxLAN which used to workaround vnet_rewrite logic.

Change-Id: I770ddad9846f7ee505aa99ad417e6a61d5cbbefa
Signed-off-by: Benoît Ganne <bganne@cisco.com>
5 years agoIPSEC: improved policy delete 28/18528/1
Neale Ranns [Tue, 26 Mar 2019 08:26:39 +0000 (08:26 +0000)]
IPSEC: improved policy delete

Change-Id: Icdf51b094c34725c079d2e4acbb955744434302d
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoVCL: add TLS opt to socket_test.sh 23/18523/1
Dave Wallace [Mon, 25 Mar 2019 23:34:50 +0000 (19:34 -0400)]
VCL: add TLS opt to socket_test.sh

- add TLS transport opt to socket_test.sh
- resolve clash in vcl_test* args with
  socket_test.sh opts

Change-Id: I952d5b64942664bc3af1098f67445e0f4b93ab32
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
5 years agotls: make first segment and fifo size configurable 17/18517/2
Florin Coras [Mon, 25 Mar 2019 15:30:53 +0000 (08:30 -0700)]
tls: make first segment and fifo size configurable

Change-Id: I6169ebdd3ac2d5d77fd2e12068c8aab6d8072c03
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoIPSEC tests fnd fix or Extended Sequence Numbers 10/18510/5
Neale Ranns [Thu, 21 Mar 2019 14:34:09 +0000 (14:34 +0000)]
IPSEC tests fnd fix or Extended Sequence Numbers

Change-Id: Iad6c4b867961ec8036110a4e15a829ddb93193ed
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoUDP: Fix session registration in lookup table 01/18501/2
Aloys Augustin [Mon, 25 Mar 2019 10:29:17 +0000 (11:29 +0100)]
UDP: Fix session registration in lookup table

This fixes a bug where packets could be sent but not received when opening an UDP connection.

Change-Id: I0993dd806b277374232d551167970ab13a62dbf9
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
5 years agoadd api trace print 48/18448/5
ezkexma [Thu, 21 Mar 2019 11:38:19 +0000 (07:38 -0400)]
add api trace print

/vpp/src/vlibapi/api_shared.c
after "set api-trace debug on",api trace will be print ontime when clients send msg to vpp.

Change-Id: Ib2e504afb9e674c5cdfa6dc5c522c7af0396d687
Signed-off-by: ezkexma <maqi.z.ke@ericsson.com>
5 years agoFix unformat proto UDPC / UDP conflict 99/18499/2
Nathan Skrzypczak [Mon, 25 Mar 2019 09:20:56 +0000 (10:20 +0100)]
Fix unformat proto UDPC / UDP conflict

Change-Id: I9161959536c37f6f730650c9c0058a41af8e7001
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
5 years agovxlan-gbp: Add api custom-dump 15/18215/3
Mohsin Kazmi [Tue, 12 Mar 2019 15:40:47 +0000 (16:40 +0100)]
vxlan-gbp: Add api custom-dump

Change-Id: I1cb391c56463a770d874b2bfc8a0b7f6909ba55a
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agotcp: make default mtu configurable 86/18486/2
Florin Coras [Fri, 22 Mar 2019 22:42:18 +0000 (15:42 -0700)]
tcp: make default mtu configurable

Change-Id: I56d8d8d67d5590e24c1ddb54b0c63a2cb03798e1
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoDOC-ONLY: improve multi-arch documentation 85/18485/1
Dave Barach [Fri, 22 Mar 2019 19:49:45 +0000 (15:49 -0400)]
DOC-ONLY: improve multi-arch documentation

Document CLIB_MARCH_FN and CLIB_MARCH_FN_SELECT

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I661ba2af79db8205d70fa87203d40a2e31b795e4

5 years agoacl-plugin: get rid of doubly-linked list fields in hash applied ACEs 80/18480/2
Andrew Yourtchenko [Wed, 20 Mar 2019 16:47:03 +0000 (17:47 +0100)]
acl-plugin: get rid of doubly-linked list fields in hash applied ACEs

With collision match vector, the doubly-linked list is not needed anymore.

Change-Id: Iaf667ebe6ce0bdd78306bec31d3949e6acb8d401
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agoacl-plugin: tuplemerge: fix a crash during soak test with split partition 79/18479/2
Andrew Yourtchenko [Wed, 20 Mar 2019 16:44:14 +0000 (17:44 +0100)]
acl-plugin: tuplemerge: fix a crash during soak test with split partition

Reload the hash-ready ACE vector pointer during the partition split
with each iteration, since the ACL# may change.

Change-Id: I1b001e06b52ff02ef59ca1d890f8462ca99e6634
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agoacl-plugin: get rid of a separate "count" field in the linear acl struct 15/18415/2
Andrew Yourtchenko [Wed, 20 Mar 2019 10:11:19 +0000 (11:11 +0100)]
acl-plugin: get rid of a separate "count" field in the linear acl struct

Long time ago, the linear array of rules in the ACL structure was not
a vector. Now it is, so get rid of the extraneous "count" member.
Do so in a manner that would ease potential the MP-safe manipulation of
ACL rules in the future.

Change-Id: Ib9c0731e4f21723c9ec4d7f00c3e5ead8e1e97bd
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agocrypto: implement rfc4231 test cases 16/18416/3
Filip Tehlar [Wed, 20 Mar 2019 09:43:20 +0000 (02:43 -0700)]
crypto: implement rfc4231 test cases

Change-Id: I540241672a20f687d20bb70adbf2b33200f34167
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
5 years agoipv6: vectorized ext header check 83/18483/2
Damjan Marion [Fri, 22 Mar 2019 12:58:08 +0000 (13:58 +0100)]
ipv6: vectorized ext header check

Change-Id: I454bb01153d1d0536c4a6fe36103e7721aad8cd1
Signed-off-by: Damjan Marion <damarion@cisco.com>