vpp.git
4 years agol2: l2tp API cleanup 22/23022/3
Jakub Grajciar [Mon, 28 Oct 2019 09:22:01 +0000 (10:22 +0100)]
l2: l2tp API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I9015fc60e8d77e5d5ac36bf2862c1fe794addb81
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agolb: refactor ntohl in lb_conf handler 82/22182/5
Vratko Polak [Fri, 20 Sep 2019 16:56:49 +0000 (18:56 +0200)]
lb: refactor ntohl in lb_conf handler

Type: refactor

Change-Id: Ibe8f3c1ed5c04d1800fea9b9a90772816aa38d65
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
4 years agotests: decode worker stdout/stderr output 71/23071/1
Dave Wallace [Tue, 29 Oct 2019 23:12:03 +0000 (19:12 -0400)]
tests: decode worker stdout/stderr output

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I309254e9e99920fbeaa50eea503c1c2a9470abfe

4 years agovcl: handle rx notifications on reused sessions 43/23043/3
Florin Coras [Mon, 28 Oct 2019 20:22:37 +0000 (13:22 -0700)]
vcl: handle rx notifications on reused sessions

Type: fix

Ignore events on sessions that have been reused but not fully
initialized.

Change-Id: Ided020eb5245d665d0a2e4a9e1f8a6dddebae009
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agodpdk: replace deprecated VFIO API invocation 82/22982/2
Damjan Marion [Fri, 25 Oct 2019 12:55:53 +0000 (14:55 +0200)]
dpdk: replace deprecated VFIO API invocation

Type: refactor

Change-Id: I1712729b3f5d4ab659f51a2d3bf798db16b50820
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 years agoip: refactor ip4_mtrie to use atomic store-release 59/22359/4
jaszha03 [Fri, 27 Sep 2019 17:52:18 +0000 (12:52 -0500)]
ip: refactor ip4_mtrie to use atomic store-release

ip4_mtrie used full memory barrier compare-and-swap in set_leaf () and
set_root_leaf () even though only one thread updates the trie. Replaced
such instances of compare-and-swap with atomic store-release.

Type: refactor

Change-Id: Ic6e3c84480697915541acd16dcc630d1c436137d
Signed-off-by: Jason Zhang <jason.zhang2@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
4 years agoip: refactor ip4_mtrie to atomically unset leaves 66/22366/3
jaszha03 [Fri, 27 Sep 2019 20:42:02 +0000 (15:42 -0500)]
ip: refactor ip4_mtrie to atomically unset leaves

ip4_mtrie set leaves atomically in set_leaf () and set_root_leaf () but
deleted leaves using regular stores in unset_leaf () and unset_root_leaf ().
Changed leaf deletion to update mtrie using atomic store-release.

Slight performance improvement was observed in benchmarking on Qualcomm
and Xeon machines. Benchmarking involved running 'ip route add' and
'ip route del' on vpp instances. Below are the routes/second for adding
and deleting 100k routes before and after the store-release changes:

Xeon Add Routes Before: 1.140e6, 1.139e6, 1.148e6, 1.158e6, 1.155e6
Xeon Add Routes After: 1.167e6, 1.170e6, 1.174e6, 1.173e6, 1.169e6
Xeon Del Routes Before: 7.287e7, 8.089e7, 6.048e7, 7.171e7, 7.821e7
Xeon Del Routes After: 8.729e7, 7.353e7, 7.856e7, 8.209e7, 7.787e7
Qualcomm Add Routes Before: 3.709e5, 3.954e5, 3.739e5, 3.759e5, 3.671e5
Qualcomm Add Routes After: 3.879e5, 3.967e5, 3.936e5, 3.764e5, 3.817e5
Qualcomm Del Routes Before: 1.286e7, 1.379e7, 1.353e7, 1.230e7, 1.331e7
Qualcomm Del Routes After: 1.411e7, 1.355e7, 1.373e7, 1.394e7, 1.314e7

Type: refactor

Change-Id: If3acd25a2fb87addd0eb13d82d3c8f46579e8060
Signed-off-by: Jason Zhang <jason.zhang2@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
4 years agodocs: Fix warning with sphinx build, add script to publish docs 61/23061/1
John DeNisco [Tue, 29 Oct 2019 14:40:09 +0000 (10:40 -0400)]
docs: Fix warning with sphinx build, add script to publish docs

Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: Ic17585bcb4196e5b0661104745f67d6a02ab6b3d

4 years agotests: fix TEST= filtering for python3 59/23059/2
Klement Sekera [Tue, 29 Oct 2019 11:03:47 +0000 (11:03 +0000)]
tests: fix TEST= filtering for python3

Type: fix

Change-Id: Iceb60e8a507120434cfc68758476ff5351b05f58
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoethernet: VNET API to create sub-interfaces 36/23036/2
Neale Ranns [Mon, 28 Oct 2019 14:56:15 +0000 (07:56 -0700)]
ethernet: VNET API to create sub-interfaces

Type: refactor

Change-Id: I37899a9c1c2b0790bee90b84aec6b51cdd5236b4
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agomisc: 19.04.3 Release Notes 46/23046/2
Dave Wallace [Tue, 29 Oct 2019 02:43:28 +0000 (22:43 -0400)]
misc: 19.04.3 Release Notes

Type: docs

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I43a236be5289c50dafbede08beabe4c09ff3c892

4 years agotcp: correct tcp connection lookup condition 17/23017/3
Ryujiro Shibuya [Mon, 28 Oct 2019 00:32:12 +0000 (00:32 +0000)]
tcp: correct tcp connection lookup condition

Type: fix

Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: Ibdbac568d5f765e6b5c959cab5e32dc33335064d

4 years agosession: allow transport cleanup only if not deleted 37/23037/2
Florin Coras [Mon, 28 Oct 2019 15:46:37 +0000 (08:46 -0700)]
session: allow transport cleanup only if not deleted

Type: fix

Change-Id: I51282182952a66be698226bace39626df4d67b9f
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agoip: Punt rather than drop unkown IPv6 ICMP packets 91/22991/2
Neale Ranns [Fri, 25 Oct 2019 14:20:42 +0000 (07:20 -0700)]
ip: Punt rather than drop unkown IPv6 ICMP packets

Type: feature

Change-Id: Ib137c453ff2dd5b9d028c653afa80e6b2b81b9e0
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoping: move the echo responder into the ping plugin 80/22980/2
Neale Ranns [Fri, 25 Oct 2019 08:40:47 +0000 (01:40 -0700)]
ping: move the echo responder into the ping plugin

Type: feature

Change-Id: I246346b82858e73b16d727e2106350bc0fc3c6f2
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agovlib: don't use vector for keeping buffer indices in the pool 42/18242/10
Damjan Marion [Tue, 12 Mar 2019 17:14:15 +0000 (18:14 +0100)]
vlib: don't use vector for keeping buffer indices in the pool

Type: refactor

Change-Id: I72221b97d7e0bf5c93e20bbda4473ca67bfcdeb4
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 years agoip: reassembly fix sanity checks 28/23028/4
Klement Sekera [Mon, 28 Oct 2019 11:26:28 +0000 (11:26 +0000)]
ip: reassembly fix sanity checks

use correct value for sanity checks

Type: fix

Change-Id: If33db5ce3e4a26f7876c2a67832ca2947563e211
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agodocs: cleanup typos on readthrough 15/23015/2
Paul Vinciguerra [Sun, 27 Oct 2019 21:28:10 +0000 (17:28 -0400)]
docs: cleanup typos on readthrough

Type: style

Change-Id: I3b15035ea6c13cd1ca3cdc9dfa9b10a6e1be9880
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agosession: app-closed to transport-deleted on delete notify 01/23001/4
Florin Coras [Fri, 25 Oct 2019 23:23:39 +0000 (16:23 -0700)]
session: app-closed to transport-deleted on delete notify

Type: refactor

As a result, transport-deleted is the only session state that has no
transport data structure.

Change-Id: I2da2bc4bbb141d8a7b52faae66a4733de8f8513b
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agonat: respect udp checksum 21/22921/4
Filip Varga [Mon, 21 Oct 2019 16:18:00 +0000 (18:18 +0200)]
nat: respect udp checksum

Type: fix

Change-Id: I73895fa0101bd50483160c8dc6faac2c67513077
Signed-off-by: Filip Varga <fivarga@cisco.com>
4 years agotests: switch test framework to python3 by default 47/22947/8
Ole Troan [Wed, 23 Oct 2019 09:47:33 +0000 (11:47 +0200)]
tests: switch test framework to python3 by default

Type: make
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I84d32f022d9dc555837c8916feba04a224cd262a

4 years agotests: make RA tests run on VPP time 95/22695/4
Andrew Yourtchenko [Sun, 13 Oct 2019 18:56:03 +0000 (18:56 +0000)]
tests: make RA tests run on VPP time

the IPv6 RA tests take timing into the account,
but the time inside VPP may go slightly differently compared
to the time inside the driving python thread,
if the machine running the tests is heavily loaded.
Make a sleep function which sleeps "on VPP time" and use it.

Change-Id: I3b34b0164f6e0ec7a619b92ee308089a4a8935e3
Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agovlib: unix trivial- clean up typos in docs 13/23013/2
Paul Vinciguerra [Sun, 27 Oct 2019 18:00:53 +0000 (14:00 -0400)]
vlib: unix trivial- clean up typos in docs

seen while reading through the code.

Type: style

Change-Id: I7a2f021b9f06d0eebb2ea3d0cafb6955ccb14781
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoip: fix tracing of packet flags 48/22948/2
Klement Sekera [Wed, 23 Oct 2019 10:16:02 +0000 (10:16 +0000)]
ip: fix tracing of packet flags

This fixes incorrect tracing of flags such as MORE_FRAGMENTS.

Type: fix

Change-Id: Ia5698418a7cbb45c18bc9c95f560cea020e63c39
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoip: reassembly: fix use-after-free 53/22953/2
Benoît Ganne [Wed, 23 Oct 2019 11:53:49 +0000 (13:53 +0200)]
ip: reassembly: fix use-after-free

When processing the last buffer of a reassembled packet, the current
buffer will be freed and must be reloaded using the updated index.

Type: fix

Change-Id: Ib39e29e60eb527b4cd4828a3aa37d82c8dddd709
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovapi: switch to python3 96/22996/2
Ole Troan [Fri, 25 Oct 2019 16:30:40 +0000 (18:30 +0200)]
vapi: switch to python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I78aac39b697e29bb454e5e95855e79ea3122b4c3

4 years agol2: l2bd nd termination test instability 92/22992/3
Ole Troan [Fri, 25 Oct 2019 15:03:54 +0000 (17:03 +0200)]
l2: l2bd nd termination test instability

The test for ND event suppression reused the previous test run
ipv6 address, and would sometimes consider that a duplicate,
and therefore suppressing that one too.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1b115aa4eba9d57770fa03fcf38b7a1c251cfe88

4 years agodhcp: fix crash on unicast renewal send 38/22738/7
Neale Ranns [Tue, 15 Oct 2019 15:47:55 +0000 (15:47 +0000)]
dhcp: fix crash on unicast renewal send

Type: fix

- when the addresses were learnt a copy of the client was sent to the
main thread, this meant the unicast adjacecny was saved on the copy
not on the original.
- Add logging.
- Improve the proxy-node that hands the clint packets so the DHCP
packets are traced.
 - allow a renewal to configure new address data

Change-Id: I6ab0afcccbc4a1cdefdd1b8beeda8fc7ba20ec1f
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agomdata: buffer metadata change tracker plugin 79/22979/3
Dave Barach [Thu, 24 Oct 2019 22:10:10 +0000 (18:10 -0400)]
mdata: buffer metadata change tracker plugin

A handy tool in case you need to know which metadata will be changed
when a packet visits a certain node.

Reflect metadata changes into format functions used by the
vpp-specific wireshark dissector.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I96fe8a24db4082bb29fe2a33cc522e8616a3a1bb

4 years agogso: fix buffers trace 56/22956/2
Benoît Ganne [Wed, 23 Oct 2019 13:47:22 +0000 (15:47 +0200)]
gso: fix buffers trace

When segmenting, new buffers must inherit the original buffer trace
handle.

Type: fix

Change-Id: Ibd1859a501b2862906dfc563b98652cfee5681da
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agolacp: add actor steady state check prior to skip processing lacp pdu 41/22941/3
Steven Luong [Wed, 23 Oct 2019 04:27:22 +0000 (21:27 -0700)]
lacp: add actor steady state check prior to skip processing lacp pdu

In a rare event, we may be skipping processing lacp pdu's when the it is
not in steady state.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I3595d22dbff8a97dce9fb4d4452d2051bcf6f523

4 years agodevices: vhoost cpu->copy array overflow on tcp jumbo frame (65535 bytes) 65/22965/1
Steven Luong [Wed, 23 Oct 2019 20:28:37 +0000 (13:28 -0700)]
devices: vhoost cpu->copy array overflow on tcp jumbo frame (65535 bytes)

We reserve 40 slots in cpu->copy array prior to copy out to avoid overflowing
the array. However, 40 is not enough for the jumbo frame because desceiptor
buffer len is likely at 1536. Change the reserve to 200 and add ASSERT to avoid
encountering the same problem in the future.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ibf0c03c4b4f33e781d5be8679ccd6c3a4b4a646d

4 years agomemif: memif buffer leaks during disconnecting zero copy interface. 29/22829/5
Changqian Wang [Fri, 18 Oct 2019 09:13:13 +0000 (17:13 +0800)]
memif: memif buffer leaks during disconnecting zero copy interface.
code added to free the zero copy interface rx/tx queue buffers during disconnecting.
As ddc9eb4 find the last official solution introduced core in ut. This does not.

Type: fix

Signed-off-by: Changqian Wang <changqwa@cisco.com>
Change-Id: I971ee164e6d4331a85feb9e65d6702d771c86985

4 years agocdp: re-enable skipped tests for python3 46/22946/2
Ole Troan [Wed, 23 Oct 2019 09:24:23 +0000 (11:24 +0200)]
cdp: re-enable skipped tests for python3

CDP uses the running sytems host name, which
caused different failures on different systems.
The root cause was an python3 specific error in
checksum calculation.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I205436682d46e7e8cbb8c057c03a76dbbcab4d72

4 years agoavf: improve timeout handling 31/21831/3
Jakub Grajciar [Mon, 2 Sep 2019 11:28:52 +0000 (13:28 +0200)]
avf: improve timeout handling

Type: feature

Change-Id: I8fa1d691ef7bc51ae5c44c344195207ce7d0a2e7
Signed-off-by: Damjan Marion <damarion@cisco.com>
4 years agosr: add "set sr encaps hop-limit" command 12/22512/9
Ignas Bačius [Thu, 3 Oct 2019 14:15:38 +0000 (17:15 +0300)]
sr: add "set sr encaps hop-limit" command

Default hop-limit for the encapsulating IPv6 header is a compile-time
constant. Add ability to specify custom hop-limit, in order to avoid
packets being dropped with "hop limit exceeded in transit" response in
certain network configurations.

Type: feature
Signed-off-by: Ignas Bačius <ignas@noia.network>
Change-Id: I77f2b35c987cfd31801dc2744d31fb3c1984158f

4 years agogtpu: msg id fix in send_gtpu_tunnel_details api 04/22904/2
Miklos Tirpak [Tue, 22 Oct 2019 09:01:42 +0000 (11:01 +0200)]
gtpu: msg id fix in send_gtpu_tunnel_details api

Type: fix

_vl_msg_id must start at msg_id_base.

Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: Id3f05683c873fcac47667a9736e45e85849b740c

4 years agopapi: fix default handling 27/22927/3
Ole Troan [Tue, 22 Oct 2019 12:01:53 +0000 (14:01 +0200)]
papi: fix default handling

The BaseTypers object were reused, so a default for anyother mesage
would be inherited in new messages.

Type: fix
Fixes: 85465588b18fef9c4712f864f512e00741e2d4f2
Change-Id: Ie1efb85a76b088653eb9ea4b88540c98b6b0aad0
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agotcp: improve rate samples for retansmitted segments 90/22690/18
Florin Coras [Sun, 13 Oct 2019 01:10:20 +0000 (18:10 -0700)]
tcp: improve rate samples for retansmitted segments

Type: fix

- Initialize max_seq on both transmitted and retransmitted segments
- Keep track of segments that have been sacked.
- Track new data segments sent during recovery

Change-Id: Ice55231a3da200ae6171702e54b2ce155f831143
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotcp: fix sack retransmit beyond snd_nxt 40/22940/2
Florin Coras [Wed, 23 Oct 2019 02:44:45 +0000 (19:44 -0700)]
tcp: fix sack retransmit beyond snd_nxt

Type: fix

Ensure that sack retransmit logic does not try to inadvertently send new
data.

Change-Id: Idfda19643577d9c1b58e2af8d8283cabfbaf98e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agordma: build: fix ibverb compilation test 35/22935/2
Benoît Ganne [Tue, 22 Oct 2019 14:55:19 +0000 (16:55 +0200)]
rdma: build: fix ibverb compilation test

Type: fix

Change-Id: Ib6389ecbcf4a1b7bae25b2bd9e7fbdec49545aaa
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovppinfra: make coverity happy with vec_set_len 36/22936/2
Benoît Ganne [Tue, 22 Oct 2019 16:19:00 +0000 (18:19 +0200)]
vppinfra: make coverity happy with vec_set_len

Coverity gets confused by ASSERT((l) <= vec_max_len(v)) when l is 0.

Type: fix

Change-Id: I247d7015b148233d8f195bcf41e9a047b7a21309
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agotests: quic add big stream extended tests 94/22894/3
Dave Wallace [Mon, 21 Oct 2019 22:45:23 +0000 (22:45 +0000)]
tests: quic add big stream extended tests

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I6c5bdfd934a2c96c410c36c2bc090ee47b679bea

4 years agotests: test tls case 89/22689/4
haiyanx1.zhang [Sat, 12 Oct 2019 08:44:44 +0000 (08:44 +0000)]
tests: test tls case

Type: feature

Signed-off-by: haiyanx1.zhang <haiyanx1.zhang@intel.com>
Change-Id: I071f5face0d489dc967cce1edcffbc1f8fac5c7e
Signed-off-by: haiyanx1.zhang <haiyanx1.zhang@intel.com>
4 years agovcl: handle segment map errors 74/22274/5
Florin Coras [Wed, 25 Sep 2019 23:37:43 +0000 (16:37 -0700)]
vcl: handle segment map errors

Type: fix

Change-Id: Ibd122a4565c067627c4bbc8cac7df2d5b6497392
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agovcl: add config option for preferred tls engine 65/22865/4
Florin Coras [Mon, 21 Oct 2019 02:55:56 +0000 (19:55 -0700)]
vcl: add config option for preferred tls engine

Type: feature

Change-Id: If6c095c9b737cb524a9232dcfa9be0f93f04d114
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotests: enable vpp_echo to run in gdb 66/22866/3
Dave Wallace [Mon, 21 Oct 2019 03:28:17 +0000 (03:28 +0000)]
tests: enable vpp_echo to run in gdb

- Enable vpp_echo to be run in gdb when
  running 'make test DEBUG=gdb-all'

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I79a69b0573c01900535078d7493d52b417350815

4 years agotests: DEBUG=gdb[server]-all to debug worker(s) 64/22864/3
Dave Wallace [Mon, 21 Oct 2019 02:53:14 +0000 (02:53 +0000)]
tests: DEBUG=gdb[server]-all to debug worker(s)

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I0264451632c1ce780b38a2c15a7e34350fc6d521

4 years agovppinfra: add clib_mem_free_s 34/21934/6
Benoît Ganne [Mon, 29 Apr 2019 15:27:24 +0000 (17:27 +0200)]
vppinfra: add clib_mem_free_s

IPsec zero-es all allocated key memory including memory sur-allocated by
the allocator.
Move it to its own function in clib mem infra to make it easier to
instrument.

Type: refactor

Change-Id: Icd1c44d18b741e723864abce75ac93e2eff74b61
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoikev2: fix GCM cipher 30/22930/2
Filip Tehlar [Fri, 18 Oct 2019 17:51:06 +0000 (17:51 +0000)]
ikev2: fix GCM cipher

Type: fix

Change-Id: I382499061ff4b1c2cc1b70ebbf9725ff0e1be325
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
4 years agoip: reassembly: avoid corruption in vnet buffer 29/22929/2
Klement Sekera [Tue, 22 Oct 2019 12:16:07 +0000 (12:16 +0000)]
ip: reassembly: avoid corruption in vnet buffer

Avoid corrupt next_index in vnet_buffer by moving input and output
variables into different memory places instead of sharing a common
space.

Type: fix
Fixes: de34c35fc73226943538149fae9dbc5cfbdc6e75

Change-Id: I34471fc6d0c8487535fac21349e688f398934f6d
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agogbp: missing contract hash-mode setting 28/22928/2
Neale Ranns [Tue, 22 Oct 2019 12:32:49 +0000 (12:32 +0000)]
gbp: missing contract hash-mode setting

Type: fix

Change-Id: Ia0f1e88b43e861d3f6965076c73cc48fb9574da3
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoipsec: fix tunnel protection removal 12/22912/1
Filip Tehlar [Fri, 18 Oct 2019 22:24:41 +0000 (22:24 +0000)]
ipsec: fix tunnel protection removal

Type: fix

Change-Id: I4d5546d1f9b3a162291997f6f0c094c5c3d6cf31
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
4 years agoip: ipfix-export API update 46/22646/4
Jakub Grajciar [Thu, 10 Oct 2019 12:21:22 +0000 (14:21 +0200)]
ip: ipfix-export API update

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I5b03e5de111c3a3b8da4e9f02cba0aa99e3ee9f3

4 years agocdp: disable failing tests for python3 98/22898/2
Ole Troan [Tue, 22 Oct 2019 06:57:31 +0000 (08:57 +0200)]
cdp: disable failing tests for python3

scapy in python3 does not seem to allow creating invalid protocol
packets. Suggest the maintainer rewrite the invalid tests so they
also work for python3. In the mean time they are disabled.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I554d57528422c98c6df4ba76eeae38c03f512a38

4 years agobuild: add missing ldflags to exe and shared 36/21936/6
Benoît Ganne [Tue, 11 Jun 2019 14:56:41 +0000 (16:56 +0200)]
build: add missing ldflags to exe and shared

Type: fix

Change-Id: I859bc6ebc574ab09fd70b45f8c911769d00e7acf
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovppinfra: add vec_set_len() 35/21935/6
Benoît Ganne [Mon, 22 Jul 2019 12:21:46 +0000 (14:21 +0200)]
vppinfra: add vec_set_len()

l2-flood and bier nodes reset vector length without updating it to its
effective size. Introduce a helper to do it (this allows ASAN to keep
track of the new vector size).

Type: refactor

Change-Id: I2d652550c440f0553a2b49c3ee3d37b49ebc16c3
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agotests: python3 changes for dns tests 84/22684/4
snaramre [Fri, 11 Oct 2019 19:04:19 +0000 (19:04 +0000)]
tests: python3 changes for dns tests

Type: fix
Change-Id: Ia81c60d469b29606d9988d7d9ed1e133e6af7158
Signed-off-by: snaramre <snaramre@cisco.com>
4 years agoflowprobe: tests support python3 93/22893/3
Ole Troan [Mon, 21 Oct 2019 21:13:46 +0000 (23:13 +0200)]
flowprobe: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I7425147e864467e4f94cee2a82ef74a894339471

4 years agotls: enable tls engine as the default engine 69/22869/2
Yu Ping [Mon, 21 Oct 2019 15:23:44 +0000 (23:23 +0800)]
tls: enable tls engine as the default engine

OpenSSL TLS is well maintained and many issues are fixed, and it makes
OpenSSL as the default engine will be more friendly to users if app does
not configure a specific engine such as http_static

Type: fix

Change-Id: I37499af1edd40ffb53b00436044d1fce3b43348d
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agogeneve: tests support python3 90/22890/3
Ole Troan [Mon, 21 Oct 2019 19:03:39 +0000 (21:03 +0200)]
geneve: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I0ff4d58c181b2bdf483b8b039ad005c2a4915aa8

4 years agobonding: tests support python3 88/22888/2
Ole Troan [Mon, 21 Oct 2019 18:41:44 +0000 (20:41 +0200)]
bonding: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I6cedb43af4437fdabce75f4a845629c5c2f96f6a

4 years agoip: test support python3 91/22891/2
Ole Troan [Mon, 21 Oct 2019 19:06:52 +0000 (21:06 +0200)]
ip: test support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I9c66bce900f78e5fbd435515df94e327ad25c3c6

4 years agol2: tests support python3 86/22886/2
Ole Troan [Mon, 21 Oct 2019 18:37:30 +0000 (20:37 +0200)]
l2: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id17bcb65d7eb27f865fc7872b3e485c09f1d29a7

4 years agoacl: l2 classify test support python3 87/22887/2
Ole Troan [Mon, 21 Oct 2019 18:39:45 +0000 (20:39 +0200)]
acl: l2 classify test support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3b2e57e3dcf04ae50724b5909272b083d6003a85

4 years agoipsec: tests support python3 89/22889/1
Ole Troan [Mon, 21 Oct 2019 18:55:13 +0000 (20:55 +0200)]
ipsec: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id13da9371c71c10c12a0120ec89ba21c1ca47524

4 years agoclassify: tests to support python3 85/22885/2
Ole Troan [Mon, 21 Oct 2019 17:52:06 +0000 (19:52 +0200)]
classify: tests to support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8af6ee6e5239f0836978baa063a18a01c610279f

4 years agobier: tests support python3 84/22884/2
Ole Troan [Mon, 21 Oct 2019 16:59:11 +0000 (18:59 +0200)]
bier: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3cf5295f1a85579a66ba38ca1f74678b45474959

4 years agoquic: Add PICOTLS_INCLUDE_DIR var to CMakeLists. 86/21086/2
Mathias Raoul [Tue, 6 Aug 2019 12:58:01 +0000 (14:58 +0200)]
quic: Add PICOTLS_INCLUDE_DIR var to CMakeLists.

Type: fix

Change-Id: I10ebcc653491d11ca798e0a60be6eeef82c41766
Signed-off-by: Mathias Raoul <mathias.raoul@gmail.com>
4 years agotests: add PID of VPP under test to API dump filename for the test 76/22876/1
Andrew Yourtchenko [Mon, 21 Oct 2019 12:55:48 +0000 (12:55 +0000)]
tests: add PID of VPP under test to API dump filename for the test

Some testclasses (e.g. IPSec) have methods with the same names,
this causes a race when running in parallel to save the API and
move it into the test's directory - the name of the file has
only the test method name as a discriminator.

Saving two traces from two VPP instances "succeeds", in that
it silently overwrites the file. But only one mv operation
works - the other gives an error "file not found" and fails the test.

Solution: add the PID of VPP under test to the API dump filename,
this way the filenames become guaranteed unique and the race is avoided.

Change-Id: I1bb47ed73369fea0f1bfbf907588a51e2cabfb7f
Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agoip: reassembly tests python3 support 37/22837/4
Ole Troan [Fri, 18 Oct 2019 13:22:56 +0000 (15:22 +0200)]
ip: reassembly tests python3 support

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I990d8d521c128e8d4f482e30b3a49cbc11b632d1

4 years agosession: support registration of custom crypto engines 63/22863/4
Florin Coras [Mon, 21 Oct 2019 02:32:47 +0000 (19:32 -0700)]
session: support registration of custom crypto engines

Type: feature

Change-Id: I888d415ff645b3827df7d4cfb0d3c5f4ac940617
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agovcl: add api to set lcl ip 14/22814/3
Florin Coras [Thu, 17 Oct 2019 16:56:27 +0000 (09:56 -0700)]
vcl: add api to set lcl ip

Type: feature

Change-Id: I40169fbbe8a20670dd612c341b6c78b5c925bf74
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agodhcp: python3 support in tests 34/22834/4
Ole Troan [Fri, 18 Oct 2019 12:33:54 +0000 (14:33 +0200)]
dhcp: python3 support in tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie136c1e94e5c25f9547fc2d6d45ce8e1630a035c

4 years agovlib: linux: fix wrong iommu_group value issue when using dpdk-plugin 05/22805/4
Yulong Pei [Thu, 17 Oct 2019 10:41:52 +0000 (18:41 +0800)]
vlib: linux: fix wrong iommu_group value issue when using dpdk-plugin

When VPP work with dpdk-plugin, linux_vfio_main_t->container_fd is always -1
since it never have chance to run open("/dev/vfio/vfio") to get the fd.

But this lead to a potential issue of VPP, that is, when start VPP without
uio-driver field setup in /etc/vpp/startup.conf, VPP will run to automatical
select uio driver in vlib_pci_bind_to_uio() and the function depend on
iommu_group value to decide to work on vfio or vfio-noiommu mode.

Since in vlib_pci_get_device_info() have the condition container_fd != -1,
so the iommu_group value will be always -1 at this scenario, this caused
that VPP mistake to run with vfio-noiommu driver on intel_iommu=on state.

Actually in order to get iommu_group and iommu_group/name value, no need to
depend on linux_vfio_main_t->container_fd value, so the fix remove the
condition lvm->container_fd != -1, then it can get the correct iommu_group
value.

Type: fix

Change-Id: I3f162fc4971b9a2b8717205f8f3b52e30c5e5b69
Signed-off-by: Yulong Pei <yulong.pei@intel.com>
4 years agovlib: enable worker-thread dispatch pcap trace 57/22857/1
Dave Barach [Fri, 18 Oct 2019 18:44:05 +0000 (14:44 -0400)]
vlib: enable worker-thread dispatch pcap trace

Needed a bit of foreach_vlib_main(...) action to turn on/off all
instances of vm->dispatch_pcap_enable, and to pick up the pcap_main_t
pointer from vlib_global_main.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I49b69b87934c7dc7a9835cd07aa2c5c4d3c79f18

4 years agomactime: fix handle_get_mactime fcn prototype 54/22854/1
Dave Barach [Fri, 18 Oct 2019 15:31:20 +0000 (11:31 -0400)]
mactime: fix handle_get_mactime fcn prototype

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9576ade941b10d1605f6c6714f312ae2a8ad5065

4 years agoip: add python3 support to punt tests 41/22841/2
Ole Troan [Fri, 18 Oct 2019 13:57:56 +0000 (15:57 +0200)]
ip: add python3 support to punt tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib918d11fb3278a25a92006dcfe3c7c484e7b33ea

4 years agomap: python3 support in tests 40/22840/2
Ole Troan [Fri, 18 Oct 2019 13:41:43 +0000 (15:41 +0200)]
map: python3 support in tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icbe9ca3dc738c6575fe382740a1cc9d29a4a74ff

4 years agogso: python3 support in tests 38/22838/2
Ole Troan [Fri, 18 Oct 2019 13:26:25 +0000 (15:26 +0200)]
gso: python3 support in tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I166019cc69fd01cb43f1a3fad699f3d2e5ec5b19

4 years agoip: ip vrf tests python3 support 36/22836/2
Ole Troan [Fri, 18 Oct 2019 12:54:30 +0000 (14:54 +0200)]
ip: ip vrf tests python3 support

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie23c9d2d7325be62ef33df2f0562ab41518f7bf4

4 years agoudp:: support python3 in tests 35/22835/1
Ole Troan [Fri, 18 Oct 2019 12:40:54 +0000 (14:40 +0200)]
udp:: support python3 in tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iea19d7bc2dfe9736ddefb4419509ccfda7a67eeb

4 years agomemif: add python3 support to test 26/22826/3
Ole Troan [Fri, 18 Oct 2019 01:39:26 +0000 (03:39 +0200)]
memif: add python3 support to test

Committed from SK936 seat 1A.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I717fafbdb9b8576508d6dd72a7e5653cecebfae0
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agoip: trivial typos in docs 25/22825/2
Paul Vinciguerra [Fri, 18 Oct 2019 01:08:17 +0000 (21:08 -0400)]
ip: trivial typos in docs

Type: style

Change-Id: I620f15b96ee5401e0145a139f06d343d7c4fadb4
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoipsec: make tests support python3 20/22820/2
Ole Troan [Thu, 17 Oct 2019 19:40:36 +0000 (21:40 +0200)]
ipsec: make tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3255702e7c562c8d04a91a095e245756c6443a9e

4 years agotests: python3 changes for span and aclplugin test 97/22797/3
snaramre [Wed, 16 Oct 2019 22:15:43 +0000 (22:15 +0000)]
tests: python3 changes for span and aclplugin test

Type: fix
Change-Id: Ia9f74f951f831cc5c9b5af863db1bb3f7a1a81ff
Signed-off-by: snaramre <snaramre@cisco.com>
4 years agosession: unify buffer tx dispatching 04/22804/4
Florin Coras [Thu, 17 Oct 2019 05:35:18 +0000 (22:35 -0700)]
session: unify buffer tx dispatching

Type: refactor

Use pending tx buffer vector to postpone dispatching of all buffers,
i.e., either generated as a result of tx events or custom tx event.

Change-Id: Ic5894c4653c338cfb04555d20857f954b245ee83
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agohttp_static: pass http request type to builtin handlers 21/22821/2
Dave Barach [Thu, 17 Oct 2019 19:53:08 +0000 (15:53 -0400)]
http_static: pass http request type to builtin handlers

Makes it easy to tell GETs from POSTs, etc., in case one wants to
register the same handler for multiple request types.

Return interface stats as a json array, makes .js code a lot simpler.

Type: refactor

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Iadae7b909cf3e8ea179fe93620737fdf68f888ac

4 years agoclassify: make tests support python3 16/22816/2
Ole Troan [Thu, 17 Oct 2019 18:44:25 +0000 (20:44 +0200)]
classify: make tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I7c4a12165fa0928fb2b8d99fc1c8d5de16377e7e

4 years agosession tcp: infra for transports to send buffers 03/22803/6
Florin Coras [Thu, 17 Oct 2019 05:06:08 +0000 (22:06 -0700)]
session tcp: infra for transports to send buffers

Type: feature

Add infra that allows transpors to enqueue pending buffers without the
need to build and manage their own pending frames. An important benefit
is the fact that buffer wire/tx ordering is ensured by session layer.

Change-Id: I764fd1693d610b321a1d0c84b648a314f14583db
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotests: python3 fixes for reassembly tests 13/22813/3
snaramre [Thu, 17 Oct 2019 16:39:03 +0000 (16:39 +0000)]
tests: python3 fixes for reassembly tests

Type: fix
Change-Id: I0d9b823bd558c48b18af9b0d1e80c30729e64dac
Signed-off-by: snaramre <snaramre@cisco.com>
4 years agotcp: avoid sending acks when data available 02/22802/5
Florin Coras [Thu, 17 Oct 2019 02:28:17 +0000 (19:28 -0700)]
tcp: avoid sending acks when data available

Type: fix

Change-Id: I02e2cb2d349f9ddb2bfed040a08ca448f379d565
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotests: python3 changes for load balancer test 98/22798/3
snaramre [Wed, 16 Oct 2019 22:36:47 +0000 (22:36 +0000)]
tests: python3 changes for load balancer test

Type: fix
Change-Id: Id9a328158e7c4106a95928bf8ddceb7b9e73aa25
Signed-off-by: snaramre <snaramre@cisco.com>
4 years agonat: tests support python3 00/22800/2
Ole Troan [Wed, 16 Oct 2019 23:31:12 +0000 (01:31 +0200)]
nat: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie15ea8f01846f87cb65e90e8762dc941441fc176

4 years agovppinfra: test support python3 01/22801/2
Ole Troan [Wed, 16 Oct 2019 23:53:47 +0000 (01:53 +0200)]
vppinfra: test support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id1794f38fcb776ded9b769141f5f47d7be75f247

4 years agotcp: Init cwnd from ssthresh. 07/22807/4
Sergey Ivanushkin [Thu, 17 Oct 2019 09:16:27 +0000 (10:16 +0100)]
tcp: Init cwnd from ssthresh.

Set high ssthresh out of the box and make configurable

Type: fix

Signed-off-by: Sergey Ivanushkin <sergey.ivanushkin@enea.com>
Change-Id: Iba1549b4ee55e51468ad0b28ef3d26a85fa9cae0

4 years agohttp_static: add "http static cache clear" CLI 55/22755/2
Dave Barach [Tue, 15 Oct 2019 18:52:53 +0000 (14:52 -0400)]
http_static: add "http static cache clear" CLI

Useful to force content reloads

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ieecb018bec61a1624574660842d7d92cd84520f9

4 years agoip: punt API cleanup 25/22625/3
Jakub Grajciar [Wed, 9 Oct 2019 12:15:56 +0000 (14:15 +0200)]
ip: punt API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I7048f8ec598a8b06d75bdfb5d2fab9f6337c9474
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agoip: rd_cp API cleanup 45/22645/2
Jakub Grajciar [Thu, 10 Oct 2019 11:33:43 +0000 (13:33 +0200)]
ip: rd_cp API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I1cc42b57fbf72e2ced8b5d1283c34de2f7ff948a

4 years agomisc: Update gitignore for /test/ext/.d 74/22774/2
Neale Ranns [Wed, 16 Oct 2019 15:15:23 +0000 (08:15 -0700)]
misc: Update gitignore for /test/ext/.d

.. otherwise i'm going to commit it accidentally

Type: feature

Change-Id: I0378b9a29a28ea7317bc7d234f8cbacdafd6b762
Signed-off-by: Neale Ranns <nranns@cisco.com>