vpp.git
4 years agovirtio: split gso and checksum offload functionality 71/23971/14
Mohsin Kazmi [Fri, 3 Jan 2020 15:11:53 +0000 (15:11 +0000)]
virtio: split gso and checksum offload functionality

Type: refactor

Change-Id: I897e36bd5db593b417c2bac9f739bc51cf45bc08
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agotls: improve connection formating 31/24231/2
Florin Coras [Tue, 7 Jan 2020 19:01:26 +0000 (19:01 +0000)]
tls: improve connection formating

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iea8abe33cf33036267ccaf58760abc2f48470202

4 years agotcp: fix last sacked with no holes 33/24233/4
Florin Coras [Wed, 8 Jan 2020 00:33:02 +0000 (00:33 +0000)]
tcp: fix last sacked with no holes

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id12b0a9b8bc47aef8b393544e5b4c8228ed6a606

4 years agovppinfra: retry socket connect on EAGAIN 01/24201/5
Florin Coras [Mon, 6 Jan 2020 20:23:07 +0000 (20:23 +0000)]
vppinfra: retry socket connect on EAGAIN

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I93577acf559a8fa639aab7ec3f7cdbe7df9a248d

4 years agosvm: fix eventfd signal write error check 34/24234/2
Florin Coras [Wed, 8 Jan 2020 02:37:57 +0000 (02:37 +0000)]
svm: fix eventfd signal write error check

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I706c8642ca0877430a42cc0ca5bc61a45428fc98

4 years agol2: fix MAC learn counter update on adding MAC entry 32/24232/2
John Lo [Tue, 7 Jan 2020 21:35:29 +0000 (16:35 -0500)]
l2: fix MAC learn counter update on adding MAC entry

Type: fix

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I711432f589ee4a4527cf795526d3b4031999f71d

4 years agoacl: add FEATURE.yaml 35/24235/3
Andrew Yourtchenko [Wed, 8 Jan 2020 05:22:20 +0000 (05:22 +0000)]
acl: add FEATURE.yaml

Change-Id: If6f13e7962c27f35528058224928def927fff19f
Type: docs
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agordma: add FEATURE.yaml 21/24221/3
Benoît Ganne [Tue, 7 Jan 2020 13:53:09 +0000 (14:53 +0100)]
rdma: add FEATURE.yaml

Type: docs

Change-Id: I91d701814e4bd9953616d2b7c76ae2ea7c07074b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovlib: fix coverity warning / real bug 29/24229/1
Dave Barach [Tue, 7 Jan 2020 17:29:10 +0000 (12:29 -0500)]
vlib: fix coverity warning / real bug

The path must be next-to-impossible to hit, because the code has been
wrong for at least 5 years.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I23b8c4e1631827e7931f353c561c1e19c596c598

4 years agotls: Make tls CPS test run for a quite long time 10/24210/4
Yu Ping [Mon, 6 Jan 2020 20:02:55 +0000 (04:02 +0800)]
tls: Make tls CPS test run for a quite long time

Type: fix

Change-Id: I8cfb48bd7f92689b296861dd368186408918061b
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agotcp: fix duplicate sack whith reneging 90/24190/9
Florin Coras [Sat, 4 Jan 2020 00:53:04 +0000 (00:53 +0000)]
tcp: fix duplicate sack whith reneging

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I6f7fb91e059996ff702eb9c36e3abaed237fe221

4 years agovppinfra: hash [un]set malloc/free takes a const key 02/24202/3
Neale Ranns [Mon, 6 Jan 2020 21:09:12 +0000 (21:09 +0000)]
vppinfra: hash [un]set malloc/free takes a const key

Type: refactor

the key is not modified by these functions

Change-Id: I578f054355fca69e8a086bb69013155a01ed759f
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agobonding: fix feature.yaml error 11/24211/2
Ole Troan [Tue, 7 Jan 2020 08:30:05 +0000 (09:30 +0100)]
bonding: fix feature.yaml error

Type: fix
Fixes: 6b32b4aad
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8bd6bb95135dc280565f357aa5850292f66979a1
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agobonding: Add FEATURE.yaml 03/24203/2
Steven Luong [Mon, 6 Jan 2020 21:28:34 +0000 (13:28 -0800)]
bonding: Add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I53522a60122014741d1c6533a0456bf31445529a

4 years agoipsec: Add FEATURE/yaml 05/24205/2
Neale Ranns [Mon, 6 Jan 2020 23:16:18 +0000 (23:16 +0000)]
ipsec: Add FEATURE/yaml

Type: docs

Change-Id: I9cb093589b84fdca3f4239da90c431e8bc4d74f1
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoqos: Add FEATURE.yaml 07/24207/2
Neale Ranns [Mon, 6 Jan 2020 23:22:38 +0000 (23:22 +0000)]
qos: Add FEATURE.yaml

Type: docs

Change-Id: Id719ad59dd70f1d97b3cb3722621b10cd63badfb
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agompls: Add FEATURE.yaml 08/24208/2
Neale Ranns [Mon, 6 Jan 2020 23:30:59 +0000 (23:30 +0000)]
mpls: Add FEATURE.yaml

Type: docs

Change-Id: Ic76a4bbfe2e2e45b7ea44556bc974c243970e9bf
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoip-neighbor: Add FEATURE.yaml 04/24204/2
Neale Ranns [Mon, 6 Jan 2020 23:11:09 +0000 (23:11 +0000)]
ip-neighbor: Add FEATURE.yaml

Type: docs

Change-Id: I4c51dad23cf431692ef5b8bdd2391975fb7264d6
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agovmxnet3: add FEATURE.yaml 99/24199/2
Steven Luong [Mon, 6 Jan 2020 18:22:02 +0000 (10:22 -0800)]
vmxnet3: add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I8b0432a3a384dc2431fcb0b4e7c3f0cfb1713d8e

4 years agolacp: Add FEATURE.yaml 00/24200/1
Steven Luong [Mon, 6 Jan 2020 19:17:18 +0000 (11:17 -0800)]
lacp: Add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6fe5555a9ec867d4e39f0751662256717b45e0f9

4 years agoquic: update quicly to v0.0.9-vpp 98/24198/2
MathiasRaoul [Mon, 6 Jan 2020 15:09:50 +0000 (15:09 +0000)]
quic: update quicly to v0.0.9-vpp

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I5cef549de8380b9b9534b8774819e42988f6b784

4 years agol2: Update FEATURE.yaml 97/24197/2
John Lo [Mon, 6 Jan 2020 14:54:36 +0000 (09:54 -0500)]
l2: Update FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: Ib34440c137f24621002ce9463515c632c472a293

4 years agogre: fix feature.yaml error 96/24196/2
Ole Troan [Mon, 6 Jan 2020 11:15:24 +0000 (12:15 +0100)]
gre: fix feature.yaml error

vnet/gre/FEATURE.yaml does not conform with the JSON schema definition.
This bug should no longer happen with the patch that ensures
validation is run as part of checkstyle.

Signed-off-by: Ole Troan <ot@cisco.com>
Type: fix
Change-Id: I25bf8d2a442bf7ccdbf693b031a7a383444dfee3

4 years agoquic: call quic_send_packets only once per ctx 95/24095/3
Aloys Augustin [Fri, 20 Dec 2019 12:14:00 +0000 (13:14 +0100)]
quic: call quic_send_packets only once per ctx

This prevents unnecessary calls to quic_send_packets.

Type: fix
Change-Id: I7abe509aa8b7b9d5a01c9876046cf0f4507a79cf
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
4 years agolb: add FEATURE file for lb/pppoe/gtpu/vxlan-gpe/pppoe 76/24176/2
Hongjun Ni [Fri, 3 Jan 2020 14:34:38 +0000 (22:34 +0800)]
lb: add FEATURE file for lb/pppoe/gtpu/vxlan-gpe/pppoe

Type: docs

Change-Id: Ia3949954423eb7691c02e99444767a9f01a14adf
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
4 years agogre: Add FEATURE.yaml 93/24193/5
Neale Ranns [Sun, 5 Jan 2020 22:10:35 +0000 (22:10 +0000)]
gre: Add FEATURE.yaml

Type: docs

Change-Id: Icda0c8d2141294d78447177dd4823d1b2228e830
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoip6-nd: Add FEATURE.yaml 94/24194/1
Neale Ranns [Sun, 5 Jan 2020 22:17:53 +0000 (22:17 +0000)]
ip6-nd: Add FEATURE.yaml

Type: docs

Change-Id: I907f2c7f5d73dd88b16a6ff78ef072e13af9739e
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agomisc: fix feature.yaml 86/24186/3
Ole Troan [Fri, 3 Jan 2020 15:37:27 +0000 (16:37 +0100)]
misc: fix feature.yaml

Add checkfeaturelist validation to checkstyle.
Fix two files with errors.

Type: docs
Change-Id: I81eda0e25b271f2006b4da22efdf7218d52a67d3
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agovxlan: Add FEATURE.yaml 91/24191/4
John Lo [Sat, 4 Jan 2020 05:32:46 +0000 (00:32 -0500)]
vxlan: Add FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I4372195121e05af671a3f48b1c2796cd0132b279

4 years agol2: Add FEATURE.yaml 88/24188/3
John Lo [Fri, 3 Jan 2020 22:47:34 +0000 (17:47 -0500)]
l2: Add FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: Icd22f2ec7076bb11d6ac7e7d147bd58dc5ad1527

4 years agoipsec: AH copy destination and source address from template 49/24149/2
Neale Ranns [Thu, 2 Jan 2020 05:04:00 +0000 (05:04 +0000)]
ipsec: AH copy destination and source address from template

Type: fix

Change-Id: I63d4df68eed6589763b5ce62bcd7f3fd867c60e1
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoipsec: Targeted unit testing 88/24088/4
Neale Ranns [Fri, 20 Dec 2019 00:54:57 +0000 (00:54 +0000)]
ipsec: Targeted unit testing

Type: fix

1 - big packets; chained buffers and those without enoguh space to add
ESP header
2 - IPv6 extension headers in packets that are encrypted/decrypted
3 - Interface protection with SAs that have null algorithms

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ie330861fb06a9b248d9dcd5c730e21326ac8e973

4 years agotcp: fix rate samples for old acks 19/24119/2
Florin Coras [Mon, 23 Dec 2019 18:03:27 +0000 (10:03 -0800)]
tcp: fix rate samples for old acks

Type: fix

Change-Id: Ieab35bbfba81faae61b1267d8661df5195877824
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agohsa: fix coverity warning 87/24187/3
Florin Coras [Fri, 3 Jan 2020 16:44:47 +0000 (16:44 +0000)]
hsa: fix coverity warning

Type:fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I38b155f7617d002ac16943c2c031269a17f4ba73

4 years agosession: fix per slice fifo prealloc 58/24158/3
Florin Coras [Thu, 2 Jan 2020 19:22:51 +0000 (19:22 +0000)]
session: fix per slice fifo prealloc

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If6db37af6c2863a80d0787a98026b3b8171dad37

4 years agofib: Add dpo FEATURE.yaml file 75/24175/4
Neale Ranns [Fri, 3 Jan 2020 03:55:08 +0000 (03:55 +0000)]
fib: Add dpo FEATURE.yaml file

Type: docs

Change-Id: I9c4727db8d498d0b513157b19ad306b7aaacc222
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agobfd: add feature.yaml 84/24184/3
Klement Sekera [Fri, 3 Jan 2020 12:15:16 +0000 (12:15 +0000)]
bfd: add feature.yaml

Type: docs

Change-Id: Ica2b4a9d4fe2ceaafd6d707ebe3c4a7fa0af1c07
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agotcp: api clenup 79/24179/3
Jakub Grajciar [Fri, 3 Jan 2020 09:02:32 +0000 (10:02 +0100)]
tcp: api clenup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I48f08cc657c28ad1eef50c917a560425137bb70e
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agolldp: add feature.yaml 83/24183/2
Klement Sekera [Fri, 3 Jan 2020 12:02:27 +0000 (12:02 +0000)]
lldp: add feature.yaml

Type: docs

Change-Id: I713ced931e26d5db70cd4678a9d02c5285a1a909
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoip: API cleanup 03/22603/4
Jakub Grajciar [Tue, 8 Oct 2019 12:05:18 +0000 (14:05 +0200)]
ip: API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I17b95bba2327049d2b99e59cea79208814a24b22
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agodevices: virtio API cleanup 79/22279/2
Jakub Grajciar [Thu, 26 Sep 2019 08:34:41 +0000 (10:34 +0200)]
devices: virtio API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I38a409af770c88c1eb2c68b24abef2a5a91e1b9a

4 years agoqos: api clenup 78/24178/2
Jakub Grajciar [Fri, 3 Jan 2020 09:01:03 +0000 (10:01 +0100)]
qos: api clenup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ia66810293e41427c686fbf1ab9be5c8a7db4056a

4 years agompls: api cleanup 77/24177/2
Jakub Grajciar [Fri, 3 Jan 2020 08:59:07 +0000 (09:59 +0100)]
mpls: api cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I44633df6d189da707657fbf9f9ba49c5f3879e9f

4 years agovxlan-gbp: api cleanup 80/24180/2
Jakub Grajciar [Fri, 3 Jan 2020 09:03:32 +0000 (10:03 +0100)]
vxlan-gbp: api cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I26bd57ba506165bf2dd574fa39a81adc4295d796

4 years agobuild: Fix Subject-line feature list extraction 39/23639/4
Jon Loeliger [Tue, 26 Nov 2019 14:11:11 +0000 (08:11 -0600)]
build: Fix Subject-line feature list extraction

Bang on sed until a better incantation appears.

Change-Id: Ib8ad0996b6325db0fe983c86dd7dc553c9d388c4
Type: fix
Fixes: 26ce6ca1fe6f524a9049444fe8d55042fd7530a6
Signed-off-by: Jon Loeliger <jdl@netgate.com>
4 years agomap: fix ip4-map-t DF behavior 90/24090/7
Vladimir Ratnikov [Fri, 20 Dec 2019 09:55:50 +0000 (04:55 -0500)]
map: fix ip4-map-t DF behavior

ip4_is_fragment(header)
or ip4_is_first_fragment(header) didn't changed
when packet with fragmentation needed arrives.

This patch checks DF flag and MTU with packet
length and if DF is set and length > MTU, packet
is dropped. In case if ignore_df is set, DF flag
makes no sense.

Type: fix
Fixes: d6d50cebde647f9a5ee7251a7fef977506f315d7

Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Change-Id: I720e25167c19a0b13ac5fdfb41b12c0bbdc00d09

4 years agonat: use SVR 63/23963/8
Klement Sekera [Thu, 10 Oct 2019 09:46:06 +0000 (09:46 +0000)]
nat: use SVR

Remove NAT's implementation of shallow virtual reassembly with
corresponding CLIs, APIs & tests. Replace with standalone shallow
virtual reassembly provided by ipX-sv-reass* nodes.

Type: refactor
Change-Id: I7e6c7487a5a500d591f6871474a359e0993e59b6
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoabf: add feature.yaml 64/24164/4
Neale Ranns [Thu, 2 Jan 2020 23:34:33 +0000 (23:34 +0000)]
abf: add feature.yaml

Type: docs

Change-Id: I4959010617b0fb51652beafe6967afd556f27e92
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agotls: add features.yaml 62/24162/5
Florin Coras [Thu, 2 Jan 2020 23:28:14 +0000 (23:28 +0000)]
tls: add features.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I847463fd38b9d569d2607b8a17f6d45a04b6fe09

4 years agotcp: add FEATURE.yaml 61/24161/8
Florin Coras [Thu, 2 Jan 2020 22:11:41 +0000 (22:11 +0000)]
tcp: add FEATURE.yaml

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I21f822b597bfa44004bf2afaaf54463cb0ae2efc

4 years agofib: add adjacency feature.yaml 69/24169/5
Neale Ranns [Fri, 3 Jan 2020 00:16:12 +0000 (00:16 +0000)]
fib: add adjacency feature.yaml

Type: docs

Change-Id: I6cdfbae5a0eab8a69dfa2ae054945c510a3c63f6
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agobier: add FEATURE.yaml 74/24174/2
Neale Ranns [Fri, 3 Jan 2020 03:36:40 +0000 (03:36 +0000)]
bier: add FEATURE.yaml

Type: docs

Change-Id: I843a410b7a14c7c61e44ea38cf7cb74f40ccf853
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoarp: add FEATURE.yaml 73/24173/2
Neale Ranns [Fri, 3 Jan 2020 03:03:33 +0000 (03:03 +0000)]
arp: add FEATURE.yaml

Type: docs

Change-Id: If03488de772204a984e1785c33646833f2de6e1e
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoigmp: Add feature.yaml 65/24165/2
Neale Ranns [Thu, 2 Jan 2020 23:36:52 +0000 (23:36 +0000)]
igmp: Add feature.yaml

Type: docs

Change-Id: I8d6ab1b4fd9f059a3f4c8ba28fc9f20debfb65cb
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agol3xc: add feature.yaml 66/24166/2
Neale Ranns [Thu, 2 Jan 2020 23:46:10 +0000 (23:46 +0000)]
l3xc: add feature.yaml

Type: docs

Change-Id: I0d939b26079e9e45fba1cbb7c8e668918c128526
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoudp: add features.yaml 68/24168/2
Florin Coras [Thu, 2 Jan 2020 23:53:22 +0000 (23:53 +0000)]
udp: add features.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2a7d509a2aaed6dba7d821b469c6de90d487f068

4 years agonat: add feature.yaml 60/24160/4
Ole Troan [Thu, 2 Jan 2020 21:32:57 +0000 (22:32 +0100)]
nat: add feature.yaml

And add support for multiple maintainers in JSON schema.

Type: docs
Change-Id: Ice430927ceecf53526a3fdf46c075a95206bf0ac
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agosession: add feature.yaml 70/24170/2
Florin Coras [Fri, 3 Jan 2020 00:23:13 +0000 (00:23 +0000)]
session: add feature.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If9065b03c0cd7d567c54eda383d6297ef554d9f0

4 years agovcl: add feature.yaml 71/24171/2
Florin Coras [Fri, 3 Jan 2020 00:57:33 +0000 (00:57 +0000)]
vcl: add feature.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ifda0404cfc6710d7ecf21da96eb1cb92750b495f

4 years agolisp: add feature.yaml 72/24172/3
Florin Coras [Fri, 3 Jan 2020 01:25:30 +0000 (01:25 +0000)]
lisp: add feature.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iba2203e98c627d550021beee2ec1cfe3cb02686f

4 years agosvs: add feature.yaml 67/24167/2
Neale Ranns [Thu, 2 Jan 2020 23:52:30 +0000 (23:52 +0000)]
svs: add feature.yaml

Type: docs

Change-Id: Ie75368f64201f2f6623413bc2ba015d9dc8fbc9f
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agocrypto-ipsecmb: Add FEATURE.yaml for all crypto engine plugins 63/24163/1
Neale Ranns [Thu, 2 Jan 2020 23:25:05 +0000 (23:25 +0000)]
crypto-ipsecmb: Add FEATURE.yaml for all crypto engine plugins

Type: docs

Change-Id: Ia00e3167e954271c9eb7618792fd86df288d5c19
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agohttp_static: add FEATURE.yaml 57/24157/2
Dave Barach [Thu, 2 Jan 2020 15:26:40 +0000 (10:26 -0500)]
http_static: add FEATURE.yaml

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I2f9a74541183af6c10abea2c29002842ddb88815

4 years agosession: fix listener global endpoint lookup 46/24146/4
Florin Coras [Tue, 31 Dec 2019 05:53:19 +0000 (21:53 -0800)]
session: fix listener global endpoint lookup

Type: fix

Ensure listeners for app transport protocols are added to lookup tables
using their session endpoints instead of their transport connections,
which can override the network connection id in the transport connection.

Change-Id: I56fa3666bb1422c0799fc7143cd099751ff6e2e6
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotests: configure 32 mb physmem 27/24127/2
Dave Barach [Wed, 25 Dec 2019 14:24:58 +0000 (09:24 -0500)]
tests: configure 32 mb physmem

Absolutely nothing good happens when we force the kernel to briefly
map and then unmap 16gb as vpp starts. Effect exacerbated when
TEST_JOBS = 20...40, and so forth.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id8e3ce1763cad3a0891d5d6c8d2c1e3e610682d7

4 years agovirtio: fix checksum offload support 43/23643/4
Benoît Ganne [Tue, 26 Nov 2019 16:59:41 +0000 (17:59 +0100)]
virtio: fix checksum offload support

Checksum offload and GSO are independent. We must support checksum
offload if it has been negotiated, independently of GSO.

Ticket: VPPSUPP-47
Type: fix

Change-Id: I8cb6dd58b61714ebb2726eb4aab0d74d49fdab99
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agogso: fix number of buffers required for segmentation 25/24125/3
Mohsin Kazmi [Tue, 24 Dec 2019 23:12:52 +0000 (00:12 +0100)]
gso: fix number of buffers required for segmentation

Type: fix

Change-Id: I73ef0ce81b2d6a799f6a6e59908ec24cc2290a2c
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agotests: bfd - move test_poll_response to EXTENDED_TESTS 54/23854/2
Paul Vinciguerra [Fri, 6 Dec 2019 16:06:02 +0000 (11:06 -0500)]
tests: bfd - move test_poll_response to EXTENDED_TESTS

  test_bfd.BFD4TestCase.test_poll_response providing
  inconsistent results is the per-patch tests.

Type: test

Change-Id: I8f1864511526fd330a7da1abfa19be3f565c683a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoip: indent format typo fix 47/24147/1
Neale Ranns [Wed, 1 Jan 2020 21:55:41 +0000 (21:55 +0000)]
ip: indent format typo fix

Type: style

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Idfcd4a363d4582ce69fac83ddc760f2dc4feed52

4 years agoip-neighbor: set link-type ARP on incomplete adjacencies 44/24144/1
Neale Ranns [Tue, 31 Dec 2019 03:49:34 +0000 (03:49 +0000)]
ip-neighbor: set link-type ARP on incomplete adjacencies

Type: fix

Change-Id: I05d74da311d6a86ec4eb3df50d53ecaa9c622f50
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agosvm: broadcast on raw dequeues and full rings 40/24140/5
Florin Coras [Fri, 27 Dec 2019 18:26:56 +0000 (10:26 -0800)]
svm: broadcast on raw dequeues and full rings

Type: fix

Change-Id: I0cac9001290e7ed4e2e318ae62c56e97ec75a3db
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agovcl: hold errno when calling LDBG 42/24142/2
hanlin [Mon, 30 Dec 2019 08:25:20 +0000 (16:25 +0800)]
vcl: hold errno when calling LDBG

Type: fix

Call trace of LDBG:
LDBG->clib_warning->_clib_error->dispatch_message->os_puts->writev
However, writev will hijacked by LDP, and then execute following code:
if ((errno = -ldp_init ()))
    return -1;
Now, errno will be set.

Because we always call LDBG just before return from ldp_accept4, listen,
and etc. So errno will be overwritted after LDBG called.

Signed-off-by: hanlin <hanlin_wang@163.com>
Change-Id: I7a90f3a14772994f11f09650481411796e3f5630

4 years agotcp: validate port reuse 39/24139/1
Florin Coras [Fri, 27 Dec 2019 17:27:52 +0000 (09:27 -0800)]
tcp: validate port reuse

Type: fix

Make sure existing connection is in time-wait

Change-Id: I8e8bef151f81bcd589b4da0d4bf63cc59f9f451b
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotcp: Enable TCP timewait port use 34/24134/3
Yu Ping [Thu, 26 Dec 2019 20:04:33 +0000 (04:04 +0800)]
tcp: Enable TCP timewait port use

Improve host stack CPS test, and it help improve 10x performance

Type: feature

Change-Id: I6af61e0bad7c16ee2d30a1422cc46bb89f1cedb4
Signed-off-by: Yu Ping <ping.yu@intel.com>
Signed-off-by: Yuwei Zhang <yuwei1.zhang@intel.com>
4 years agotests: test_mpls_v6_ebgp_pic - don't write to stdout 36/24136/1
Paul Vinciguerra [Fri, 27 Dec 2019 05:17:01 +0000 (00:17 -0500)]
tests: test_mpls_v6_ebgp_pic - don't write to stdout

Type: test

Change-Id: I2cccc68b1b4b6c576580ae0eb5d4511ca2f4663d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agovcl: EPOLLOUT should be generated when epoll_ctl called with EPOLLOUT 29/24129/3
hanlin [Thu, 26 Dec 2019 03:44:28 +0000 (11:44 +0800)]
vcl: EPOLLOUT should be generated when epoll_ctl called with EPOLLOUT
event

Type: fix

When we call epoll_ctl to add or mod fd with EPOLLOUT event, mostly to
check if we can write. So we expect a EPOLLOUT event should be generated
immediately unless tx queue is full.

Signed-off-by: hanlin <hanlin_wang@163.com>
Change-Id: Ie99986a44dbb07b6ff2fba6512171056f79e77bd

4 years agotests: tls - don't print skip info to stdout 33/24133/1
Paul Vinciguerra [Fri, 27 Dec 2019 00:13:02 +0000 (19:13 -0500)]
tests: tls - don't print skip info to stdout

Type: test

Change-Id: Id1bffbfe698113d85c4c6bf432ddf4908ed2b788
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoclassify: "classify filter ..." debug CLI cleanup 23/24123/3
Dave Barach [Tue, 24 Dec 2019 21:59:38 +0000 (16:59 -0500)]
classify: "classify filter ..." debug CLI cleanup

The pcap trace filter initial table index lives in
cm->filter_set_by_sw_if_index [0], which corresponds to the "local0"
interface. Debug cli makes sure that folks don't accidentally specify
the "local0" interface. At least it does now...

Fix the "vlib format.c code coverage" test in test/test_vlib.py.

Type: fix
Change-Id: I35320bc2c8f0c6f1f8c12e3529d1938548185151
Signed-off-by: Dave Barach <dave@barachs.net>
4 years agounittest: test_bihash call clib_time_init(...) 22/24122/1
Dave Barach [Tue, 24 Dec 2019 20:25:37 +0000 (15:25 -0500)]
unittest: test_bihash call clib_time_init(...)

Fix "Rejecting large frequency change of +infinity" errors.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I8efca1291e38c48bb98e7f8109253224a4f0a2a1

4 years agotests: fix skip logic on test_tap 24/24024/3
Paul Vinciguerra [Mon, 16 Dec 2019 23:24:24 +0000 (18:24 -0500)]
tests: fix skip logic on test_tap

log.txt message:
17:52:59,969 API call failed, expected 0 return value instead of -13 in tap_create_v2_reply(_0=58, context=77019, retval=-13, sw_if_index=4294967295)

Test was failing with log message:
  tap: tap0: tap_create_if: ioctl(TUNSETIFF): Operation not permitted

Type: test
Change-Id: I5bcd9d2b0c870ea5eef92b79314b97821399722f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoip-neighbor: ip_neighbor_advertise() handles null 20/24120/1
Matthew Smith [Mon, 23 Dec 2019 22:25:11 +0000 (16:25 -0600)]
ip-neighbor: ip_neighbor_advertise() handles null

Type: fix
Fixes: cbe25aab3b

ip_neighbor_advertise() was calling one of both of
ip4_neighbor_advertise() and/or ip6_neighbor_advertise() with
&addr->{ip4|ip6} as an argument. If addr is null, which is likely
a requirement when the type is IP46_TYPE_BOTH, this results in a
SEGV.

Check addr and pass a pointer to one of it's members if it is not
null, otherwise pass null.

Change-Id: I6261bb8fe947365fe3d6c58788ea27d5cb28ff05
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
4 years agoipsec: Test and fix IPSec worker hand-off 13/24113/2
Neale Ranns [Mon, 23 Dec 2019 04:10:25 +0000 (04:10 +0000)]
ipsec: Test and fix IPSec worker hand-off

Type: fix

Change-Id: I5cb9a3845ddbc5f4de4eb4e9c481f606fe5cec9a
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agotcp: accept sack reneging as a cc event 08/24108/2
Florin Coras [Sun, 22 Dec 2019 17:20:26 +0000 (09:20 -0800)]
tcp: accept sack reneging as a cc event

Type: fix

Change-Id: Iead1303ca3dec7593eb3ce54f291b82d94c821a4
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agovcl: fix multi-thread app segment attaching 09/24109/2
Florin Coras [Sun, 22 Dec 2019 20:48:05 +0000 (12:48 -0800)]
vcl: fix multi-thread app segment attaching

Type: fix

Guard segment attaching/deletion, not only the hash table CRD
operations.

Change-Id: Ic96e4adedffb73baf89e971438596927e6daf930
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotests: vpp_memif fix formatting error in exception 61/23861/4
Paul Vinciguerra [Sat, 7 Dec 2019 02:40:38 +0000 (21:40 -0500)]
tests: vpp_memif fix formatting error in exception

Type: test

Change-Id: I2d32797efd1c3478a862b7950ef9ab63428da890
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agotests: TestL2bdMultiInst - break serial dependency on tests 29/24029/5
Paul Vinciguerra [Tue, 17 Dec 2019 01:56:00 +0000 (20:56 -0500)]
tests: TestL2bdMultiInst - break serial dependency on tests

enable the tests to run out of order/enable running an individual test.
  Before:
  [gw1] [ 20%] FAILED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_02
  [gw0] [ 40%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_01
  [gw1] [ 60%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_04
  [gw0] [ 80%] FAILED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_03
  [gw1] [100%] SKIPPED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_05
  -------
  After:
  [gw1] [ 20%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_02
  [gw0] [ 40%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_01
  [gw1] [ 60%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_04
  [gw0] [ 80%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_03
  [gw1] [100%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_05

Type: test

Change-Id: Ie40eb310f5fccacf854c364aa017891bce9b9372
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agofib: use 32 bits per-source reference counter 94/24094/3
Miklos Tirpak [Fri, 20 Dec 2019 10:55:43 +0000 (11:55 +0100)]
fib: use 32 bits per-source reference counter

The 16 bits reference counter limited the number of interfaces
per FIB table to 65K from a given source. Some use cases, for example
GTP-U tunnels require much more interfaces than that.
This change increases the size of the reference counter to 32 bits.

Type: fix

Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: I944a98513018840f904f2808c2a1e963b37886cc

4 years agoip-neighbor: fix API initialization call 02/24102/2
Matthew Smith [Fri, 20 Dec 2019 18:39:41 +0000 (12:39 -0600)]
ip-neighbor: fix API initialization call

Type: fix
Fixes: cbe25aab3b

Wrap ip_neighbor_api_init() in VLIB_API_INIT_FUNCTION() macro
instead of VLIB_INIT_FUNCTION() so API message IDs get allocated.

Change-Id: Id0c36c16b982feb9d7442015f9ddf2449a9e5b60
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
4 years agosession: move add/del segment msg to mq 97/21497/20
Florin Coras [Sun, 25 Aug 2019 01:17:34 +0000 (18:17 -0700)]
session: move add/del segment msg to mq

Type: refactor

Change-Id: I32234173ebd69f80acb1afa4039fffbd19157f6d
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agosvm: fix multichunk alloc with not enough space 04/24104/1
Florin Coras [Sat, 21 Dec 2019 02:48:20 +0000 (18:48 -0800)]
svm: fix multichunk alloc with not enough space

Type: fix

Change-Id: Ia89c76b0e897fc3a3ebbc8dcba25e8ac9974b7fa
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agovxlan: reuse inner packet flow hash for tunnel outer header load balance 49/24049/6
Shawn Ji [Wed, 18 Dec 2019 02:10:54 +0000 (10:10 +0800)]
vxlan: reuse inner packet flow hash for tunnel outer header load balance

Type: fix

Several tunnels encapsulation use udp as outer header and udp src port
is set by inner header flow hash, such as gtpu, geneve, vxlan, vxlan-gbd
Since flow hash of inner header is already been calculated, keeping it
to vnet_buffere[b]->ip.flow_hash should save load-balance node work to
select ECMP uplinks.

Change-Id: I0e4e2b27178f4fcc5785e221d6d1f3e8747d0d59
Signed-off-by: Shawn Ji <xiaji@tethrnet.com>
4 years agosvm: fix sh ssvm size for private segments 81/24081/4
Florin Coras [Thu, 19 Dec 2019 18:13:15 +0000 (10:13 -0800)]
svm: fix sh ssvm size for private segments

Type: fix

Change-Id: Id11cb596923541c12d37f1afa00416d73c6ff5e3
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotests: don't prompt to launch gdb for sanity test case 84/24084/2
Paul Vinciguerra [Thu, 19 Dec 2019 21:09:43 +0000 (16:09 -0500)]
tests: don't prompt to launch gdb for sanity test case

Type: test

Change-Id: I4c54121b76b341381a819cee928c3c2455a83503
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agohsa: Add periodic timing 68/24068/3
Nathan Skrzypczak [Thu, 19 Dec 2019 10:54:10 +0000 (11:54 +0100)]
hsa: Add periodic timing

Type: feature

Change-Id: I18cf38d6f77e0d42212c85262f3bb769b9477b29
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agointerface: Prevent bad inner-dot1q any exact-match configuration 77/24077/3
Jon Loeliger [Thu, 19 Dec 2019 15:03:52 +0000 (09:03 -0600)]
interface: Prevent bad inner-dot1q any exact-match configuration

Someone much more knowledgeable than I wrote:

    For L3 IP forwarding, any VLAN tags on a packet must be exact
    match to a sub-interface which means both outer and inner VLAN
    tag IDs must be exact-matched to specific values defined of that
    sub-interface.  Without exact match on a L3 sub-interface, VPP
    has no mechanism to know what VLAN tags to use for packet output,
    such as ARP request packets or IP packets, on that sub-interface.

    Thus, sub-interface with "inner-dot1q any" is not an exact match
    sub-interface by definition since no match is present on inner
    tag.

While in the area, fix a memory leak that would ensue on poorly
configured interfaces.

Change-Id: I8d17a96dbca3e3724c297ecc935ca61764e6ce2e
Type: fix
Signed-off-by: Jon Loeliger <jdl@netgate.com>
4 years agobash: add -j <jobs> option to vpp-make-test 64/24064/4
Dave Wallace [Wed, 18 Dec 2019 19:06:31 +0000 (14:06 -0500)]
bash: add -j <jobs> option to vpp-make-test

- Also cleanup local var declarations
- remove extraneous export statement

Type: test

Change-Id: I22198a65d1785ba53d1de22b2aa498cab910701b
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
4 years agogtpu: Track the dst FIB entry instead of RR sourcing that 70/24070/2
Miklos Tirpak [Thu, 19 Dec 2019 11:06:20 +0000 (12:06 +0100)]
gtpu: Track the dst FIB entry instead of RR sourcing that

RR sourcing the destination FIB entry limits the number of tunnels
to 255 for a particular destination. This change removes this limit.

Type: fix

The patch is based on 1f50bf8fc57ebf78f9056185a342493be460a847
that introduced the FIB entry tracking but did not update
the gtpu plugin.

Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: I8a4a87382a6eb5120e2bb65b9bc3c446bbfdbd3b

4 years agosession: reserve memory for rbtree 65/24065/5
Florin Coras [Wed, 18 Dec 2019 21:06:41 +0000 (13:06 -0800)]
session: reserve memory for rbtree

Type: fix

Change-Id: I2b89f6e4c09297e3712d88cd25c80a806d3005aa
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agopapi: lazily initialize stats client 03/23703/5
Paul Vinciguerra [Fri, 29 Nov 2019 22:41:20 +0000 (17:41 -0500)]
papi: lazily initialize stats client

  remove wait-loop on stats socket from test framework.

Type: refactor

Change-Id: I5bb95a7c597707a87f9d9a471215c4b4af1a2280
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agogre: multipoint ingress lookup fix 42/24042/3
Neale Ranns [Tue, 17 Dec 2019 20:15:03 +0000 (20:15 +0000)]
gre: multipoint ingress lookup fix

Type: fix

Change-Id: I170edd62220a63cb19efea3032e173fb87730b1b
Signed-off-by: Neale Ranns <nranns@cisco.com>