tests: fix skip logic on test_tap 24/24024/3
authorPaul Vinciguerra <pvinci@vinciconsulting.com>
Mon, 16 Dec 2019 23:24:24 +0000 (18:24 -0500)
committerDave Barach <openvpp@barachs.net>
Tue, 24 Dec 2019 12:49:55 +0000 (12:49 +0000)
log.txt message:
17:52:59,969 API call failed, expected 0 return value instead of -13 in tap_create_v2_reply(_0=58, context=77019, retval=-13, sw_if_index=4294967295)

Test was failing with log message:
  tap: tap0: tap_create_if: ioctl(TUNSETIFF): Operation not permitted

Type: test
Change-Id: I5bcd9d2b0c870ea5eef92b79314b97821399722f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
test/test_tap.py

index 9258978..2e66da3 100644 (file)
@@ -6,10 +6,10 @@ from vpp_devices import VppTAPInterface
 
 
 def check_tuntap_driver_access():
-    return os.access("/dev/net/tun", os.R_OK or os.W_OK)
+    return os.access("/dev/net/tun", os.R_OK and os.W_OK)
 
 
-@unittest.skipUnless(check_tuntap_driver_access(), "Permission denied")
+@unittest.skipIf(check_tuntap_driver_access(), "Permission denied")
 class TestTAP(VppTestCase):
     """ TAP Test Case """