vpp.git
3 years agoapi: fromjson/tojson enum flag support 85/30385/2
Ole Troan [Fri, 4 Dec 2020 12:15:30 +0000 (13:15 +0100)]
api: fromjson/tojson enum flag support

Represent enum flags as JSON arrays (as these can have multiple values).
Add unit tests.

Type: improvement
Change-Id: I680c5b6f76ef6f05f360e2f3b9c4cbb927e15d7d
Signed-off-by: Ole Troan <ot@cisco.com>
3 years agomisc: cop - clean up stray doxygen block 78/30378/3
Paul Vinciguerra [Fri, 11 Dec 2020 03:32:19 +0000 (03:32 +0000)]
misc: cop - clean up stray doxygen block

Type: style

Change-Id: Iee9463735c4d114a97e6167d717d1911c4477e70
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agonat: fix byte order on ipfix message fields 54/29754/2
Matthew Smith [Wed, 4 Nov 2020 17:18:10 +0000 (11:18 -0600)]
nat: fix byte order on ipfix message fields

Type: fix

The code for quota exceeded events is a u32 and was being copied
into ipfix packets in host byte order. Same for the limit field.

Swap the order before copying into packet buffer.

Change-Id: I881766e1c52acc9bebde38d85228fa492214ee21
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
3 years agofib: remove unsued path flag 41/30341/2
Neale Ranns [Tue, 8 Dec 2020 14:16:10 +0000 (14:16 +0000)]
fib: remove unsued path flag

Type: refactor

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: Ic4ef53f49102d7b5061f1b6d3a1d0c8427b9d1f7

3 years agofib: Remove unused BIER variables 67/30367/2
Neale Ranns [Thu, 10 Dec 2020 08:51:24 +0000 (08:51 +0000)]
fib: Remove unused BIER variables

Type: refactor

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: Idf17c3c02fb77fcadf69a9164abd4da35289aaed

3 years agosrv6-mobile: Fix the position of QFI 24/30224/8
Tetsuya Murakami [Wed, 2 Dec 2020 03:19:13 +0000 (19:19 -0800)]
srv6-mobile: Fix the position of QFI

Type: fix

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: Ica02435c4bc198fb6c4b9e4b62a287e47689ae7a
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
3 years agovcl: fix listener session close problem 72/30372/2
wanghanlin [Thu, 10 Dec 2020 11:12:22 +0000 (19:12 +0800)]
vcl: fix listener session close problem

Type: fix

Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: I34ac04f05b84b271679aafc253f1606f11e29835

3 years agovcl: fix crash problem for invalidation of vls_table_lock 82/28782/6
wanghanlin [Fri, 11 Sep 2020 09:19:32 +0000 (17:19 +0800)]
vcl: fix crash problem for invalidation of vls_table_lock

Type: fix

Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: I0649f4d5adb5fa5b407431ea23982f2ad87fb657

3 years agotests: check ethernet type in arp test case 74/30374/2
Elias Rudberg [Thu, 10 Dec 2020 13:20:43 +0000 (14:20 +0100)]
tests: check ethernet type in arp test case

Add assertions to verify correct ethernet type field in ARP test case.

Type: test

Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: I1d2671b0ab2b4dcb53dab4b54bf93578d6bc86a3

3 years agoapi: remove unused singular option 48/30348/2
Ole Troan [Tue, 8 Dec 2020 19:35:32 +0000 (20:35 +0100)]
api: remove unused singular option

The singular option to the API language was added as a way to deal with messages
that do not have a reply message. Examples in memclnt.api.
Instead dealt with these messages using the service {} construct.

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If01b390b24b7539d1f93de4b8edfe1dad08e509d

3 years agomisc: add a couple useful functions for gdb 58/28658/4
Christian Hopps [Mon, 13 Jul 2020 15:57:27 +0000 (11:57 -0400)]
misc: add a couple useful functions for gdb

- vgb() (vlib_get_buffer)
- ph() (pool_header)

Type: feature
Signed-off-by: Christian Hopps <chopps@labn.net>
Change-Id: Ica954480a7809c918cf65b06a0333ebe246a6f3a

3 years agohsa: http proxy connected callback fixes 58/30358/2
nandfan [Wed, 9 Dec 2020 10:12:55 +0000 (18:12 +0800)]
hsa: http proxy connected callback fixes

svm_fifo_init_ooo_lookup has been called by transport

Type: fix

Signed-off-by: nandfan <fanyufei521@outlook.com>
Change-Id: I6626421c9a71212be0f7b8bff953133f760811f6

3 years agobash: Update jjb version in jjb-sandbox-env function 32/30332/2
Dave Wallace [Mon, 7 Dec 2020 22:23:10 +0000 (17:23 -0500)]
bash: Update jjb version in jjb-sandbox-env function

- The version of jjb deployed in jenkins.fd.io was
  upgraded to 3.5.0. Make the sandbox setup function
  use the same version.

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I486faffc6b5a0cce7425dd526adf9dbc034b2d85

3 years agofib: supporting inner flow hash on tunnels 15/30215/14
Mohammed Hawari [Mon, 30 Nov 2020 12:50:24 +0000 (13:50 +0100)]
fib: supporting inner flow hash on tunnels

Change-Id: I53011e089bfecb08483792029b534b09b9e33a10
Type: improvement
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
3 years agoikev2: test responder behind NAT 27/30327/2
Filip Tehlar [Fri, 4 Dec 2020 17:38:11 +0000 (17:38 +0000)]
ikev2: test responder behind NAT

Type: test
Ticket: VPP-1903

Change-Id: I7fab6931833d6e253b7b921172825387302d8f70
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agobuild: fix centos-8 'make install-deps' enable PowerTools repo 44/30344/2
Dave Wallace [Tue, 8 Dec 2020 15:50:08 +0000 (10:50 -0500)]
build: fix centos-8 'make install-deps' enable PowerTools repo

- The name of the powertools repo was changed [0]
  in centos-8 from 'PowerTools' to 'powertools'.
  Retrieve the correct name from 'dnf repolist all'
  instead of hard coding it.

[0] https://git.centos.org/rpms/centos-repos/c/b759b17557b9577e8ea156740af0249ab1a22d70

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ic1402e671eb1d70dec429bab82ad18d8251f4eef

3 years agotests: restore vapi C++ test under Centos-8 94/30294/4
Paul Vinciguerra [Mon, 7 Dec 2020 02:46:31 +0000 (02:46 +0000)]
tests: restore vapi C++ test under Centos-8

The Centos-7 compiler had problems with vapi_cpp_test.cpp.
The Centos-8 compiler does not.  This change adds back the test.

==============================================================================
VAPI test
==============================================================================
run C VAPI tests                                                     1.55 OK
run C++ VAPI tests                                                   0.44 OK

==============================================================================
TEST RESULTS:
     Scheduled tests: 2
      Executed tests: 2
        Passed tests: 2
==============================================================================

Type: test

Change-Id: Ic6a655ae99eb3ba0e73b7feef4436a0ca5fd92be
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agofib: Adjacency flag for midchain to perfom flow hash (on inner packet) 99/29999/10
Neale Ranns [Tue, 17 Nov 2020 09:47:07 +0000 (09:47 +0000)]
fib: Adjacency flag for midchain to perfom flow hash (on inner packet)

Type: feature

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: I964afd9266645de5c87d49c58ce6b48c2c18f97f

3 years agotunnel: add cli support for encap_decap flags 14/30214/5
Mohammed Hawari [Tue, 1 Dec 2020 10:30:57 +0000 (11:30 +0100)]
tunnel: add cli support for encap_decap flags

Change-Id: I2bf6ba325975309183dba1e14e9519c944710752
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: improvement

3 years agosvm: fix ssvm_va for private segments 34/30334/3
Florin Coras [Tue, 8 Dec 2020 02:35:12 +0000 (18:35 -0800)]
svm: fix ssvm_va for private segments

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I8288a1ed97b375626d69ac7efa0256211834d89c

3 years agoipip: correct ipip_cli.c indentation 13/30213/3
Mohammed Hawari [Tue, 1 Dec 2020 10:20:31 +0000 (11:20 +0100)]
ipip: correct ipip_cli.c indentation

Change-Id: I162061f83a190723c3b4b5585717851c4b9ba255
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix

3 years agopapi: remove old client reference 38/30238/4
Paul Vinciguerra [Wed, 2 Dec 2020 19:13:14 +0000 (14:13 -0500)]
papi: remove old client reference

deprecated in 3/19

Type: refactor

Change-Id: Ia8eebaa0cd89d1e95166a62645400946d8db2f75
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agomisc: fix api in ipfix_classify_table_add/details 68/29168/4
Alexander Chernavin [Wed, 30 Sep 2020 14:36:10 +0000 (10:36 -0400)]
misc: fix api in ipfix_classify_table_add/details

In ipfix_classify_table_add_del and ipfix_classify_table_details the
ip_version field has vl_api_address_family_t type. However, there is
no encode/decode for the field in the IPFIX API. Moreover, the IPFIX
code expects the field to contain raw 4 or 6 to indicate the IP
version.

With this change, encode/decode the ip_version field in the IPFIX
API. Also, stop converting transport_protocol between host and network
byte order because it's u8.

Type: fix
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
Change-Id: I4051756b8077b4367dd779cb555a34f74f6d7a9d

3 years agofib: Source Address Selection 97/30197/2
Neale Ranns [Thu, 26 Nov 2020 08:37:27 +0000 (08:37 +0000)]
fib: Source Address Selection

Type: feature

Use the FIB to provide SAS (in so far as it is today)
 - Use the glean adjacency as the record of the connected prefixes
 = there's a glean per-{interface, protocol, connected-prefix}
 - Keep the glean up to date with whatever the recieve host prefix is
(since it can change)

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: I0f3dd1edb1f3fc965af1c7c586709028eb9cdeac

3 years agonat: avoid hairpinning infinite loop problem 84/30284/3
Elias Rudberg [Fri, 4 Dec 2020 18:32:55 +0000 (19:32 +0100)]
nat: avoid hairpinning infinite loop problem

Fix in nat44 hairpinning code to check if anything was actually
changed in the snat_hairpinning() routine, and return 0 if nothing
changed. This helps avoid an infinite loop repeating the three
nodes nat44-hairpinning-->ip4-lookup-->ip4-local in case there
was no change. Also add a corresponding test case.

Type: fix

Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: I95f48476bd002ac4c6789afe504681f1963e5d38
Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
3 years agodocs: Fix CentOS 8 build 30/30330/2
Jon Loeliger [Mon, 7 Dec 2020 15:57:46 +0000 (10:57 -0500)]
docs: Fix CentOS 8 build

Type: fix

Signed-off-by: Jon Loeliger <jdl@netgate.com>
Change-Id: I2d0d29af9186c50735d9a3b41148549f5cde614e

3 years agodpdk: support mlx drivers linked with rdma-core 51/30051/6
Mohammed Hawari [Fri, 20 Nov 2020 17:37:14 +0000 (18:37 +0100)]
dpdk: support mlx drivers linked with rdma-core

Change-Id: I8b8e4420f7643df95c27f4a4764809e8ddd2d12e
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: improvement

3 years agotests: py2 cleanup - remove subclassing of object 85/30285/6
Paul Vinciguerra [Fri, 4 Dec 2020 19:57:51 +0000 (14:57 -0500)]
tests: py2 cleanup - remove subclassing of object

Type: refactor

Change-Id: I9096e3b473110350e1e8e5936e3c4c164f8969a7
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agotests: remove the dependency on subprocess32 91/30291/7
Paul Vinciguerra [Sat, 5 Dec 2020 22:39:14 +0000 (22:39 +0000)]
tests: remove the dependency on subprocess32

Type: test

Change-Id: I39afe56a085648d881a18c7eafcf7caf2f375f31
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agowireguard: run feature after gso 54/30154/2
Nathan Skrzypczak [Thu, 26 Nov 2020 13:07:42 +0000 (14:07 +0100)]
wireguard: run feature after gso

This allows using GSO with wireguard

Type: fix

Change-Id: Id00a1425f9d9412aca9f259beda55a46bf5595d7
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
3 years agovlib: vlib_log for "linux device up" warnings 93/30293/2
Dave Barach [Sun, 6 Dec 2020 13:15:18 +0000 (08:15 -0500)]
vlib: vlib_log for "linux device up" warnings

Make it easy to figure out why vpp didn't bind a particular hardware
interface in the most common case: the Linux interface is up.

Type: improvement

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I99534dd91e0030601c09171a9fbc9ad45af6bf08

3 years agotests: refactor ForeignAddressFactory 88/30288/3
Paul Vinciguerra [Fri, 4 Dec 2020 22:50:26 +0000 (17:50 -0500)]
tests: refactor ForeignAddressFactory

Move ForeignAddressFactory back to test_lisp.
It is the only test that uses the code and has
embedded addresses specific to the test.

Type: test

Change-Id: If1a39f9b167e36dd7aff7481350ddb8fe17155d2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agovirtio: fix the interrupt handling for packed queues 32/30232/3
Mohsin Kazmi [Wed, 2 Dec 2020 15:39:42 +0000 (16:39 +0100)]
virtio: fix the interrupt handling for packed queues

Type: fix

Change-Id: I2cc1cfd519e5b3502c59cf72e95e454f9122b8e5
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
3 years agocrypto: fixed vnet_crypto_async_reset_frame assert 46/30246/2
PiotrX Kleski [Tue, 24 Nov 2020 07:34:09 +0000 (07:34 +0000)]
crypto: fixed vnet_crypto_async_reset_frame assert

Type: fix

Changed vnet_crypto_async_reset_frame assert to expect also
ERROR state frames.

Signed-off-by: PiotrX Kleski <piotrx.kleski@intel.com>
Change-Id: I3abc29f3f9642027aee38a59a932e54c90da859d

3 years agocrypto: fixed async frame enqueue race condition 47/30247/2
PiotrX Kleski [Tue, 24 Nov 2020 08:26:26 +0000 (08:26 +0000)]
crypto: fixed async frame enqueue race condition

Type: fix

To avoid race condition happening in async crypto engines,
async frame state and thread index set should happen before enqueue.
In addition as the enqueue handler already returns the enqueue status,
when an enqueue is failed, the async crypto engine shall not worry
about setting the async frame state but let the submit_open_frame function
to do just that.

Signed-off-by: PiotrX Kleski <piotrx.kleski@intel.com>
Reviewed-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: Ic1b0c94478b3cfd5fab98657218bbd70c46a220a

3 years agoacl: fix acl-plugin testcases packet counting 30/30130/3
Andrew Yourtchenko [Wed, 25 Nov 2020 14:42:54 +0000 (14:42 +0000)]
acl: fix acl-plugin testcases packet counting

Counter checks in ACL tests were incorrect if VPP is running with multiple workers

Change-Id: Id095d55c6cd3bfee8aaac6d177984e569e87d29b
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
3 years agolibmemif: clean up typos 50/27350/3
Paul Vinciguerra [Sat, 30 May 2020 03:03:06 +0000 (23:03 -0400)]
libmemif:  clean up typos

Type: style

Change-Id: I0d25d922312dfd60a665916cf47c3d2faa29ea49
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agoavf: fix coverity issue 83/30283/2
Mohammed Hawari [Fri, 4 Dec 2020 16:00:16 +0000 (17:00 +0100)]
avf: fix coverity issue

Change-Id: I1b589c924326a98c4cabe5496ce72b20673b5153
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: fix

3 years agoudp session: fix deq notification for dgrams 67/30267/3
Florin Coras [Fri, 4 Dec 2020 02:19:39 +0000 (18:19 -0800)]
udp session: fix deq notification for dgrams

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1440c11fb9d962a05d877aebb4de364c86f9953e

3 years agovirtio: fix the len offset 49/30249/2
Mohsin Kazmi [Thu, 3 Dec 2020 10:35:23 +0000 (11:35 +0100)]
virtio: fix the len offset

Type: fix

Change-Id: I8ce1df5c97941fb645b33476db9cfc74f1395b15
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
3 years agoip: fixup memory leak in function ip4_full_reass_drop_all 74/30274/4
barryxie [Fri, 4 Dec 2020 11:21:23 +0000 (19:21 +0800)]
ip: fixup memory leak in function ip4_full_reass_drop_all

Type: fix

The vector 'to_free' allocated on heap should be freed to avoid memory leak.

Signed-off-by: barryxie <barryxie@tencent.com>
Change-Id: I539498b50a7f3e346c83b869fb400868961c233f

3 years agopapi: add support for enumflag part 1 of 2 66/30266/4
Paul Vinciguerra [Fri, 4 Dec 2020 02:06:28 +0000 (21:06 -0500)]
papi:  add support for enumflag part 1 of 2

Allow for papi to accept the new enumflag type.

Change-Id: I8d8dc8fdb122e9a1b1881f5b2558635c75e4a299
Type: feature
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
(cherry picked from commit 299abebe2942b4c78b85f9f3b8843f8213bf1efe)

3 years agovppapigen: add parser support for enumflags 18/30118/12
Paul Vinciguerra [Wed, 25 Nov 2020 04:26:06 +0000 (23:26 -0500)]
vppapigen:  add parser support for enumflags

Type: improvement

Change-Id: I0f15862cc8399a4f7c8a81fe44ba8b27d8772278
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Signed-off-by: Ole Troan <ot@cisco.com>
(cherry picked from commit e15523297bb3905f2e0eef4272fc69a8a92463cc)

3 years agostats: fix coverity issues 71/30271/2
Andrew Yourtchenko [Fri, 4 Dec 2020 07:22:01 +0000 (07:22 +0000)]
stats: fix coverity issues

Usage of the possibly negative value with subsequent check on it
makes coverity very unhappy, so put the check before use.

Change-Id: I731fbe6246f9e4212d546fd9277bc1ddcd3c2ec1
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
3 years agolisp: .api dont set defaults in reply messages 32/26932/2
Paul Vinciguerra [Wed, 6 May 2020 19:11:42 +0000 (15:11 -0400)]
lisp:  .api dont set defaults in reply messages

Type: fix

Change-Id: I39afa6ee048dd293c5e17120fa661052eb3477d1
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agotls: allow picotls to use secp elliptic curves 58/30258/2
Vladimir Medvedkin [Wed, 2 Dec 2020 17:39:01 +0000 (17:39 +0000)]
tls: allow picotls to use secp elliptic curves

Fix typos in macros for elliptic curves over prime field.

Type: fix
Fixes: f83194c2f4

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Change-Id: I657a7feaf1d1fdf3f2ca74fb3787977c65891a20

3 years agovirtio: fix the offloads in tx path 56/30256/2
Mohsin Kazmi [Thu, 3 Dec 2020 15:35:20 +0000 (16:35 +0100)]
virtio: fix the offloads in tx path

Type: fix

Change-Id: I1f1f0b6e8c5ef8bc9f2aca4bdc78e89fa951b841
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
3 years agonat: fix forwarding handoff workaround 94/29594/13
Filip Varga [Thu, 22 Oct 2020 09:13:00 +0000 (11:13 +0200)]
nat: fix forwarding handoff workaround

A special case when out2in packet needs to
be handoffed to other worker thread. We are
not able to determine which thread they belong
to in the first processing of nat handoff node.
These packets needs to go through out2in slowpath
before we are able to tell where to handoff them.

Type: fix
Ticket: VPP-1941

Change-Id: I7173bda970ce6a91d81f48fc72aa2457586a076f
Signed-off-by: Filip Varga <fivarga@cisco.com>
3 years agotests: remove py2/py3 six compatability library 44/30244/4
Paul Vinciguerra [Thu, 3 Dec 2020 05:42:46 +0000 (00:42 -0500)]
tests: remove py2/py3 six compatability library

Type: test

Change-Id: Idb6b8169845e0239e639429ccfd02a683212b7e6
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agotls: fix passed argument in openssl plugin 57/30257/2
Vladimir Medvedkin [Wed, 2 Dec 2020 17:56:12 +0000 (17:56 +0000)]
tls: fix passed argument in openssl plugin

Thread index used in qat_init_thread() is passed via a pointer
to a variable located on a stack that does not exist
when qat_init_thread is actually executed.

Type: fix
Fixes: f4a92f6a1c

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Change-Id: I65dd4e604b78fcb1cf0452d707f47f9785e6371d

3 years agosvm: fix mutex consistency on trylock 33/30233/4
Florin Coras [Wed, 2 Dec 2020 15:57:00 +0000 (07:57 -0800)]
svm: fix mutex consistency on trylock

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I1370943935b460a1a1a22847fed2c97b1272a5e1

3 years agopapi: remove python2 patterns 40/30240/3
Paul Vinciguerra [Wed, 2 Dec 2020 19:34:27 +0000 (14:34 -0500)]
papi: remove python2 patterns

Type: refactor

Change-Id: I541759b4b788acf08599661eb9e7abc58e9283d2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agopapi: allow client control over loggers 42/30242/2
Paul Vinciguerra [Wed, 2 Dec 2020 22:43:59 +0000 (17:43 -0500)]
papi: allow client control over loggers

This change enables a client to set debug levels
globally as well as individually.

exposes loggers as
  vpp_papi
  vpp_papi.serializer
  vpp_papi.transport

Type: improvement

Change-Id: Ib6bd1a1f552b51a22c9fe3de819a5fb970963ae5
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agostats: char-pointer arithmetic style-up 36/30236/3
Vratko Polak [Wed, 2 Dec 2020 17:45:16 +0000 (18:45 +0100)]
stats: char-pointer arithmetic style-up

Char* typed shared_header value appears multiple times,
so store it is a variable.
Pointer "p" value is used more frequently casted to char*,
so use that type for it, and convert to void* only at return.

Type: style
Fixes: 41f15ae1dfd4ac1777b684fdc763d12496209418

Change-Id: I7b3f1e6a43c020acd7ae561f87d12237b07fcd66
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
3 years agonat: fix incorrect session removal case 37/30237/3
Klement Sekera [Wed, 2 Dec 2020 18:27:24 +0000 (18:27 +0000)]
nat: fix incorrect session removal case

Add a condition where a TCP session in transitory timeout is kept
instead of being erroneously deleted.

Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: Ic625c8c88cc8864293ebd57b0321505652af9380

3 years agotests: fix typo in numbered list in documentation 50/30250/1
Elias Rudberg [Thu, 3 Dec 2020 12:29:38 +0000 (13:29 +0100)]
tests: fix typo in numbered list in documentation

Fix a typo in numbered list in the documentation. Also mention
possibility of using TEST= to run a specific test.

Type: fix

Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: I026703af014493afb3dea2d9ad99a7bb510b135d

3 years agotests: remove aenum library 45/30245/1
Paul Vinciguerra [Thu, 3 Dec 2020 05:46:03 +0000 (00:46 -0500)]
tests:  remove aenum library

the aenum library was used to provide intflag functionality
for python versions earlier than 3.6

Type: test

Change-Id: I914d390ee5364f337006c1c59abafe4b9a3c1bde
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agotests: add type annotations to the vpp object abstract class 22/30222/2
Paul Vinciguerra [Tue, 1 Dec 2020 16:33:28 +0000 (11:33 -0500)]
tests: add type annotations to the vpp object abstract class

make it easier to detect logical mistakes.

Type: test

Change-Id: I853748ffaeebc545c8d31299f0d105405ad80bba
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agonat: use correct per-thread vlib_main 35/30135/2
Benoît Ganne [Wed, 25 Nov 2020 13:32:53 +0000 (14:32 +0100)]
nat: use correct per-thread vlib_main

Using vlib_main of another thread is prohibited.

Type: fix

Change-Id: I9a85a5fee5c6665d423b4306faf3b3f2c5e22f99
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agopapi: improve unit testability 08/30208/4
Paul Vinciguerra [Tue, 1 Dec 2020 07:00:35 +0000 (02:00 -0500)]
papi:  improve unit testability

refactor the code so that snippets of json can be used to test vpp_papi
example unit test provided

Type: improvement

Change-Id: Ibec608fd2e5b12515aa4db17d85d4319134c22ea
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agostats: void-pointer arithmetic fix 07/30207/2
Elias Rudberg [Tue, 1 Dec 2020 06:52:48 +0000 (07:52 +0100)]
stats: void-pointer arithmetic fix

Cast to (char *) to avoid pointer arithmetic for (void *) pointers.

Type: fix

Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: I62607b4cbc553449e2c60d514b4b17dbb4f88216

3 years agopapi: fix copy/paste error 25/30225/2
Paul Vinciguerra [Wed, 2 Dec 2020 04:45:38 +0000 (23:45 -0500)]
papi: fix copy/paste error

Type: fix

Change-Id: I8bd20fb38e132f6ab8cbc0e73095b649b5946498
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agoikev2: fix nat traversal 21/30221/3
Filip Tehlar [Tue, 1 Dec 2020 14:51:09 +0000 (14:51 +0000)]
ikev2: fix nat traversal

Type: fix

Change-Id: Ie723cf680745ec2292a15e2df05c1821436dba19
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agosession: make pacer worker load aware 19/29919/7
Florin Coras [Thu, 12 Nov 2020 18:20:05 +0000 (10:20 -0800)]
session: make pacer worker load aware

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I71b9d54311fcad808fcdaad0df2dca8c161d580e

3 years agosession: allow small pacer bursts 27/29727/13
Florin Coras [Tue, 3 Nov 2020 02:00:32 +0000 (18:00 -0800)]
session: allow small pacer bursts

Instead of enforcing a "strict" release of data, which relies on
frequent rescheduling of sessions, allow some pacer coalescing, i.e.,
short bursts, that can minimize load on scheduler/session layer and
potentially leverage tso.

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I67e38e5b8dc335bd214113b70c68c27ae92bd6da

3 years agowireguard: return public key in api 46/30146/4
Nathan Skrzypczak [Thu, 26 Nov 2020 08:27:01 +0000 (09:27 +0100)]
wireguard: return public key in api

Type: feature

Change-Id: Iacb0da8bc738ed400678f9bb40e70e0031c6588e
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
3 years agotests: remove ip_punt from vpp_papi_provider and add ip_punt object models 12/30212/2
Jakub Grajciar [Tue, 1 Dec 2020 10:23:44 +0000 (11:23 +0100)]
tests: remove ip_punt from vpp_papi_provider and add ip_punt object models

Type: refactor

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I1bf53c2554e6b313467f618717698ed158db9065
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
3 years agoipsec: change prediction 79/29979/4
Fan Zhang [Wed, 18 Nov 2020 09:46:39 +0000 (09:46 +0000)]
ipsec: change prediction

Type: improvement

This patch changes the prediction of the comparison between
SA owner thread index and the current thread index.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: I48de0bb2c57dbb09cfab63925bf8dc96613d8bcf

3 years agoavf: add TSO support 30/29930/6
Mohammed Hawari [Tue, 10 Nov 2020 09:26:45 +0000 (10:26 +0100)]
avf: add TSO support

Change-Id: Ica663e1d07225acf53fd74b0051a5a2a34174960
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
Type: improvement

3 years agoebuild: perform build and install at the same time for external.mk 01/30201/2
Mohammed Hawari [Mon, 30 Nov 2020 14:04:43 +0000 (15:04 +0100)]
ebuild: perform build and install at the same time for external.mk

Change-Id: I65379f346fe3f881ce4196d99882cd6013e5e154
Type: improvement
Signed-off-by: Mohammed Hawari <mohammed@hawari.fr>
3 years agotests: Fix unversioned python shebang lines 05/30205/1
Dave Wallace [Mon, 30 Nov 2020 21:56:43 +0000 (16:56 -0500)]
tests: Fix unversioned python shebang lines

- Unversioned python shebang lines may cause
  mixed python 2.7 and python 3 execution in
  make test.

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ia82c37be33902718c48878378b8343eedb76c2c8

3 years agosvm: make svm queue mutex robust 85/30185/4
Florin Coras [Fri, 27 Nov 2020 17:49:10 +0000 (09:49 -0800)]
svm: make svm queue mutex robust

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I256774c25b3c4105139a4728724a1a0c775e740f

3 years agotests: IPv6 multicast over GRE 47/30047/2
Neale Ranns [Fri, 20 Nov 2020 14:32:56 +0000 (14:32 +0000)]
tests: IPv6 multicast over GRE

Type: test

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I6fc907ba923581540380bc9b456b5183fc100775

3 years agomap: add include guard to map.h 87/30187/2
Paul Vinciguerra [Sun, 29 Nov 2020 21:05:42 +0000 (16:05 -0500)]
map:  add include guard to map.h

Type: fix

Change-Id: I26c3640d9fe82d4cf22f19935eeca1411f9a1c3b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
3 years agodpdk: fix cryptodev compile 78/30178/6
Fan Zhang [Thu, 26 Nov 2020 16:14:53 +0000 (16:14 +0000)]
dpdk: fix cryptodev compile

Type: fix

VPP 20.09 used new cryptodev raw APIs in cryptodev_dp_api.c
provided by the DPDK 20.08 patch attached.

The APIs has been updated between now and then and will cause
Cryptodev engine compile failed when bumping DPDK to 20.11
due to the incompatible API formats.

As a temp solution to successfully bumping DPDK version this patch
makes the newer DPDK version using old cryptodev APIs by compiling
cryptodev.c instead.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: I3db607c8c1b2b028166a750c4d66dfc6ff18814c

3 years agoip: Sub Address Family types. Feature enable for each SAFI 76/30176/4
Neale Ranns [Thu, 26 Nov 2020 14:15:33 +0000 (14:15 +0000)]
ip: Sub Address Family types. Feature enable for each SAFI

Type: improvement

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: I318424ffa569d9a09187066d6ba15576757c1cf6

3 years agovlib: fix vlib log elog vector overrun 81/30181/2
Benoît Ganne [Thu, 26 Nov 2020 18:56:44 +0000 (19:56 +0100)]
vlib: fix vlib log elog vector overrun

vlib log strings are vectors not necessarily null-terminated C-string.

Type: fix
Fixes: bc867c3d2137dab4b1395196c1936233517980ab

Change-Id: Ia805ecdf4e76ccb1001dc93647161ee1c3adebc9
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agocrypto: improve ipsecmb engine performance 80/30180/2
Fan Zhang [Thu, 26 Nov 2020 17:01:05 +0000 (17:01 +0000)]
crypto: improve ipsecmb engine performance

Type: improvement

This patch improves ipsecmb engine performance by disabling
safety features: SAFE_DATA, SAFE_PARAM, and SAFE_LOOKUP.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: I756edc54d6bc35a1b0e9383e94cba0f73cf663cb

3 years agodocs: fix bihash doc bugs 51/30151/2
Dave Barach [Thu, 26 Nov 2020 12:47:48 +0000 (07:47 -0500)]
docs: fix bihash doc bugs

Change hash -> hash_table in the pro forma main_t structure.
Remove trailing whitespace.

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I10c310dded14d52ad09df7ca3a76e60f15266b6b

3 years agosvm: use internal function to prealloc fifo hdrs 82/30182/2
Florin Coras [Thu, 26 Nov 2020 19:34:38 +0000 (11:34 -0800)]
svm: use internal function to prealloc fifo hdrs

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ic13828e235d01ec5b73658e4bdd19e510932713d

3 years agonat: fix tests 94/29994/3
Filip Varga [Thu, 19 Nov 2020 09:58:42 +0000 (10:58 +0100)]
nat: fix tests

Fixed nat_ha and ipfix tests. Removed obsolete tests
and moved extended tests to standard tests.

Type: fix
Change-Id: I2d7f4c4fa4c52a4aa10d70c956e085a0fe00b911
Signed-off-by: Filip Varga <fivarga@cisco.com>
3 years agovcl: avoid coalescing dgrams on read 44/30144/2
Florin Coras [Thu, 26 Nov 2020 04:26:32 +0000 (20:26 -0800)]
vcl: avoid coalescing dgrams on read

Type: improvement

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I035f1ef26202bbcf918548cbaa3cdbc17944bf8a

3 years agosvm: only try to pre-allocate requested number of fifo pairs 36/30136/4
Benoît Ganne [Wed, 25 Nov 2020 14:06:01 +0000 (15:06 +0100)]
svm: only try to pre-allocate requested number of fifo pairs

Type: fix

Change-Id: I6f7679fd48d0ed98677c58f8c08d7e969e8e8220
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agovlib: clean up event-logger CLI 24/30124/6
Dave Barach [Wed, 25 Nov 2020 12:23:42 +0000 (07:23 -0500)]
vlib: clean up event-logger CLI

Change "elog trace" to "event-logger trace"; corresponding change in
test/test_vlib.py, verified that the vlib test vectors still pass even
though they're not run on a regular basis ("make GCOV_TESTS=yes
TEST=test_vlib ...")

Type: improvement

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Idee4aa036573865e071a9bab87e27fb5d53b4933

3 years agogre: Move to new API generated types/messages 55/30155/2
Neale Ranns [Thu, 26 Nov 2020 13:12:37 +0000 (13:12 +0000)]
gre: Move to new API generated types/messages

Type: improvement

also clean up GRE includes across the code base.

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I90928b0da3927b7ca1a23683aa80d4b53bbf63fd

3 years agofib: Expressive type for walk return code. Honour code. 48/30148/2
Neale Ranns [Thu, 26 Nov 2020 09:34:39 +0000 (09:34 +0000)]
fib: Expressive type for walk return code. Honour code.

Type: improvement

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: I487e698555545fce85d02d55deaaf7bb0007e388

3 years agofib: DPO layout add u64 parameter. 49/30149/2
Neale Ranns [Thu, 26 Nov 2020 09:41:01 +0000 (09:41 +0000)]
fib: DPO layout add u64 parameter.

Type: improvement

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: Iee04af801814b6360b045cf7dc8bcad6f517229e

3 years agoikev2: better handling when no IKE DH configured 22/30122/3
Filip Tehlar [Sat, 21 Nov 2020 21:30:45 +0000 (21:30 +0000)]
ikev2: better handling when no IKE DH configured

Type: improvement

Change-Id: I4289d20adaa3f2872889d5dbaafd9c025df8aca8
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
3 years agoip: reassembly - fix handoff for custom node 39/28739/7
Klement Sekera [Thu, 10 Sep 2020 12:03:54 +0000 (12:03 +0000)]
ip: reassembly - fix handoff for custom node

Type: fix
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: If484725d48190246e4da09ceaed48a68a8a253f2

3 years agoip: trace icmp echo request/reply id 40/30140/2
Klement Sekera [Wed, 25 Nov 2020 16:47:00 +0000 (16:47 +0000)]
ip: trace icmp echo request/reply id

Type: improvement
Change-Id: Ie3a5b182e446c407f258c043c22d1cf25eb7ee59
Signed-off-by: Klement Sekera <ksekera@cisco.com>
3 years agofib: Only track cover if activated 20/30120/2
Neale Ranns [Wed, 25 Nov 2020 09:14:22 +0000 (09:14 +0000)]
fib: Only track cover if activated

Type: fix

also cleanup any tracking at delete

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Id1037920c88c63e2029384af931064c00ed497aa

3 years agoipsec: A P2MP ipsec interface is NBMA 42/30142/1
Neale Ranns [Wed, 25 Nov 2020 19:35:38 +0000 (19:35 +0000)]
ipsec: A P2MP ipsec interface is NBMA

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I1922463683201215933e9f85b587d7c7123f3bfd

3 years agosession: add startup option to poll in main 39/30139/7
Florin Coras [Wed, 25 Nov 2020 16:44:16 +0000 (08:44 -0800)]
session: add startup option to poll in main

Type: improvement

Needed to support multi-worker tests

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I68d5590cece24a744513dc6c324dfb2861a38a94

3 years agovlib: add elog events for vlib log entries 32/30132/2
Dave Barach [Wed, 25 Nov 2020 15:07:09 +0000 (10:07 -0500)]
vlib: add elog events for vlib log entries

Pretty interesting to see how long plugins take to load.

Type: improvement

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If496eb73b2e1fd9dd714142cd5195fa7ccd93ebd

3 years agodns: use correct per-thread vlib_main 37/30137/4
Benoît Ganne [Wed, 25 Nov 2020 15:43:13 +0000 (16:43 +0100)]
dns: use correct per-thread vlib_main

Using vlib_main of another thread is prohibited.

Type: fix

Change-Id: I7ae294dfaf2526738e91408c9b4865ef9f801b8a
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agosyslog: use per-thread vlib_main 33/30133/2
Benoît Ganne [Wed, 25 Nov 2020 12:51:33 +0000 (13:51 +0100)]
syslog: use per-thread vlib_main

We should not use main thread vlib_main in workers.

Type: fix

Change-Id: I58c0a8cadf2dc7f768b20ac90e7ec7921e2e8ca4
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agotcp: enable lc if any other debug option enabled 16/30116/4
Florin Coras [Wed, 25 Nov 2020 01:29:17 +0000 (17:29 -0800)]
tcp: enable lc if any other debug option enabled

Also fix debug build after snd_una_nxt removal.

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ife52689cd30cdebf36057cf4d20d7f6207f1e29e

3 years agopci: add PCIe Gen4 link speed 38/30138/2
Damjan Marion [Wed, 25 Nov 2020 16:13:38 +0000 (17:13 +0100)]
pci: add PCIe Gen4 link speed

Type: improvement
Change-Id: Iccf4fabe912ab7ac45b6fc082824a67d4fd9f216
Signed-off-by: Damjan Marion <damarion@cisco.com>
3 years agodns: fix double-unlock 34/30134/1
Benoît Ganne [Wed, 25 Nov 2020 12:53:21 +0000 (13:53 +0100)]
dns: fix double-unlock

dns cache should no longer be unlocked by caller.

Type: fix
Fixes: 84a563ae4050cc0389dcd438fbe9ea882f2b8404

Change-Id: I3708718ae8f00e4e4f4e04381caa0095c8494b82
Signed-off-by: Benoît Ganne <bganne@cisco.com>
3 years agoip-neighbor: Send API event when neighbor is removed 45/30045/3
Neale Ranns [Fri, 20 Nov 2020 13:05:59 +0000 (13:05 +0000)]
ip-neighbor: Send API event when neighbor is removed

Type: fix

Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
Change-Id: I9952497a108bac26445af95c28d4eed46099c2fc