vpp.git
4 years agomisc: Add CentOS 8 package support 08/23308/8
Renato Botelho do Couto [Thu, 7 Nov 2019 12:10:34 +0000 (06:10 -0600)]
misc: Add CentOS 8 package support

Type: feature

Added missing dependencies on RPM spec file and install-dep

Ticket: VPP-1800

Signed-off-by: Renato Botelho do Couto <renato@netgate.com>
Change-Id: I91d39c94b3f03c213249dff42b264718ef772bdb

4 years agovlib: add max-size configuration parameter for pmalloc 82/23082/3
jieqiang wang [Tue, 22 Oct 2019 07:54:40 +0000 (15:54 +0800)]
vlib: add max-size configuration parameter for pmalloc

Enable 'max-size' configuration parameter to set maximum size of
memory space allocated for pmalloc module. This parameter along
with existing 'base-addr' falls into physmem section. Both are
dedicated parameters to pmalloc module.

Type: feature

Change-Id: I939f25156b9a43440a24d69a7397d57eb6c2d392
Signed-off-by: Jieqiang Wang <Jieqiang.Wang@arm.com>
4 years agol2: l2_patch_main should not be static 71/23471/3
Vratko Polak [Thu, 21 Nov 2019 09:29:40 +0000 (10:29 +0100)]
l2: l2_patch_main should not be static

Without understanding what is going on,
a pattern from l2_fwd.c is applied to l2_patch.c file.

Type: fix
Fixes: d770cfc96257f9bd9e0c96c8ebe50e4531dc1bc5
Ticket: VPP-1799

Change-Id: Ia97d448f9d1846549f57ea69044ae15fa39bb942
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
4 years agovlib: fix startup-config-process stack overflow 94/23794/2
GordonNoonan [Wed, 4 Dec 2019 15:16:40 +0000 (15:16 +0000)]
vlib: fix startup-config-process stack overflow

Type: fix

Startup config setting an i40e/ice interface
up in Debug VPP consumes more than the currently
available stack space.

Signed-off-by: GordonNoonan <gordon.noonan@intel.com>
Change-Id: I98b52c5596799017b97f802a8661b76cd1bb3245

4 years agobonding: drop traffic on backup interface for active-backup mode 62/23862/5
Steven Luong [Sat, 7 Dec 2019 05:12:41 +0000 (21:12 -0800)]
bonding: drop traffic on backup interface for active-backup mode

For active-backup mode, we transmit on one and only one interface. However,
we might still receive traffic on the backup interface. We should drop them
and strictly process incoming traffic on only the active interface.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Idb6b798b30033e84044b151c616be3c157329731

4 years agoflow: add ethernet flow 01/24001/3
Chenmin Sun [Sat, 14 Dec 2019 17:16:45 +0000 (01:16 +0800)]
flow: add ethernet flow

Type: feature

This patch adds the ethernet type flow support

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I6de163d04c6472df60a5f296fb428efd000267c4

4 years agomisc: address sanitizer: do not instrument dlmalloc internals 35/23735/2
Benoît Ganne [Mon, 2 Dec 2019 16:42:56 +0000 (17:42 +0100)]
misc: address sanitizer: do not instrument dlmalloc internals

Type: fix

Change-Id: I2b8273666db864d80012c39623ae866ac3527426
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovlib: fix an issue with show pci 49/23849/4
Vratko Polak [Fri, 6 Dec 2019 15:49:36 +0000 (16:49 +0100)]
vlib: fix an issue with show pci

The fix has been received over e-mail from Lijian Zhang.
https://lists.fd.io/g/vpp-dev/message/14808

Type: fix
Ticket: VPP-1805

Change-Id: I73e5fe7dcbe2b0b1c639d844f29183eab3b6dd66
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
4 years agobuild: export vapi generation in vpp-dev 67/23867/8
Oliver Giles [Thu, 5 Dec 2019 21:37:36 +0000 (23:37 +0200)]
build: export vapi generation in vpp-dev

Adds the higher-level vapi generation to cmake/api.cmake and exposes
the necessary python scripts in vpp-dev, so that out-of-tree/downstream
plugins can also leverage the more convenient API.

Type: feature

Signed-off-by: Oliver Giles <oliver_g@radwin.com>
Change-Id: I8c40a14d27ba3cb972c6907632e03c0e7b0ce982

4 years agobuild: Allow to override build date with SOURCE_DATE_EPOCH 19/23819/6
Bernhard M. Wiedemann [Thu, 5 Dec 2019 15:51:26 +0000 (16:51 +0100)]
build: Allow to override build date with SOURCE_DATE_EPOCH

and make host and user overridable
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Also switch to UTC to be independent of timezone.
Also use ISO 8601 date format to be easier to parse.
This is similar to c9f40227836b827b71a6cbc4744d4b7151b2fcef
and df82ec8fe7d91467c8b479bba74c761c0a6ffc59
which was lost in the move away from automake.

Note: This date call is designed to work with different flavors
of date (GNU, BSD and others).
If only GNU (Linux) support is needed, the patch can be simplified.

This PR was done while working on reproducible builds for openSUSE.

Type: fix

Change-Id: If4cab12320e6b5fcb1f2842fac5d745b33b01ed7
Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
4 years agovlib: fix vector-as-C-string overflow 16/24016/2
Benoît Ganne [Mon, 16 Dec 2019 14:49:47 +0000 (15:49 +0100)]
vlib: fix vector-as-C-string overflow

Type: fix

Change-Id: If0419ff1a82d45e5b3326973008e1b9feb290c5a
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agomisc: address sanitizer: fix instrumentation 15/24015/2
Benoît Ganne [Mon, 16 Dec 2019 14:37:28 +0000 (15:37 +0100)]
misc: address sanitizer: fix instrumentation

Type: fix

Change-Id: I99e3951f8cfb7ab9d2f0a7dcee92199eab29043c
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoclassify: add complex encap packet tracing test 13/23913/4
Benoît Ganne [Tue, 10 Dec 2019 11:48:26 +0000 (12:48 +0100)]
classify: add complex encap packet tracing test

Type: test

Change-Id: I392975c00d7dae86dacedf7559aafa431e71cb14
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoclassify: forbid invalid match config 12/23912/4
Benoît Ganne [Tue, 10 Dec 2019 11:44:46 +0000 (12:44 +0100)]
classify: forbid invalid match config

Forbid too long match to be configured.

Type: fix

Change-Id: Icfced0f86821d5febd6a3c81e1315bd9737498c0
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoipsec: bind an SA to a worker 64/18664/15
Neale Ranns [Tue, 2 Apr 2019 08:13:33 +0000 (08:13 +0000)]
ipsec: bind an SA to a worker

the sequence number increment and the anti-replay window
checks must be atomic. Given the vector nature of VPP we
can't simply use atomic increments for sequence numbers,
since a vector on thread 1 with lower sequence numbers could
be 'overtaken' by packets on thread 2 with higher sequence
numbers.
The anti-replay logic requires a critical section, not just
atomics, and we don't want that.
So when the SA see the first packet it is bound to that worker
all subsequent packets, that arrive on a different worker,
are subject to a handoff.

Type: feature

Change-Id: Ia20a8645fb50622ea6235ab015a537f033d531a4
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agodpdk: add devargs support 89/23989/2
Chenmin Sun [Fri, 13 Dec 2019 22:59:03 +0000 (06:59 +0800)]
dpdk: add devargs support

Type: feature

This patch adds the devargs support for dpdk device
The devargs are used as hardware-specific init args for dpdk devices
please refer to the nic guides under
$(DPDK_DIR)/doc/guides/nics/$(NIC_DRIVER).rst

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: Id380d04720090bb66afe5ce09d664e5e248b8eb9

4 years agovppinfra: fix cpu flag string overflow 18/24018/2
Benoît Ganne [Mon, 16 Dec 2019 15:00:14 +0000 (16:00 +0100)]
vppinfra: fix cpu flag string overflow

Type: fix

Change-Id: Idb1fff8a172034044bb33d5b271a84d1fd672ef5
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoperfmon: fix per-worker data initialization 13/24013/2
Benoît Ganne [Mon, 16 Dec 2019 14:26:49 +0000 (15:26 +0100)]
perfmon: fix per-worker data initialization

When perfmon_init is called at initialization time worker threads are
not created yet and vec_len(vlib_mains) returns 1.
Initialize per-worker data when the number of workers is known, when
enabling data collection instead.

Type: fix

Change-Id: I36887cc7b2a3e88d9728d3cd7262d9b1c968dd3c
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agonhrp: mGREv6 28/24028/3
Neale Ranns [Tue, 17 Dec 2019 00:14:26 +0000 (00:14 +0000)]
nhrp: mGREv6

Type: test

Change-Id: I7d0496c37e06d3b6eee325a262e5398860282b63
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agol2: fix l2input_feat_names overflow 17/24017/2
Benoît Ganne [Mon, 16 Dec 2019 14:51:38 +0000 (15:51 +0100)]
l2: fix l2input_feat_names overflow

Type: fix

Change-Id: I59549b3aab5a0ccfe7db02757f78528e028121a5
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovirtio: fix the tx queue thread binding 97/23097/6
Mohsin Kazmi [Wed, 30 Oct 2019 14:00:04 +0000 (15:00 +0100)]
virtio: fix the tx queue thread binding

Type: fix

Change-Id: Ibbe7e20aebc9153ceba07e048dc0eaa45193f4ea
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agoquic: Implement crypto contexts 10/23310/15
Nathan Skrzypczak [Thu, 7 Nov 2019 12:52:09 +0000 (13:52 +0100)]
quic: Implement crypto contexts

Type: feature

Make quic use the crypto contexts. This introduces a crypto context
pool backed by a hashtable giving ctx indexes by connect params
(ckpair, engine, rx & tx fifo sizes).
Applications keep the initialization vector common.

Change-Id: I22ed6711196cd70a2f2f74240f12113c7af8dfcd
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agogso: minor fixes to gso segmentation 07/23907/2
Mohsin Kazmi [Mon, 9 Dec 2019 10:46:01 +0000 (11:46 +0100)]
gso: minor fixes to gso segmentation

Type: fix

Change-Id: I01602ba7f1a4820c7790a771a5a7281ed66ff905
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agodocs: improve compressed core file documentation 34/24034/1
Dave Barach [Tue, 17 Dec 2019 14:35:23 +0000 (09:35 -0500)]
docs: improve compressed core file documentation

In particular, document "zcat vpp_core.gz | dd conv=sparse of=vpp_core"

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I01b70492ced864b47847c2ef7bc1ea8eb0980ec3

4 years agoip: Protocol Independent IP Neighbors 19/22819/26
Neale Ranns [Mon, 30 Sep 2019 10:53:31 +0000 (10:53 +0000)]
ip: Protocol Independent IP Neighbors

Type: feature

 - ip-neighbour: generic neighbour handling; APIs, DBs, event handling,
aging
 - arp: ARP protocol implementation
 - ip6-nd; IPv6 neighbor discovery implementation; separate ND,
MLD, RA
 - ip6-link; manage link-local addresses
 - l2-arp-term; events separated from IP neighbours, since they are not
the same.

vnet retains just enough education to perform ND/ARP packet
construction.
arp and ip6-nd to be moved to plugins soon.

Change-Id: I88dedd0006b299344f4c7024a0aa5baa6b9a8bbe
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agovcl: RX event may lost when accept session repeatedly 10/24010/3
wanghanlin [Mon, 16 Dec 2019 11:14:39 +0000 (19:14 +0800)]
vcl: RX event may lost when accept session repeatedly

Type: fix

Some applications may call accept repeatedly to process all connect
request until get EAGIAIN error. Subsequent call may get RX event of
previous accepted session, then should process it rather than just
discard it.

Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: Ice53442de66289a62591b79a9cc31e883e894c23

4 years agoquic: update quicly to v0.0.8-vpp 09/23909/4
MathiasRaoul [Tue, 10 Dec 2019 10:56:20 +0000 (10:56 +0000)]
quic: update quicly to v0.0.8-vpp

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I7470d79d1e39716ff83ba2d2b320813d79e2554c

4 years agofib: Glean on NBMA interface points to drop 04/24004/5
Neale Ranns [Mon, 16 Dec 2019 00:53:11 +0000 (00:53 +0000)]
fib: Glean on NBMA interface points to drop

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Iaae7a9e120bbf8168c581b06d3ac0e124b32e0e7

4 years agofib: Adjacency walk fix for IPv6 23/24023/2
Neale Ranns [Mon, 16 Dec 2019 23:14:14 +0000 (23:14 +0000)]
fib: Adjacency walk fix for IPv6

Type: fix

Change-Id: Id3a1950e49d5eb1883af06a14df97e98f55162a8
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agovppinfra: bihash walk cb typedef and continue/stop controls 23/23823/2
Neale Ranns [Fri, 6 Dec 2019 05:53:17 +0000 (05:53 +0000)]
vppinfra: bihash walk cb typedef and continue/stop controls

Type: feature

Change-Id: I28f7a658be3f3beec9ea32635b60d1d3a10d9b06
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agofib: Adjacency creation notifications for dlegates 03/24003/1
Neale Ranns [Sun, 15 Dec 2019 22:26:37 +0000 (22:26 +0000)]
fib: Adjacency creation notifications for dlegates

Type: feature

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I3feddfe44dee528b9ca05aa0150e9423306ae49d

4 years agotests: changes for scapy 2.4.3 migration 99/23999/3
snaramre [Fri, 13 Dec 2019 23:39:35 +0000 (23:39 +0000)]
tests: changes for scapy 2.4.3 migration

Type: fix
Change-Id: I7e041b666dabd90df23a920a1f1d99db4c10ddfe
Signed-off-by: snaramre <snaramre@cisco.com>
4 years agobonding: Add /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/partner-state 90/23390/5
Steven Luong [Wed, 13 Nov 2019 03:45:49 +0000 (19:45 -0800)]
bonding: Add /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/partner-state

We already had /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/state in
the stats segment. Add also the partner-state to be complete.
Change to populate stats segment with the states at startup, after processing
an lacp pdu, and after timer expiration.

Unit test
---------
sudo vpp_get_stats dump | grep /if/lacp
63.00 /if/lacp/3/1/state
61.00 /if/lacp/3/1/partner-state
63.00 /if/lacp/3/2/state
61.00 /if/lacp/3/2/partner-state

Type: feature

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ib7b8e1183d572bb6e422a846aaa2b7b3559a0dc7

4 years agohsa: Fix timing & nits 03/23903/3
Nathan Skrzypczak [Tue, 10 Dec 2019 09:23:13 +0000 (10:23 +0100)]
hsa: Fix timing & nits

Type: fix

Change-Id: I4fef896a3556df75532ef938ca2e263287dd74e8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agoip: SVR: fix wrong return value 39/23939/2
Klement Sekera [Wed, 11 Dec 2019 13:06:27 +0000 (13:06 +0000)]
ip: SVR: fix wrong return value

Type: fix

Change-Id: I9498b660bf2045bb6aac96d19bb9456a14b35847
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoikev2: fix crash during SA rekey 16/23816/4
Filip Tehlar [Sat, 30 Nov 2019 20:49:40 +0000 (20:49 +0000)]
ikev2: fix crash during SA rekey

Type: fix

Change-Id: Ib00ab9b2f28c0f4d85e96bf95697f61b8e415f37
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
4 years agovcl: fix disconnect from binary api 73/23973/2
Florin Coras [Thu, 12 Dec 2019 20:01:24 +0000 (12:01 -0800)]
vcl: fix disconnect from binary api

Type: fix

Change-Id: I4398d26879b5efd932fa1d9ae232aa918ec736d6
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agovlib: fix "<command> help" 44/23944/2
Dave Barach [Wed, 11 Dec 2019 14:46:56 +0000 (09:46 -0500)]
vlib: fix "<command> help"

Walk the sub_commands vector directly.

Type: fix
Fixes: 6b3f25caff262b536a5449ac5461dd041c92a655

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I3022b39e5a739647ec68effc6756166ce2da85b6

4 years agosession svm: support for segments larger than 4GB 52/23952/5
Florin Coras [Wed, 11 Dec 2019 22:27:53 +0000 (14:27 -0800)]
session svm: support for segments larger than 4GB

Type: feature

Change-Id: I7d3017bbb369261d74f51807a226f2c12f45291c
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agogbp: use explicit types in api 35/23835/2
Ole Troan [Fri, 6 Dec 2019 12:28:54 +0000 (13:28 +0100)]
gbp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia886858fe608782d64a5346dd33e1e9fa22d8b8f

4 years agosession svm: per thread fifo segment slices 71/23871/15
Florin Coras [Mon, 9 Dec 2019 02:30:42 +0000 (18:30 -0800)]
session svm: per thread fifo segment slices

Type: refactor

Change-Id: I9be652e56cdb48b0aee3253f7ce8d9bed299d824
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Dave Barach <dave@barachs.net>
4 years agoavf: explicit types in api 30/23830/2
Ole Troan [Fri, 6 Dec 2019 12:14:14 +0000 (13:14 +0100)]
avf: explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If693e066eeb9312d4535893c279446dc43e8baa2

4 years agonat: session cleanup fix 83/23683/9
Filip Varga [Wed, 27 Nov 2019 16:40:29 +0000 (17:40 +0100)]
nat: session cleanup fix

Ticket: VPP-1795
Type: fix

Change-Id: Ib3b5742119d7013c293a11eb3dd1aadf46b422dd
Signed-off-by: Filip Varga <fivarga@cisco.com>
4 years agordma: add explicit types in api 29/23829/2
Ole Troan [Fri, 6 Dec 2019 12:12:29 +0000 (13:12 +0100)]
rdma: add explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I80c674b73b7f86cf159b8779aab31a87b20def9a

4 years agodocs: Rework the startup configuration section 23/23923/5
John DeNisco [Tue, 10 Dec 2019 19:25:50 +0000 (14:25 -0500)]
docs: Rework the startup configuration section

Type: docs

Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: Ic60aac96a4aeb5532f98dfb85c776bf549c0d660
Signed-off-by: Dave Barach <dave@barachs.net>
4 years agovcl: separate binary api connections per thread worker 87/23687/15
Florin Coras [Thu, 28 Nov 2019 22:21:21 +0000 (14:21 -0800)]
vcl: separate binary api connections per thread worker

Type: fix

Change-Id: I2d72efc74a3b0a5b9e4da265475b1b01bf361125
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agoapi: Use vl_msg_push/pop_heap 25/23625/9
Nathan Skrzypczak [Mon, 25 Nov 2019 15:29:38 +0000 (16:29 +0100)]
api: Use vl_msg_push/pop_heap

Type: refactor

Change-Id: I0eb46676fc22ce6825b2d879498df344b5a855e8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agosession: Add mq debug cli 29/23729/4
Nathan Skrzypczak [Mon, 2 Dec 2019 15:44:42 +0000 (16:44 +0100)]
session: Add mq debug cli

Type: feature

This add a `show app message queue` cli command
that shows mq size per app & thread.

Change-Id: I5c6ce024b149fb7a47d899bc514c5a4887429982
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agoquic: Add support for unidirectional streams 59/23759/5
Nathan Skrzypczak [Tue, 3 Dec 2019 15:25:11 +0000 (16:25 +0100)]
quic: Add support for unidirectional streams

Type: feature

Change-Id: I3a642626a444504594c5e3df40dbc92df54136f0
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agohsa: Add option for multiple ips 43/23843/4
Nathan Skrzypczak [Fri, 6 Dec 2019 13:44:25 +0000 (14:44 +0100)]
hsa: Add option for multiple ips

Type: feature

Change-Id: I133f12f9075a09bda0c5c1ed143d03838b33f6da
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agoquic: Use per thread next_cid 01/23901/2
Nathan Skrzypczak [Tue, 10 Dec 2019 09:10:01 +0000 (10:10 +0100)]
quic: Use per thread next_cid

Type: fix

Change-Id: Ia89427257b78f6f7ba62c9d1076bf0593ee2dca7
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agodevices: vhost API cleanup 77/22277/7
Jakub Grajciar [Thu, 26 Sep 2019 08:21:59 +0000 (10:21 +0200)]
devices: vhost API cleanup

Use consistent API types.

Type: fix

Change-Id: I2dec594cb834a45004edc9ca58ad7c7b4bd7ff06
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agoquic: Add aggregated quicly stats 16/23916/3
Nathan Skrzypczak [Tue, 10 Dec 2019 12:40:46 +0000 (13:40 +0100)]
quic: Add aggregated quicly stats

Type: feature

Change-Id: Ice8de7030a0330cfe77a58657701f0703e0695dd
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
4 years agoquic: add more detailed statistics 52/23852/5
MathiasRaoul [Fri, 6 Dec 2019 15:38:56 +0000 (15:38 +0000)]
quic: add more detailed statistics

Type: feature

Change-Id: I3df7b054ec08c7b307413d24468fc3df6a5aacc3
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
4 years agodevices: tap API cleanup 06/21706/19
Jakub Grajciar [Tue, 3 Sep 2019 08:40:01 +0000 (10:40 +0200)]
devices: tap API cleanup

Use consistent API types.

Type: fix

Change-Id: I11cc7f6347b7a60e5fd41e54f0c7994e2d81199f
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agoipsec: Init salt value in SA creation CLI (so it's not random) 96/23896/2
Neale Ranns [Tue, 10 Dec 2019 01:08:19 +0000 (01:08 +0000)]
ipsec: Init salt value in SA creation CLI (so it's not random)

Type: fix

Change-Id: Idf4d0b59a1eb2c739a67a4786470884050f81561
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoquic: removing quicly_send call from quic_accept_connection 54/23654/4
MathiasRaoul [Wed, 27 Nov 2019 14:44:57 +0000 (14:44 +0000)]
quic: removing quicly_send call from quic_accept_connection

Type: fix

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I429b50b88c8e029b06854c7433d0bc77619e98a3

4 years agoapi: pass api and client main to rx thread 95/23895/4
Florin Coras [Tue, 10 Dec 2019 00:42:50 +0000 (16:42 -0800)]
api: pass api and client main to rx thread

Type: fix

Change-Id: Ib8313e87a89c80045edd897924917a88b98d1937
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agoioam: use explicit api types 80/23880/2
Ole Troan [Mon, 9 Dec 2019 13:25:09 +0000 (14:25 +0100)]
ioam: use explicit api types

Also remove API boilerplate.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I62e795f5af3843af7912707ade4ba178ff326942

4 years agoip: use explicit types in api 87/23887/2
Ole Troan [Mon, 9 Dec 2019 15:08:27 +0000 (16:08 +0100)]
ip: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1fd190da28a765ba430952539c291a741aaa3dce

4 years agoflowprobe: use explicit types in api 83/23883/2
Ole Troan [Mon, 9 Dec 2019 14:51:44 +0000 (15:51 +0100)]
flowprobe: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I4f1cccca7de0c07cee472bde80cd6b0ef60046bd

4 years agoapi: multiple connections per process 56/23656/6
Dave Barach [Wed, 27 Nov 2019 16:42:13 +0000 (11:42 -0500)]
api: multiple connections per process

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I2272521d6e69edcd385ef684af6dd4eea5eaa953

4 years agovlib: improve test coverage 89/23889/2
Dave Barach [Mon, 9 Dec 2019 15:45:47 +0000 (10:45 -0500)]
vlib: improve test coverage

Add tests.
Remove unused rule-based parser code.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I3ca3a9dd9da8ee8f3a47004c98f2f5644db10057

4 years agoapi: fix sock reg passing on read event 60/23860/6
Florin Coras [Sat, 7 Dec 2019 01:05:08 +0000 (17:05 -0800)]
api: fix sock reg passing on read event

Type: fix

Change-Id: I383242e04a114b69fe247d912842be3560e96c10
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agoipsec: make sure pad_bytes does not exceed pad data size 63/23863/2
Benoît Ganne [Sat, 7 Dec 2019 16:14:27 +0000 (09:14 -0700)]
ipsec: make sure pad_bytes does not exceed pad data size

This helps GCC understand the memcpy will not overflow pad_data. GCC-6
(default on Debian 9) in particular got confused.

Type: fix

Change-Id: I176eb01531b9d5c7ebec40f015e510b2d56e77c4
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agomarvell: use explicit types in api 65/23865/2
Ole Troan [Sun, 8 Dec 2019 12:30:30 +0000 (13:30 +0100)]
marvell: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1af842f38f90d3ede971da74cd28179b61f613cf

4 years agogtpu: use explicit types in api 66/23866/2
Ole Troan [Sun, 8 Dec 2019 13:14:37 +0000 (14:14 +0100)]
gtpu: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I16fcbd5e63526dbf062a3032701479324fe2a4f5

4 years agol3xc: use explicit types in api 68/23868/2
Ole Troan [Sun, 8 Dec 2019 15:09:47 +0000 (16:09 +0100)]
l3xc: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia94eab60689a07de522b8106dd48ff6b669bc770

4 years agoip: coverity fix 38/23838/2
johny [Fri, 6 Dec 2019 12:58:35 +0000 (13:58 +0100)]
ip: coverity fix

Delete Null-checking "p0" in function ip6_tcp_udp_icmp_bad_length,
because it's not necessary.

Type: fix

Signed-off-by: johny <jan.cavojsky@pantheon.tech>
Change-Id: I2bf43a60c1c1d76e42581df27f2285c9e9563093

4 years agolacp: use explit api types 26/23826/2
Ole Troan [Fri, 6 Dec 2019 09:00:47 +0000 (10:00 +0100)]
lacp: use explit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3f19c69a6f6282a97fd591adcd1e4490cf21e743

4 years agolacp: fix control_ping from plugins 59/23859/2
Ole Troan [Fri, 6 Dec 2019 23:39:49 +0000 (00:39 +0100)]
lacp: fix control_ping from plugins

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I030f75234a346ef6a20640c1a0ed65f4934867f2

4 years agostn: use explicit types in api 42/23842/2
Ole Troan [Fri, 6 Dec 2019 13:42:17 +0000 (14:42 +0100)]
stn: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifba4ff0e0f61641ca3f5e7bb72086cb4f32f1909

4 years agovmxnet3: use explicit types in api 45/23845/2
Ole Troan [Fri, 6 Dec 2019 13:55:38 +0000 (14:55 +0100)]
vmxnet3: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2e699fc812c45f88e359f0f7231f372955e70149

4 years agovlib: use explicit types in api 47/23847/2
Ole Troan [Fri, 6 Dec 2019 14:06:49 +0000 (15:06 +0100)]
vlib: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib3a5d9fc36692553eb109976e9365dc7d82911ab

4 years agomap: use explicit types in api 46/23846/2
Ole Troan [Fri, 6 Dec 2019 14:03:42 +0000 (15:03 +0100)]
map: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8f01f9e71c788fbca989d43d5b87da9c33fba0b1

4 years agosvs: use explicit types in api 44/23844/2
Ole Troan [Fri, 6 Dec 2019 13:50:51 +0000 (14:50 +0100)]
svs: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ic9570fca7e434c9b861be8ed064503492225f9fd

4 years agopppoe: use explicit types in api 41/23841/3
Ole Troan [Fri, 6 Dec 2019 13:23:10 +0000 (14:23 +0100)]
pppoe: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifd1e1907740e55420dc040eb2afbbbf9887aea3c

4 years agoquic: update quicly to v0.0.7-vpp 79/23679/5
MathiasRaoul [Thu, 28 Nov 2019 11:04:59 +0000 (11:04 +0000)]
quic: update quicly to v0.0.7-vpp

Type: feature

Change-Id: Ieeb9abb59b4d094bbd7bfc04a9007d3cebd645d7
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
4 years agoapi: avoid swapping vlib_rp before barrier sync 59/23659/11
Florin Coras [Wed, 27 Nov 2019 17:15:25 +0000 (09:15 -0800)]
api: avoid swapping vlib_rp before barrier sync

Type: fix

Change-Id: I9868d13e827c6f5aa5535a38f629efb62ff12dbc
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agogso: fix the tap/virtio driver for header offset 48/23848/3
Mohsin Kazmi [Fri, 6 Dec 2019 14:47:48 +0000 (15:47 +0100)]
gso: fix the tap/virtio driver for header offset

Type: fix

Change-Id: Ied34466907fa8ad44f997c600dbf481be4d22027
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agoapi: fix free socket process args 22/23822/3
Florin Coras [Fri, 6 Dec 2019 04:10:53 +0000 (20:10 -0800)]
api: fix free socket process args

Type: fix

Change-Id: I910be067de6ed65790d25cc95a3d8b5b66680567
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agomactime: update api to use explicit types 25/23825/2
Ole Troan [Fri, 6 Dec 2019 08:55:45 +0000 (09:55 +0100)]
mactime: update api to use explicit types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id347e77d0230bf1b22df75bf1ae63a50eaf4d564

4 years agol2e: use explicit api types 27/23827/2
Ole Troan [Fri, 6 Dec 2019 09:05:29 +0000 (10:05 +0100)]
l2e: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1888a8247ef03cfb715a2c0e0e3ca2a108fecbc8

4 years agodpdk: use explicit types in api 34/23834/2
Ole Troan [Fri, 6 Dec 2019 12:20:43 +0000 (13:20 +0100)]
dpdk: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iff7e995499e422003147342ff14de483d807b3f3

4 years agoct6: use explicit type in api 33/23833/2
Ole Troan [Fri, 6 Dec 2019 12:19:01 +0000 (13:19 +0100)]
ct6: use explicit type in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2342baa91234db1336394305c031dbfa21d219a5

4 years agocdp: use explicit types in api 32/23832/2
Ole Troan [Fri, 6 Dec 2019 12:17:17 +0000 (13:17 +0100)]
cdp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If50e66638554e0fcfc72d35a89a39379dfcb530d

4 years agoabf: use explicit types in api 31/23831/3
Ole Troan [Fri, 6 Dec 2019 12:16:21 +0000 (13:16 +0100)]
abf: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I9462de3d27b88539bff87c07a59987dd62fb2add

4 years agoigmp: use explicit types in api 36/23836/2
Ole Troan [Fri, 6 Dec 2019 12:33:35 +0000 (13:33 +0100)]
igmp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifdb623c092cf0a9d9e24117edc32c6ddf014052f

4 years agoikev2: use explicit api types 37/23837/2
Ole Troan [Fri, 6 Dec 2019 12:37:51 +0000 (13:37 +0100)]
ikev2: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2171ef678ecad12d681668257498a5a62004152f

4 years agonsh: use explicit api types 39/23839/2
Ole Troan [Fri, 6 Dec 2019 13:01:16 +0000 (14:01 +0100)]
nsh: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8fd870e757e9243d4f0916dfbbe65495f7e1a8c6

4 years agonsim: use explicit api types 40/23840/2
Ole Troan [Fri, 6 Dec 2019 13:05:07 +0000 (14:05 +0100)]
nsim: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icdc359beb127944418305775e42fa88c569dfbd7

4 years agoapi: multiple socket connections per single process 33/23633/7
Florin Coras [Mon, 25 Nov 2019 21:40:42 +0000 (13:40 -0800)]
api: multiple socket connections per single process

Type: feature

Change-Id: Idea1857eb2225881d2982a7aa2ae7a79536b3f33
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agosession: close for reset replies independent of state 21/23821/4
Florin Coras [Thu, 5 Dec 2019 20:05:57 +0000 (12:05 -0800)]
session: close for reset replies independent of state

Type: fix

Change-Id: I8b8875f1dc9203dfbb443ac43df8250cbb0b1edc
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotcp: fix tail rescue with sacks 83/23483/7
Florin Coras [Sat, 16 Nov 2019 01:56:48 +0000 (17:56 -0800)]
tcp: fix tail rescue with sacks

Type: fix

Change-Id: Iad73f47cef3d29c4b0b7d1f58f2f2b14ba4b1d38
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agotests: move bfd over gre to extended tests 07/23807/2
Paul Vinciguerra [Thu, 5 Dec 2019 04:38:12 +0000 (23:38 -0500)]
tests: move bfd over gre to extended tests

This test should be fixed or removed.
EXTENDED_TESTS should not become "BROKEN_TESTS"

Type: test

Change-Id: Id998f0d3b7bd31100f917d076fbd7ddb46d99ed2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agosrv6-mobile 20/23820/2
Tetsuya Murakami [Thu, 5 Dec 2019 18:42:34 +0000 (10:42 -0800)]
srv6-mobile

Type: fix

Plug-in for IPv6 Segment Routing Mobile

Fix the static analysis issue on srv6-mobile/gtp4_d function.

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I5c419b76a30c9616dc3557267fcceed0d512b67e

4 years agomap: fix MAP-T ip6 port check 00/23800/2
Matthew Smith [Wed, 4 Dec 2019 21:02:46 +0000 (15:02 -0600)]
map: fix MAP-T ip6 port check

Type: fix
Ticket: VPP-1804

Fix a regression introduced by 640edcd90.

The port set ID on received IPv6 packets for MAP-T was being
checked against the destination port. It should be checked
against the source port.

Added a new unit test to verify that a v6 packet with a good
source port is translated and forwarded and a v6 packet with
a bad source port is dropped. The important part of the test
which will prevent similar future regressions is that the
source port and destination port are not equal. The existing
unit test used the same source and destination port which is
why it did not fail when the regression was introduced.

Change-Id: Idc144ea509722bb9e0f80b3887d220384a04e6d6
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
4 years agotests: quic enable per testcase timeout overrides 06/23806/4
Paul Vinciguerra [Thu, 5 Dec 2019 04:18:02 +0000 (23:18 -0500)]
tests: quic enable per testcase timeout overrides

Type: test

Change-Id: I4f8aee3efa53d58f96631fe2d2da5756304fb75a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoclassify: vpp packet tracer support 01/23801/2
Dave Barach [Wed, 4 Dec 2019 22:19:12 +0000 (17:19 -0500)]
classify: vpp packet tracer support

Configure n-tuple classifier filters which apply to the vpp packet
tracer.

Update the documentation to reflect the new feature.

Add a test vector.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Iefa911716c670fc12e4825b937b62044433fec36

4 years agoip: fix cancel termination after receive malformed ip6 packet 83/22683/7
johny [Fri, 11 Oct 2019 16:28:51 +0000 (18:28 +0200)]
ip: fix cancel termination after receive malformed ip6 packet

This fix is for cancel termination of vpp after receive malformed
packet type of ip6.To avoid termination of vpp are checked if are
missing data in packet. This occours, when payload length in ip6
header packet is more than real count of data in packet. When
this error occours, packet is ignore.

Type: fix
Ticket: VPP-1693, VPP-1694

Change-Id: I9d9ecea7b75c8702cb31aa8051c8d4d7ce19659d
Signed-off-by: johny <jan.cavojsky@pantheon.tech>