vpp.git
5 years agoAdd psutil to testing virtualenv 01/14301/3
juraj.linkes [Fri, 17 Aug 2018 06:42:40 +0000 (08:42 +0200)]
Add psutil to testing virtualenv

Change-Id: I650c9f226bcdc6328a7b4ff2dc4bd20cea8a512a
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>
5 years agooptimize init_server to reduce session overhead 56/14156/7
Ping Yu [Mon, 13 Aug 2018 10:20:00 +0000 (06:20 -0400)]
optimize init_server to reduce session overhead

move un-necessary session based operation to listener
split orignal openssl ctx to be session based ctx and listen ctx

Change-Id: Id6c54f47b0e2171fd8924a45efcd5266ce5402d5
Signed-off-by: Ping Yu <ping.yu@intel.com>
5 years agotls: add maintainers 93/14293/2
Florin Coras [Thu, 16 Aug 2018 16:29:36 +0000 (09:29 -0700)]
tls: add maintainers

Change-Id: I948739642f8fe0b6219ffcd8232a9ad486cabc4b
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agovlibapi: validate private segment rotor prior to use 99/14299/2
Florin Coras [Thu, 16 Aug 2018 22:45:34 +0000 (15:45 -0700)]
vlibapi: validate private segment rotor prior to use

If the dead client scan removes the rotor position we're about to check
next, we end up outside the private registration pool's bounds.

Change-Id: If4e715593deeac4c06ae6b3fededc1965b042094
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agovcl: unset fifo events only in read/write 98/14298/5
Florin Coras [Thu, 16 Aug 2018 21:57:31 +0000 (14:57 -0700)]
vcl: unset fifo events only in read/write

Avoids accumulation of io event messages when the receiver is slow to
read.

Change-Id: I3a713d339a6ac0781c010be1fbad5a7963ab02c6
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agofix compiling warnings with GCC 44/14244/2
Lijian Zhang [Tue, 7 Aug 2018 03:11:58 +0000 (11:11 +0800)]
fix compiling warnings with GCC

GCC 7 plus Ubuntu-16.04 default ccache 3.2.4 reports warnings on switch case fall-through code,
which is commonly seen in DPDK code, which will cause image building failure finally.
It requires newer ccache version to support -Wimplicit-fallthrough.
To suppress the warning, if GCC is version 7 or higher, and it's old ccache version,
will disable the fall-through check.

dpdk-18.05/drivers/net/ark/ark_ethdev_rx.h:39:0,
                  from dpdk-18.05/drivers/net/ark/ark_ethdev_rx.c:36:
dpdk-18.05/arm64-armv8a-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_pktmbuf_alloc_bulk’:
dpdk-18.05/arm64-armv8a-linuxapp-gcc/include/rte_mbuf.h:1292:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
     idx++;
     ~~~^~

Change-Id: I4d12492471fadef9d349ba9e853a6799512f76f5
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
5 years agoFix a segment fault issue in TLS 90/14290/1
Ping Yu [Thu, 16 Aug 2018 23:11:05 +0000 (19:11 -0400)]
Fix a segment fault issue in TLS

The root cause is it uses a dangling reference after memory move
Need to call session_alloc first, then use index to get the app
listener point

Change-Id: If5b7e0d6ddc761e5327660c47ce620e375319b4d
Signed-off-by: Ping Yu <ping.yu@intel.com>
5 years agoEdit some warning messages in vpp-api client 75/14275/2
Ondrej Fabry [Thu, 16 Aug 2018 06:36:19 +0000 (08:36 +0200)]
Edit some warning messages in vpp-api client

- fix one typo: cnacel -> cancel
- edit log about returned value to be consistent with others

Change-Id: I09560eee8a9da361fa51e35f316d44361292bdb2
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
5 years agodpdk: fix rss hash function handling 86/14286/2
Damjan Marion [Thu, 16 Aug 2018 11:24:30 +0000 (13:24 +0200)]
dpdk: fix rss hash function handling

DPDK 18.08 verifies if all set bits are supported and fails if not....

Change-Id: Ia87242fcda11147dff3bebe2e2bef32f0a8891fb
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoVPP-1386: fix wrong ip address of hash key for creating user in unknown protocol 50/14150/2
shubing guo [Sat, 11 Aug 2018 06:34:31 +0000 (14:34 +0800)]
VPP-1386: fix wrong ip address of hash key for creating user in unknown protocol

Change-Id: I6239e930a8805207f8e42d15e8b17d444047e3f3
Signed-off-by: shubing guo <guo.shubing@zte.com.cn>
5 years agotcp: add tcp_error.def to installed headers list 78/14178/2
Florin Coras [Mon, 13 Aug 2018 06:55:58 +0000 (23:55 -0700)]
tcp: add tcp_error.def to installed headers list

Change-Id: I38351900bad9d727e7df6117597da488dbf5e12c
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoRemove client_index field from replies in API 40/14240/3
Ondrej Fabry [Wed, 15 Aug 2018 06:46:46 +0000 (08:46 +0200)]
Remove client_index field from replies in API

- replies should not need to contain client_index since
  it is used to identify sender of requests to VPP

Change-Id: Iece3853b3f020054ee1652b149d0cf8d9580db4e
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
5 years agoNAT44: fix next_src_nat (VPP-1384) 04/14204/2
Matus Fabian [Tue, 14 Aug 2018 11:21:26 +0000 (04:21 -0700)]
NAT44: fix next_src_nat (VPP-1384)

Use rx_fib_index instead of sm->inside_fib_index for session lookup key.

Change-Id: I2d6cce5b9376fa8ac4d75a9bbfa8498be0fd1493
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 years agoVPP-1387:foreach outside address vector to find correct index when free outside addre... 65/14165/2
shubing guo [Mon, 13 Aug 2018 09:16:46 +0000 (17:16 +0800)]
VPP-1387:foreach outside address vector to find correct index when free outside address and port

Change-Id: Ie5452350a8ebe2c1b62085fcab50dbc0138d3ae2
Signed-off-by: shubing guo <guo.shubing@zte.com.cn>
5 years agoNAT44: fix bug in snat_interface_add_del (VPP-1380) 06/14106/2
Matus Fabian [Thu, 9 Aug 2018 12:15:19 +0000 (05:15 -0700)]
NAT44: fix bug in snat_interface_add_del (VPP-1380)

Should not enable nat44-hairpinning node in deterministic mode

Change-Id: I5790323a6842ee71a62c6c91c49166a2839eac12
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 years agoNAT64: fix TCP session expire (VPP-1390) 07/14207/2
Matus Fabian [Tue, 14 Aug 2018 12:14:55 +0000 (05:14 -0700)]
NAT64: fix TCP session expire (VPP-1390)

Add missing call of nat64_tcp_session_set_state to set TCP session state.

Change-Id: Ifd297ea3ffe20870e1e34a95449b5c9404ec13eb
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 years agoFix context field position in API definition 02/14202/2
Ondrej Fabry [Tue, 14 Aug 2018 10:39:40 +0000 (12:39 +0200)]
Fix context field position in API definition

- context should be first field for reply messages,
  just like it is for all other 545 replies

Change-Id: Ib291036d3389dbc26c8e9194966d01cab81534aa
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
5 years agoRun interior graph nodes before process nodes 22/14222/2
Dave Barach [Tue, 14 Aug 2018 17:47:58 +0000 (13:47 -0400)]
Run interior graph nodes before process nodes

Reduces the chance of tripping over vectors in flight, especially in
single-core cases.

Change-Id: I132cdd3689f8e634f9a983af57219503817b8560
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoMake vagrant work behind a proxy 48/14148/2
Kyle Mestery [Fri, 10 Aug 2018 21:32:13 +0000 (16:32 -0500)]
Make vagrant work behind a proxy

Without this change, I cannot get the in-tree VPP Vagrant to work behind
a proxy. This commit fixes that by ensuring when we run sudo we're passing
environment variables, amongst some other cleanups.

Change-Id: Ica98a1238d40e6e6ccf80c472f52559c95af52f0
Signed-off-by: Kyle Mestery <mestery@mestery.com>
5 years agoDOCS: Moved multiarch and build system, Incorprated Scott's changes 39/14239/2
John DeNisco [Tue, 14 Aug 2018 20:04:09 +0000 (16:04 -0400)]
DOCS: Moved multiarch and build system, Incorprated Scott's changes

Change-Id: I5a57846db2d4faac1aa24db4629b612657f59afb
Signed-off-by: John DeNisco <jdenisco@cisco.com>
5 years agoDOCS: Updated startup.conf parameters 09/14209/2
andrew [Tue, 14 Aug 2018 13:35:42 +0000 (09:35 -0400)]
DOCS: Updated startup.conf parameters

Change-Id: Id1f4ff7409e8a833b8f7e6030d7287d8c1274c2d
Signed-off-by: andrew <andrew.olechtchouk@gmail.com>
5 years agoreduce polling and resume overhead by checking if inflight request exists 63/14163/3
Ping Yu [Mon, 13 Aug 2018 14:26:26 +0000 (10:26 -0400)]
reduce polling and resume overhead by checking if inflight request exists

Change-Id: I0777a00f0cc082bab3348be8ec0be39faa50ffed
Signed-off-by: Ping Yu <ping.yu@intel.com>
5 years agoneighbor advertisement must with target_link option 87/14187/3
ahdj007 [Tue, 14 Aug 2018 02:35:43 +0000 (10:35 +0800)]
neighbor advertisement must with target_link option

Change-Id: Ic20eea8f2fd19dd3c1728a1f7c622ef0c9728f81
Signed-off-by: ahdj007 <dong.juan1@zte.com.cn>
5 years agoDOCS: Cleanup Getting Started 84/14184/1
John DeNisco [Mon, 13 Aug 2018 21:00:06 +0000 (17:00 -0400)]
DOCS: Cleanup Getting Started

Change-Id: I4766773779f8d5c30a24bfed48090d7305c80ec5
Signed-off-by: John DeNisco <jdenisco@cisco.com>
5 years agoclassify_add_del_session API: Use more descriptive docstring (VPP-1385) 43/14143/2
Juraj Sloboda [Fri, 10 Aug 2018 19:23:02 +0000 (21:23 +0200)]
classify_add_del_session API: Use more descriptive docstring (VPP-1385)

Change-Id: I30788c0dd1ee012e786bb3127bf2743ab0bfdc70
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
5 years agoMultiarch for ip4 forwarding nodes 52/14152/3
Damjan Marion [Sat, 11 Aug 2018 20:10:29 +0000 (22:10 +0200)]
Multiarch for ip4 forwarding nodes

Change-Id: I68b55fc641da9dacc3343628b3e0cf77d3533313
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoMultiarch handling in different constructor macros 47/14147/8
Damjan Marion [Fri, 10 Aug 2018 20:39:11 +0000 (22:39 +0200)]
Multiarch handling in different constructor macros

This significantly reduces need for

...

in multiarch code. Simply constructor macros will jost create static unused
entry if CLIB_MARCH_VARIANT is defined and that will be optimized out by
compiler.

Change-Id: I17d1c4ac0c903adcfadaa4a07de1b854c7ab14ac
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agodpdk: support for DPDK 18.08 53/14153/2
Damjan Marion [Sat, 11 Aug 2018 22:26:45 +0000 (00:26 +0200)]
dpdk: support for DPDK 18.08

Change-Id: If1b93341c222160b9a08f127620c024620e55c37
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoVPP-1381: Fix the incorrect if condition when delete session for static mapping 23/14123/2
shubing guo [Fri, 10 Aug 2018 05:59:50 +0000 (13:59 +0800)]
VPP-1381: Fix the incorrect if condition when delete session for static mapping
-- The session should not be deleted when either ip address or port doesn't same with static mapping.

Change-Id: I09ab7379947654d2780a8c40c5340ce430541b12
Signed-off-by: shubing guo <guo.shubing@zte.com.cn>
5 years agoMultiversioning: Device (tx) function constructor 54/13654/4
Mohsin Kazmi [Mon, 23 Jul 2018 12:45:57 +0000 (14:45 +0200)]
Multiversioning: Device (tx) function constructor

Change-Id: I39f87ca161c891fb22462a23188982fef7c3243f
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
5 years agoavf: fix prefetch bug 46/14146/2
Damjan Marion [Fri, 10 Aug 2018 20:36:13 +0000 (22:36 +0200)]
avf: fix prefetch bug

Change-Id: I4e774dc53b08746cd4ab42393f33676dcc78e791
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoemacs skeletons: add quad/single, avx2/avx512 support 45/14145/2
Dave Barach [Fri, 10 Aug 2018 20:22:48 +0000 (16:22 -0400)]
emacs skeletons: add quad/single, avx2/avx512 support

Change-Id: Ib8095ad69620308d6199ab030a754ee45f92e59b
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoIP fragmentation buffer chains, part 2. 39/14139/4
Ole Troan [Fri, 10 Aug 2018 12:39:48 +0000 (14:39 +0200)]
IP fragmentation buffer chains, part 2.

Change-Id: I8d1072cf9ff9f502302fd906c5590e0f3698dc60
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agovcl: support for eventfd mq signaling 22/13922/25
Florin Coras [Thu, 2 Aug 2018 17:45:44 +0000 (10:45 -0700)]
vcl: support for eventfd mq signaling

- support eventfd based mq signaling. Based on configuration, vcl
epoll/select can use either condvars or epoll on mq eventfds.
- add vcl support for memfd segments
- vpp explicitly registers cut-through segments with apps/vcl
- if using eventfd, make ldp allow one call to libc_epoll_create. Needed
for the message queue epfd
- update svm_queue_t to allow blocking calls with eventfd signaling.

Change-Id: I064151ac370bbe29bb16c968bf4e3659c8286bea
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoDOC-ONLY: document latest multi-arch support scheme 42/14142/1
Dave Barach [Fri, 10 Aug 2018 15:05:52 +0000 (11:05 -0400)]
DOC-ONLY: document latest multi-arch support scheme

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I613415c109f648248ee04dd76d5e652dbf21bc7f

5 years agoDOC-ONLY: build system details 20/14120/4
Dave Barach [Thu, 9 Aug 2018 20:12:20 +0000 (16:12 -0400)]
DOC-ONLY: build system details

The tables need some TLC from someone familiar with making pretty
tables.

Fixed text-wrapping onto newlines for all tables in our docs.
Changed Environment Variables to ENV Variables so that the specific
column header fits properly.

Change-Id: Ie758612e561eefe44e771dac63b63bf026a52c2d
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agodocs: A little cleanup and added some gdb examples. 57/13957/4
andrew [Mon, 6 Aug 2018 04:25:33 +0000 (00:25 -0400)]
docs: A little cleanup and added some gdb examples.
docs: Added section on running VPP for developers.

Change-Id: I98b5c6f1c9fee60b297e3947e78ec33f950f598a
Signed-off-by: andrew <andrew.olechtchouk@gmail.com>
5 years agoIP fragmentation to handle buffer chains. 91/14091/2
Ole Troan [Wed, 8 Aug 2018 20:23:19 +0000 (22:23 +0200)]
IP fragmentation to handle buffer chains.

Change-Id: Iff557f566ebc9ab170d75da1233997d83b8c8a66
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agoVPP-1382: Fix ip6 address cann't display completely when show ip6 neighbors 32/14132/2
shubing guo [Fri, 10 Aug 2018 07:51:44 +0000 (15:51 +0800)]
VPP-1382: Fix ip6 address cann't display completely when show ip6 neighbors

Change-Id: Iadfbe3c0d0c6dcec2b4ccf1695bd234358f6969a
Signed-off-by: shubing guo <guo.shubing@zte.com.cn>
5 years agoUse IP address types on UDP encap API 53/14053/6
Neale Ranns [Wed, 8 Aug 2018 08:06:40 +0000 (01:06 -0700)]
Use IP address types on UDP encap API

Change-Id: I3c714c519b6d0009329b50947ce250c18ee2a85a
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agoAdd test of the IP unnumbered dump 86/14086/2
Neale Ranns [Wed, 8 Aug 2018 13:37:33 +0000 (06:37 -0700)]
Add test of the IP unnumbered dump

Change-Id: Ic3e978faf58b43adb8a9fd0dea36eb4513fe0c64
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
5 years agoUse the bihash walk function 10/14010/3
Neale Ranns [Tue, 7 Aug 2018 09:54:31 +0000 (02:54 -0700)]
Use the bihash walk function

... rather than re-implementing the loop

Change-Id: I20bede8403c804cbec654db9b7020a4d01e5bc18
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
5 years agoDOCS: General cleanup (did not move any sections) 15/14115/3
andrew [Thu, 9 Aug 2018 17:23:59 +0000 (13:23 -0400)]
DOCS: General cleanup (did not move any sections)

Change-Id: I67cc42769661c10d2793f8c6cdb3b232b803d145
Signed-off-by: andrew <andrew.olechtchouk@gmail.com>
5 years agoDOCS: modified writing docs section 14/14114/2
javierfernandezvalles [Thu, 9 Aug 2018 15:54:55 +0000 (08:54 -0700)]
DOCS: modified writing docs section

Change-Id: Ic3ec16dba1a6374785f25f622b2cdc9b6415a13b
Signed-off-by: javierfernandezvalles <JaviervallesF@gmail.com>
5 years agoDOCS: Restructure Events 73/14073/2
John DeNisco [Wed, 8 Aug 2018 11:36:50 +0000 (07:36 -0400)]
DOCS: Restructure Events

Change-Id: I135ced20b58cdb72fbd0784015af037bb6e7ad28
Signed-off-by: John DeNisco <jdenisco@cisco.com>
5 years agoFix L2 flooding to BVI with error return not working 12/14112/2
John Lo [Thu, 9 Aug 2018 15:03:21 +0000 (11:03 -0400)]
Fix L2 flooding to BVI with error return not working

Change-Id: Id0b0e9bf1a7ba02144ec75783378352423f7a4b9
Signed-off-by: John Lo <loj@cisco.com>
5 years agoThread-safe ARP / ND throttling 92/14092/3
Dave Barach [Wed, 8 Aug 2018 21:59:03 +0000 (17:59 -0400)]
Thread-safe ARP / ND throttling

Change-Id: I810d834c407bd404d5f0544cdec0674f0bb92d31
Signed-off-by: Dave Barach <dave@barachs.net>
Signed-off-by: Dave Barach <dbarach@cisco.com>
5 years agoacl-plugin: fix failures in some of IPv4 test-debug testcases 08/14108/2
Andrew Yourtchenko [Thu, 9 Aug 2018 13:30:57 +0000 (15:30 +0200)]
acl-plugin: fix failures in some of IPv4 test-debug testcases

Commit 1c7bf5d41737984907e8bad1dc832eb6cb1d6288 added the poisoning
of the newly freed memory in debug builds, exposing a logic
error in mask assignment code - it passed a pointer to
within a pool to a function which might potentially expand the pool.

This resulted in a failure of the test in the debug version.

Fix that by making a local copy of the value before passing
a pointer to it.

Change-Id: I73f3670672c3d86778aad0f944d052d0480cc593
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agoFix the fifo-size limitation in tcp_echo 93/14093/3
Yalei Wang [Thu, 9 Aug 2018 02:09:38 +0000 (10:09 +0800)]
Fix the fifo-size limitation in tcp_echo

Correct the size verification when send_test_chuck, tcp send process
will not be broken when avalable fifo queue size less then the
min_chuck.

Change-Id: Ide13169283c0311cf2fb18d2606bc869065a2a1b
Signed-off-by: Yalei Wang <william.wangyalei@huawei.com>
5 years agoPAPI: Python 3.7 uses async keyword. 05/14105/2
Ole Troan [Thu, 9 Aug 2018 10:50:55 +0000 (12:50 +0200)]
PAPI: Python 3.7 uses async keyword.

Change-Id: I01e99c85598a7cb5bc1a506c7fd1fc3f6789d72e
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agoNAT44: delete user with zero sessions (VPP-1282) 84/14084/2
Matus Fabian [Wed, 8 Aug 2018 12:52:47 +0000 (05:52 -0700)]
NAT44: delete user with zero sessions (VPP-1282)

Change-Id: I756e3ad3de9ffe1494221ef95c1943c8591f8f50
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 years agobfd:fix NULL session free/put 04/14104/2
Eyal Bari [Thu, 9 Aug 2018 09:50:08 +0000 (12:50 +0300)]
bfd:fix NULL session free/put

Change-Id: If9f1f8c16c098c453bb53591e50a4cbd7cb192e4
Signed-off-by: Eyal Bari <ebari@cisco.com>
5 years agoFix "Old Style VLA" build warnings 07/13007/8
Juraj Sloboda [Tue, 12 Jun 2018 12:20:49 +0000 (14:20 +0200)]
Fix "Old Style VLA" build warnings

Change-Id: I8d42f6ed58ec34298d41edcb3d783e7e9ded3eec
Signed-off-by: Juraj Sloboda <jsloboda@cisco.com>
5 years agofix typo in bitmap.h 61/14061/2
Korian Edeline [Wed, 8 Aug 2018 09:30:30 +0000 (11:30 +0200)]
fix typo in bitmap.h

Change-Id: I11587fc382a529cfd9c0971cc2ad59cd97dd6a13
Signed-off-by: Korian Edeline <korian.edeline@ulg.ac.be>
5 years agoRemove unnecessary routes during vrf-multi-instances tests 74/14074/2
Neale Ranns [Wed, 8 Aug 2018 11:48:10 +0000 (04:48 -0700)]
Remove unnecessary routes during vrf-multi-instances tests

Change-Id: I0a7fd0df90eff522366cb55ad224fe24a3121e56
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
5 years agoDOC ONLY: Add a new doc for integrating a plugin with VPP 56/13956/5
andrew [Mon, 6 Aug 2018 01:18:45 +0000 (21:18 -0400)]
DOC ONLY: Add a new doc for integrating a plugin with VPP

Convert doxygen docs (vpp api module and binary api support) to .rst

Added a brief explanation of binary api message numbering for plugins

Change-Id: If7d37f29aa65a884b51f3d27957f80d1357ed29b
Signed-off-by: andrew <andrew.olechtchouk@gmail.com>
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agodocs: Cleaned up a little removed instructions for mac. 89/13989/5
andrew [Mon, 6 Aug 2018 21:40:31 +0000 (17:40 -0400)]
docs: Cleaned up a little removed instructions for mac.

docs: Updated section on using git-review

Change-Id: I180f67e3478b57b1de03df95fc67a0cfdd44dfb5
Signed-off-by: andrew <andrew.olechtchouk@gmail.com>
5 years agoDOC ONLY: document bihash table walker rules 31/14031/1
Dave Barach [Tue, 7 Aug 2018 19:26:08 +0000 (15:26 -0400)]
DOC ONLY: document bihash table walker rules

Change-Id: I0c48e0f4b87065d8f42009e2cc9709c6b7f5e851
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoFix dangling reference in l2fib_scan(...) 28/14028/2
Dave Barach [Tue, 7 Aug 2018 16:46:18 +0000 (12:46 -0400)]
Fix dangling reference in l2fib_scan(...)

Deleting a bihash kvp frees the bucket's backing storage when the
bucket reference count reaches zero. l2fib_scan MUST check for that
condition, and stop scanning the bucket if it occurs. One of the L2
FIB extended "make test" vectors caused this issue 100% of the time.

Change-Id: I250bcc4c1518e16042120fbc4032227a759a602e
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoapi: compute msg table for private registrations 93/13993/2
Florin Coras [Mon, 6 Aug 2018 19:19:29 +0000 (12:19 -0700)]
api: compute msg table for private registrations

Change-Id: Ibaa236c09c2eeea72ee8a8cc603d407217b4af23
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoPAPI: Move unit tests to fix packaging issues. 05/14005/2
Ole Troan [Tue, 7 Aug 2018 07:27:26 +0000 (09:27 +0200)]
PAPI: Move unit tests to fix packaging issues.

Change-Id: I67a0f168254367c657eb11d4413f9dc0c5356b3c
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agodlmalloc compiles errors with clang 79/13979/2
Neale Ranns [Mon, 6 Aug 2018 12:16:29 +0000 (08:16 -0400)]
dlmalloc compiles errors with clang

of the form:
/home/nranns/Src/vpp/build-data/../src/vppinfra/dlmalloc.c:4327:7: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses]
  if (!(ms)->magic == mparams.magic) {
/home/nranns/Src/vpp/build-data/../src/vppinfra/dlmalloc.c:4696:20: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
  if (((ms)->magic == mparams.magic)) {

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.2 LTS
Release:        16.04
Codename:       xenial

$ clang --version
clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

Change-Id: If6d70a87420bd54c8e1b8be1d9e9031f6c699c45
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agore-indent UDP encap documentation 80/13980/3
Neale Ranns [Mon, 6 Aug 2018 13:09:24 +0000 (09:09 -0400)]
re-indent UDP encap documentation

Change-Id: Ieb53860769f511205bcd3f1605e76a80e65d4939
Signed-off-by: Neale Ranns <nranns@cisco.com>
5 years agodpdk-flow:fix raw item init 54/13954/2
Eyal Bari [Sun, 5 Aug 2018 09:58:42 +0000 (12:58 +0300)]
dpdk-flow:fix raw item init

dpdk raw item match string changed from flexible array member to a
pointer member

Change-Id: I930f05112ce04b0cdb3feb985d755e730b102084
Signed-off-by: Eyal Bari <ebari@cisco.com>
5 years agofix dangling reference in foreach_key_value_pair 78/13978/1
Dave Barach [Mon, 6 Aug 2018 12:43:47 +0000 (08:43 -0400)]
fix dangling reference in foreach_key_value_pair

When the user deletes the last entry in a bihash bucket, the bihash
infra frees the bucket's backing storage. If this happens under
clib_bihash_foreach_key_value_pair - and the freed bucket happens to
be the bucket being traversed - the resulting dangling reference can
easily make the wheels fall off.

Simple fix: if (bucket-is-now-empty) double-break.

Change-Id: Idc44247a82ed5d0ba548507b4a53d4c8503ba8bb
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agosocket api: multiple fds in one msg 50/13950/3
Florin Coras [Fri, 3 Aug 2018 09:50:43 +0000 (02:50 -0700)]
socket api: multiple fds in one msg

Change-Id: I77a6e092a42290eed7201ad4a62e0d00ef997d2b
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoAPI: Remove legacy vlibsocket code. 12/13912/4
Ole Troan [Thu, 2 Aug 2018 18:37:13 +0000 (20:37 +0200)]
API: Remove legacy vlibsocket code.

The API implementation now supports Unix domain sockets.
The vlibsocket code has not been included in builds for
a long time and is superfluous.

Change-Id: I67a773d0e86e2318eacecf33f82d075553146ee9
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agoAdded missing file 49/13949/3
John DeNisco [Fri, 3 Aug 2018 15:02:24 +0000 (11:02 -0400)]
Added missing file

docs: Incorporate Javier's progressive VPP tutorial

Change-Id: Iecee041039c7ed81713bc0530fc536e989c71497
Signed-off-by: John DeNisco <jdenisco@cisco.com>
5 years agoPAPI: Union pad at the end of short fields instead of at head. 11/13911/6
Ole Troan [Thu, 2 Aug 2018 17:19:21 +0000 (19:19 +0200)]
PAPI: Union pad at the end of short fields instead of at head.

Hopefully that's going to be consistent across platforms, compilers and ABI.

Change-Id: I0b82565288d88fd046278d4d8288ec1488273ba5
Signed-off-by: Ole Troan <ot@cisco.com>
5 years agoFix typo in trace trajectory init 42/13942/2
Dave Barach [Fri, 3 Aug 2018 13:28:47 +0000 (09:28 -0400)]
Fix typo in trace trajectory init

plugin won't compile if VLIB_BUFFER_TRACE_TRAJECTORY is set. The
quad loop was OK, bug in single loop only.

Change-Id: I11262bf6a223680eeac7ed23238ceda425a02c1b
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agoavf: add avf_create_reply_handler to avf_test 39/13839/2
Jakub Grajciar [Tue, 31 Jul 2018 08:05:04 +0000 (10:05 +0200)]
avf: add avf_create_reply_handler to avf_test

Change-Id: I2f376a777081da131110227e760ca0069438c918
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
5 years agoipsec: add udp-encap option to debug cli commands 27/13927/2
Radu Nicolau [Fri, 3 Aug 2018 09:37:24 +0000 (10:37 +0100)]
ipsec: add udp-encap option to debug cli commands

Change-Id: I3195afd952f6783da87224d7ceb9df13ddd39459
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
5 years agoloop counter to prevent infiinte number of look ups per-packet 77/13877/3
Neale Ranns [Wed, 1 Aug 2018 19:53:17 +0000 (12:53 -0700)]
loop counter to prevent infiinte number of look ups per-packet

Change-Id: I59235d11baac18785a4c90cdaf14e8f3ddf06dab
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
5 years agovlib: avoid double process dispatch 88/13888/4
Florin Coras [Wed, 1 Aug 2018 23:25:45 +0000 (16:25 -0700)]
vlib: avoid double process dispatch

Change-Id: I46467b1f149be9dfbd00e3ea6d60681d19acf235
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agosvm: add support for eventfd signaling to queue 80/13880/8
Florin Coras [Wed, 1 Aug 2018 14:53:18 +0000 (07:53 -0700)]
svm: add support for eventfd signaling to queue

Support the use of eventfds to signal queue updates between consumer
and producer pairs.

Change-Id: Idb6133be2b731fff78ed520daf9d2e0399642aab
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agodocs: Incororate Scott's overall review 13/13913/2
John DeNisco [Thu, 2 Aug 2018 19:03:15 +0000 (15:03 -0400)]
docs: Incororate Scott's overall review

Change-Id: Ic70a62e17891fa9291a5274400ae89f1d6194b6e
Signed-off-by: John DeNisco <jdenisco@cisco.com>
5 years agoDocumentation fix on "set interface ip[6] table" 21/13921/2
Yichen Wang [Fri, 3 Aug 2018 00:12:01 +0000 (17:12 -0700)]
Documentation fix on "set interface ip[6] table"

Change-Id: I8dc6230b65e57ddc07f974bf6726393d8dbfd4a2
Signed-off-by: Yichen Wang <yicwang@cisco.com>
5 years agoacl-plugin: fill in the 5tuple structure all at once, avoid short writes 93/13493/3
Andrew Yourtchenko [Mon, 16 Jul 2018 13:28:47 +0000 (15:28 +0200)]
acl-plugin: fill in the 5tuple structure all at once, avoid short writes

This change avoids the long-read-after-short-write, resulting
in a small performance improvement.

Change-Id: Ic01d1fd19182e96100ccaf441d7ab5e5898b9734
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agoTemporrary disable japi packaging for opensuse 17/13917/5
Damjan Marion [Thu, 2 Aug 2018 20:19:21 +0000 (22:19 +0200)]
Temporrary disable japi packaging for opensuse

To unbreak verify job, caused by following message:

19:06:58 RPM build errors:
19:06:58     File not found: /w/workspace/vpp-verify-master-osleap15/build-root/rpmbuild/BUILDROOT/vpp-18.10-rc0~105_g0578e3f9~b1992.x86_64/usr/share/java/*
19:06:58 make[2]: *** [Makefile:50: RPM] Error 1
19:06:58 make[2]: Leaving directory '/w/workspace/vpp-verify-master-osleap15/extras/rpm'
19:06:58 make[1]: *** [Makefile:476: pkg-rpm] Error 2
19:06:58 make[1]: Leaving directory '/w/workspace/vpp-verify-master-osleap15'
19:06:58 make: *** [Makefile:541: verify] Error 2
19:06:58 Build step 'Execute shell' marked build as failure

Change-Id: Ie1300cbf70bedb9dd861a3f31feeddf1eb810eaf
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agovcl: fix debug messages output before heap cfg 91/13891/4
Florin Coras [Thu, 2 Aug 2018 00:24:08 +0000 (17:24 -0700)]
vcl: fix debug messages output before heap cfg

Change-Id: Ifaef7ab2bc2fd4f5b4822d894facbcae01849031
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoNAT44: LB NAT - local backends in multiple VRFs (VPP-1345) 79/13579/3
Matus Fabian [Fri, 20 Jul 2018 05:45:25 +0000 (22:45 -0700)]
NAT44: LB NAT - local backends in multiple VRFs (VPP-1345)

Add support for local backends in multiple VRFs for load-balancing NAT rules.

Change-Id: I64e6818bd67a7e69985003498cf1f16f7200c334
Signed-off-by: Matus Fabian <matfabia@cisco.com>
5 years agoImprove cpu { coremask-% } configure option 96/13696/3
Yi He [Tue, 17 Jul 2018 06:18:41 +0000 (14:18 +0800)]
Improve cpu { coremask-% } configure option

Accept any sized hexadecimal bitmask specification to
support platforms with hundreds of cores.

Change-Id: Ib881db0cf60f78bdeffa13acfc2fc7fe7e128cc4
Signed-off-by: Yi He <yi.he@arm.com>
5 years agoMove java api to extras/ 61/13861/3
Damjan Marion [Mon, 30 Jul 2018 14:10:14 +0000 (16:10 +0200)]
Move java api to extras/

Change-Id: Ibd5cbbdfb22a235442cddaebc9eae9a3c4e35ec9
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agodocs: change code blocks from "shell" to "console" 74/13874/3
John DeNisco [Wed, 1 Aug 2018 14:38:23 +0000 (10:38 -0400)]
docs: change code blocks from "shell" to "console"

Change-Id: I136fccfc06e07fb68d11df686c59687362fb8827
Signed-off-by: John DeNisco <jdenisco@cisco.com>
5 years agovxlan:optimize cached entry compare 56/13856/2
Eyal Bari [Wed, 1 Aug 2018 07:25:50 +0000 (10:25 +0300)]
vxlan:optimize cached entry compare

the bihash key compare was doing the extra step of loading both keys into
vector regs and comparing those - instead of using the temporary values
created.

Change-Id: Ic557bfa56cd6aa60c71e7f28c880f85e1eb1e6ec
Signed-off-by: Eyal Bari <ebari@cisco.com>
5 years agoStore USE_DLMALLOC in vppinfra/config.h 71/13871/1
Damjan Marion [Wed, 1 Aug 2018 12:38:36 +0000 (14:38 +0200)]
Store USE_DLMALLOC in vppinfra/config.h

Change-Id: Ib596e7f525b83dc7e830bcf6a126cd210216ce86
Signed-off-by: Damjan Marion <damarion@cisco.com>
5 years agoAdd support for shuffle vector intrinsic via Neon in ARM 50/13850/2
Sirshak Das [Fri, 27 Jul 2018 06:13:33 +0000 (01:13 -0500)]
Add support for shuffle vector intrinsic via Neon in ARM

This adds byte_swap (variant of shuffle) and shuffle vector intrinsic
for ARM based on Neon, concuring with same signature as SSE vector
intrinsic.

Change-Id: I386fd2b1dcc83654e4ad9f90a6065d7736e4ce5c
Signed-off-by: Sirshak Das <sirshak.das@arm.com>
5 years agoPoison freed memory objects 47/13847/2
Dave Barach [Tue, 31 Jul 2018 14:39:30 +0000 (10:39 -0400)]
Poison freed memory objects

When compiled w/ -DCLIB_DEBUG=1, paint 0x13 across freed memory
blocks. Should result in a characteristic SIGSEGV if someone
dereferences a pointer in a freed vector element, etc.

Change-Id: I5f78970f4342310bfbe7adeddb56feff21f0de2c
Signed-off-by: Dave Barach <dave@barachs.net>
5 years agovxlan:decap.c conform coding style 46/13646/2
Eyal Bari [Tue, 24 Jul 2018 12:15:37 +0000 (15:15 +0300)]
vxlan:decap.c conform coding style

Change-Id: I7bab9800c267dd6ea85288fd3d9ca88dff9f554b
Signed-off-by: Eyal Bari <ebari@cisco.com>
5 years agoFix undefined symbol: fformat_append_cr in vat plugins loading 95/13695/4
Yi He [Mon, 16 Jul 2018 05:52:00 +0000 (13:52 +0800)]
Fix undefined symbol: fformat_append_cr in vat plugins loading

Several test plugins report undefined symbol while being loaded
by load_one_vat_plugin. Fix this by adding VPP_API_TEST_BUILTIN
into CFLAGS for building these plugins.

Change-Id: I908720fd0d01da1ead30ba17027ba10358f6bdf1
Signed-off-by: Yi He <yi.he@arm.com>
5 years agomemif: socket filename fix 42/13842/2
Jakub Grajciar [Tue, 31 Jul 2018 10:25:23 +0000 (12:25 +0200)]
memif: socket filename fix

create runtime dir when adding default socket filename.

Change-Id: Iad7e751fcab7ce773e0907302414a06ea44dd6cd
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
5 years agoacl-plugin: move the acl epoch calculation into inline function 92/13492/2
Andrew Yourtchenko [Mon, 16 Jul 2018 13:17:18 +0000 (15:17 +0200)]
acl-plugin: move the acl epoch calculation into inline function

Change-Id: Ifc8b3d30d66c7ade1e3584844ce3f82d42d2fb94
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
5 years agofix 'sh vxlan tunnels' 21/13821/2
Neale Ranns [Mon, 30 Jul 2018 18:59:22 +0000 (11:59 -0700)]
fix 'sh vxlan tunnels'

this receipe:
  /* Get a line of input. */
  if (!unformat_user (input, unformat_line_input, line_input))
    return 0;
only works if there is more data following the registered command name.
So it is not so good for show commands...

Change-Id: I54249865a44526ade4b40e2d6207138a2d056e40
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
5 years agovcl: add read/write udp support 83/13783/8
Florin Coras [Fri, 27 Jul 2018 12:45:06 +0000 (05:45 -0700)]
vcl: add read/write udp support

Change-Id: Ie6171c12055cde6915856de340839f5da1b1b1da
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agoUpdate Release Notes for 18.07 Release 23/13823/1
Ed Warnicke [Mon, 30 Jul 2018 18:52:54 +0000 (13:52 -0500)]
Update Release Notes for 18.07 Release

Change-Id: I2b58bca6d360badb4fd17022121e244aee5713b8
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
5 years agoSIXRD: fix post introduction of the directed subnet broadcast 13/13813/2
Neale Ranns [Mon, 30 Jul 2018 15:14:14 +0000 (08:14 -0700)]
SIXRD: fix post introduction of the directed subnet broadcast

Change-Id: I9ce801e9b257eaa6be0cbe2ad3bfe630717f8c67
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
5 years agoFIB: return entry prefix by const reference to avoid the copy 12/13812/1
Neale Ranns [Mon, 30 Jul 2018 15:04:40 +0000 (08:04 -0700)]
FIB: return entry prefix by const reference to avoid the copy

Change-Id: I09b8406168df4b6b28df3ede24ee839681be0195
Signed-off-by: Neale Ranns <neale.ranns@cisco.com>
5 years agoReverse the logic of flagging malformed packet in fragmentation code to allow padding 52/13752/2
Rajesh Saluja [Thu, 26 Jul 2018 21:13:09 +0000 (14:13 -0700)]
Reverse the logic of flagging malformed packet in fragmentation code to allow padding

Change-Id: I051c137ae18fd436a798a12a56a9d12f8eaa2e08
Signed-off-by: Rajesh Saluja <rajsaluj@cisco.com>
5 years agosession/dlmalloc: coverity fixes 95/13795/1
Florin Coras [Sat, 28 Jul 2018 11:53:30 +0000 (04:53 -0700)]
session/dlmalloc: coverity fixes

Change-Id: I17ffec018f5d2fb06a7a3af6d8bc6128ffee3ae6
Signed-off-by: Florin Coras <fcoras@cisco.com>
5 years agodlmalloc: use static magic constant for debug images 85/13785/1
Florin Coras [Fri, 27 Jul 2018 18:30:46 +0000 (11:30 -0700)]
dlmalloc: use static magic constant for debug images

Avoids crashes on restarts if svm root region backing file was not
cleaned up.

Change-Id: I608cf5711aa8c3f9620900473bdf76bde8b918de
Signed-off-by: Florin Coras <fcoras@cisco.com>