vpp.git
4 years agoip: Adding IP tables is no MP safe 37/26137/1
Neale Ranns [Wed, 25 Mar 2020 07:21:09 +0000 (03:21 -0400)]
ip: Adding IP tables is no MP safe

Type: fix

it was marked MP safe in the CLI (which it shouldn't be) but
it it not marked MP safe on the API.

Change-Id: I4bdea498a510a8b406d13d62a899b6d03656f7e8
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agonat: in2out/out2in handoff node index bugfix 61/25861/2
Elias Rudberg [Fri, 13 Mar 2020 13:26:50 +0000 (14:26 +0100)]
nat: in2out/out2in handoff node index bugfix

This fixes a bug in the initialization of handoff_out2in_index and
handoff_in2out_index where the node index for out2in was set to the
in2out node, and vice versa.

Type: fix

Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: I983ddd3b3cec06f4cb3fb95b2a9cda4ab6d1270f
(cherry picked from commit dd9aedaf377f4af8620408843bd3e4610d3df5f9)

4 years agovppapigen: fix options representation 01/25901/1
Ole Troan [Tue, 4 Feb 2020 08:12:00 +0000 (09:12 +0100)]
vppapigen: fix options representation

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ief77110160120ea0e1291cc79949a73404cdbfda
(cherry picked from commit 59b6c0c86d0c3310b8d87b9f2600b6fc7682b549)

4 years agordma: fix bug related to ring buffer 12/25812/1
Elias Rudberg [Tue, 18 Feb 2020 11:12:25 +0000 (12:12 +0100)]
rdma: fix bug related to ring buffer

Fix a bug that caused some input packets to be dropped due to errors of
the type 'ip4 length > l2 length'. The change is related to the second
call to the rdma_device_input_bufs() function that happens when the end
of the ring buffer is reached.

Type: fix
Change-Id: I332d69ab22242b3443a0baca6e5dd86349a54765
Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
(cherry picked from commit e5ecf3ea4b456afb710f4ed903cd7e4c1ae87859)

4 years agodpdk: TSO does not work for Cisco VIC 04/25404/2
Steven Luong [Thu, 13 Feb 2020 02:45:09 +0000 (18:45 -0800)]
dpdk: TSO does not work for Cisco VIC

While TSO is supported for Intel NIC, Cisco VIC does not work.
The problem is due to txmode offloads is not properly set for
the Cisco VIC when enable-tcp-udp-checksum is configured.

Type: fix
Ticket: VPP-1838

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I72c41db9b327ed8d08ef70d74e8cc6206d4a102f
(cherry picked from commit ac8bb9263438221cc93db62257ffd8db711530e2)

4 years agoavf: Handle chain buffer in TX properly 80/25580/2
Steven Luong [Thu, 13 Feb 2020 17:27:38 +0000 (09:27 -0800)]
avf: Handle chain buffer in TX properly

For chain buffer, need to traverse b->next_buffer to transmit all buffers
in the chain. Only set EOP at the last descriptor in the chain to signal
this is a chain descriptor.

Introduce slow path to handle ring wrap. This is needed because chain
buffer may consist of multiple pieces and it may span from near the end of
the ring to the beginning of the ring.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Id7c872f3e39e09f3566aa63f3cdba8f40736d508
(cherry picked from commit f7ab7b2d9bc0f42c1e766d22d49dd0dc4f28abb6)

4 years agoip6: fix l4 checksum with hop-by-hop header 83/24883/2
Matthew Smith [Wed, 5 Feb 2020 17:46:40 +0000 (11:46 -0600)]
ip6: fix l4 checksum with hop-by-hop header

L4 checksums for IPv6 should be calculated using a pseudo header that
includes the source/destination addresses, payload length, and payload
protocol.

ip6_tcp_udp_icmp_compute_checksum() was using the payload length and
protocol from the IPv6 header. If there is a hop-by-hop header (or any
other extension header), the payload length used for the pseudo header
should only include the upper layer header and payload and not the
extension header bytes. Same deal with the protocol, the upper layer
next header value should be used instead of the extension header.

Type: fix
Fixes: cb9cadad57

Change-Id: Ifa2c9ad41c0fc4eea674f0671255b637c8e01f71
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
(cherry picked from commit 97677a26f7c857e7ee0acbdb2c13eef214aa70a8)

4 years agofib: adjacency midchain teardown (VPP-1841) 42/25242/3
Neale Ranns [Tue, 18 Feb 2020 13:56:24 +0000 (13:56 +0000)]
fib: adjacency midchain teardown (VPP-1841)

Type: fix

Change-Id: I57f8bfbce4feed9d2775875cb8b1b729a47900a4
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agofib: fib path realloc during midchain stack 45/25245/1
Neale Ranns [Tue, 18 Feb 2020 15:23:29 +0000 (15:23 +0000)]
fib: fib path realloc during midchain stack

Type: fix

Change-Id: I0677f46dfa22c8abab7f311230a09ef1cd8ac335
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agofib: Fix some more realloc errors 77/25177/1
Neale Ranns [Thu, 13 Feb 2020 09:12:36 +0000 (09:12 +0000)]
fib: Fix some more realloc errors

Type: fix

Change-Id: I6011f5d6eae79019d3c16a260a9bedf0a76d2151
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 6ede570259a91cd0c34b9faf9fec7e4ec8275200)

4 years agoclassify: fix "show classify filter" debug CLI 99/25099/1
Dave Barach [Wed, 12 Feb 2020 19:42:57 +0000 (14:42 -0500)]
classify: fix "show classify filter" debug CLI

Null pointer bug, memory leak. D'oh!

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ic2865757ed9cbb7f48d23c7c30b64299eb5f6674
(cherry picked from commit 104112f2d412a4576b5e0d3bbb20665d2b5bd615)

4 years agoclassify: pcap / packet trace debug CLI bugs 06/25006/1
Dave Barach [Mon, 27 Jan 2020 14:56:58 +0000 (09:56 -0500)]
classify: pcap / packet trace debug CLI bugs

"classify filter trace ... " and "classify filter pcap ..." are
mutually exclusive.

vnet_pcap_dispatch_trace_configure needs to check for
set->table_indices == NULL.

Type: fix
Ticket: VPP-1827

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I43733364087ffb0a43de92e450955033431d559d
(cherry picked from commit 196fce2b62c0d215722dd233aa8bf70a43aa0a66)

4 years agoipsec: set l2_len for GRE-TEB tunnel decap 31/24731/3
John Lo [Sat, 1 Feb 2020 04:48:30 +0000 (23:48 -0500)]
ipsec: set l2_len for GRE-TEB tunnel decap

Type: fix
Ticket: VPP-1831

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I655964b22021ac38cbced577091a1156286d4fd6

4 years agovppinfra: fix typo in tw_timer_template.c 66/24766/2
Dave Barach [Mon, 3 Feb 2020 16:57:41 +0000 (11:57 -0500)]
vppinfra: fix typo in tw_timer_template.c

Fix minor memory leak

Type: fix
Ticket: VPP-1833
Fixes: 4af9ba1dab

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id10fba70471ca78f73f14146054f6b12c5d4431f

4 years agovirtio: vhost gso is broken in some topology 64/24764/2
Steven Luong [Thu, 30 Jan 2020 23:18:45 +0000 (15:18 -0800)]
virtio: vhost gso is broken in some topology

Recent modification added a call to vnet_gso_header_offset_parser in the
beginning of vhost_user_handle_tx_offload. The former routine may set tcp or
udp->checksum to 0. While it is appropriate to set it to 0 for the GSO packet,
it is broken and causes checksum error if the aformentiooned routine is called
by a non-GSO packet. The fix is to not call vhost_user_handle_tx_offload
if the buffer does not indicate checksum offload is needed.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6e699d7a40b7887ff149cd8f77e8f0fa9374ef19
(cherry picked from commit 564e1672917e205d7ae79525bb937df18f8d764b)

4 years agofib: refresh adj pointer after fib_walk_sync due to possible realloc 61/24761/1
Steven Luong [Thu, 30 Jan 2020 17:11:18 +0000 (09:11 -0800)]
fib: refresh adj pointer after fib_walk_sync due to possible realloc

fib_walk_sync may call adj_alloc which may cause adj_pool to expand. When
that happens, any previous frame which still use the old adj pointer needs to
refresh. Failure to do so may access or update to the old adj memory
unintentionally and crash mysteriously.

Type: fix
Ticket: VPPSUPP-54

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I173dec4c5ce81c6e26c4fe011b894a7345901b24
(cherry picked from commit 3d5f6229bccf77fcf7e0e17ab4f1b361fedd1b2b)

4 years agomisc: VPP 20.01 Release Notes 05/24505/7 v20.01
Andrew Yourtchenko [Fri, 24 Jan 2020 11:50:43 +0000 (12:50 +0100)]
misc: VPP 20.01 Release Notes

Type: docs
Change-Id: Iee518fbb9c72716cc90a3ea8efbf3ecbaa969a84
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agomisc: Markdown cleanups for the 20.01 release 21/24521/5
Andrew Yourtchenko [Mon, 27 Jan 2020 11:09:17 +0000 (11:09 +0000)]
misc: Markdown cleanups for the 20.01 release

Type: docs
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: I821197364a2fee9b52b1f014288b1f5e9e3c494c

4 years agodevices: vhost: fix data offset on input 97/24597/2
Benoît Ganne [Fri, 24 Jan 2020 17:06:01 +0000 (18:06 +0100)]
devices: vhost: fix data offset on input

Regardless of whether the virtio_net_hdr is sent as a separate
descriptors or in the same descriptor as the data, we always want to
skip the header length - maybe moving to the next descriptor along the
way.

Type: fix

Change-Id: Iaa70aeb310e589639b20f8c7029aaa8d3ce5d307
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit 5ecc1e4d433a34845c7bfd761dc990413e6c321b)

4 years agosession tcp: fix packet tracing 99/24599/1
Florin Coras [Tue, 28 Jan 2020 03:21:28 +0000 (19:21 -0800)]
session tcp: fix packet tracing

Type: fix
Ticket: VPP-1830

Change-Id: Ib823d016c64998779fb1d00b8aad3acb5e8340be
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 30928f87a3c9d98e288d1364d50c032e052e69ab)

4 years agofib: Reload the adj after possible realloc (VPP-1822) 01/24501/2
Neale Ranns [Thu, 23 Jan 2020 22:46:06 +0000 (22:46 +0000)]
fib: Reload the adj after possible realloc (VPP-1822)

Type: fix
Fixes: 418b225931634f6d113d2971cb9550837d69929d

Change-Id: Ia5f4ea24188c4f3de87e06a7fd07b40bcb47cfc1
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agonsim: enable output scheduling on main thread 83/24483/3
Dave Wallace [Tue, 21 Jan 2020 16:56:19 +0000 (16:56 +0000)]
nsim: enable output scheduling on main thread

Type: fix
Ticket: VPP-1813

Change-Id: I5d47cb9bc7eb7f3c8485e3b42f0701e81d87ba2a
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
(cherry picked from commit c0c4eec3bc309bcc656eade82f17754875f9ed7c)

4 years agosrv6-mobile: Update the document 65/24365/6
Satoru Matsushima [Thu, 16 Jan 2020 09:16:39 +0000 (09:16 +0000)]
srv6-mobile: Update the document

Updating the document of srv6-mobile plugin code integrated into stable/2001. The reason of this patch just only for the document is that the latest commit to master was reverted by the release master for some reason. The commit included not only the code for new feature, but also the updated document for the already merged code into stable/2001. The previous doc is work-in-progress status in terms of its CLI and features. It seems there is some confusion on this patch is trying to update the document of outside feature of stable/2001 which is not true. This patch exactly reflects the correct information of srv6-mobile plugin within the extent of stable/2001.

Type: docs

Signed-off-by: Satoru Matsushima <satoru.matsushima@gmail.com>
Change-Id: I376386ef6fc9584ab945db7358e3c4a698471e9b
Signed-off-by: Satoru Matsushima <satoru.matsushima@gmail.com>
4 years agosession: fix node runtime in pre-input queue handler 20/24520/1
Florin Coras [Wed, 18 Dec 2019 17:38:40 +0000 (09:38 -0800)]
session: fix node runtime in pre-input queue handler

Call session queue node with the right node runtime instead of the
pre-input node runtime.

Type: fix
Ticket: VPP-1826

Change-Id: I43d20bed4930fc877b187ce7ecdce62034b393c5
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 2d8829cbb5f3d214fbc09bf4258573659e0c5e60)

4 years agoapi: mark api_trace_command_fn thread-safe 97/24497/2
Dave Barach [Thu, 23 Jan 2020 13:44:40 +0000 (08:44 -0500)]
api: mark api_trace_command_fn thread-safe

Binary API trace replay with multiple worker threads depends in many
cases on worker thread graph replica maintenance. If we (implicitly)
assert a worker thread barrier at the debug CLI level, all graph
replica changes are deferred until the replay operation completes. If
an interface is deleted, the wheels may fall off.

Type: fix
Ticket: VPP-1824

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9b07d43f8501caa5519e5ff9ae4c19dc2661cc84

4 years agohsa: proxy app fixes 84/24484/3
Florin Coras [Wed, 22 Jan 2020 00:17:53 +0000 (16:17 -0800)]
hsa: proxy app fixes

Type: fix
Ticket: VPP-1825

Change-Id: Icb4b331c9346d3781f4ddd6f62891c78d4059c1f
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit f5c7305c4ab21fe1c3eeeee1484449586464813a)

4 years agofib: FIB crash removing labelled route (VPP-1818) 35/24435/2
Neale Ranns [Mon, 20 Jan 2020 02:28:00 +0000 (02:28 +0000)]
fib: FIB crash removing labelled route (VPP-1818)

Type: fix

The crash occured trying to retreive a NULL path list to walk the path
extensions. A walk shoul not be required, because there should be no
extensins, since all paths are removed. The problem is that when the
paths were added, they were not sorted, hence neither were the
extensions and when they were updated, duplicate extensions were added,
and hence a path removal did not remove them all.
Fix is to make sure paths are sorted.

Change-Id: I069d937de8e7bc8aae3d92f588db4daff727d863
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 257749c40946a9269140d322e374d74c3b6eefb8)

4 years agoipsec: re-enable DPDK IPSec for tunnel decap/encap (VPP-1823) 58/24458/2 v20.01-rc2
Neale Ranns [Tue, 21 Jan 2020 04:58:02 +0000 (04:58 +0000)]
ipsec: re-enable DPDK IPSec for tunnel decap/encap (VPP-1823)

Type: fix

Change-Id: Iff9b1960b122f7d326efc37770b4ae3e81eb3122
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agofib: Adjacency realloc during rewrite update walk (VPP-1822) 56/24456/1
Neale Ranns [Sun, 12 Jan 2020 21:16:55 +0000 (21:16 +0000)]
fib: Adjacency realloc during rewrite update walk (VPP-1822)

Type: fix

Change-Id: I0e826284c50713d322ee7943d87fd3363cfbdfbc
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agomisc: Initial changes for stable/2001 branch 59/24359/2 v20.01-rc1
Andrew Yourtchenko [Wed, 15 Jan 2020 21:40:26 +0000 (21:40 +0000)]
misc: Initial changes for stable/2001 branch

Type: docs
Change-Id: I0a8a43bd5436b5d3cdd9b8937cd0b2366e523f91
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agobuild: install vpp_echo for CSIT QUIC perf tests 54/24354/1
Dave Wallace [Wed, 15 Jan 2020 18:16:31 +0000 (18:16 +0000)]
build: install vpp_echo for CSIT QUIC perf tests

Type: make

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Iddfcce1f662efe63c5a6788a0a604917b1c9d81e

4 years agotcp: fix tcp check tx offload issue 58/24258/7
Simon Zhang [Tue, 24 Dec 2019 12:02:20 +0000 (20:02 +0800)]
tcp: fix tcp check tx offload issue

Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: I3b8755831d762abf51e1cbe1b57024f9297de9a4
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
4 years agotls: enable async node on demand 35/24335/2
Yu Ping [Tue, 14 Jan 2020 22:24:44 +0000 (06:24 +0800)]
tls: enable async node on demand

Type: fix

Change-Id: Iab7c65614c94497e8ec5a96624be72c1a139e486
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agoip6: during icmp to icmp6 translation truncate error messages 47/24347/2
Alexander Chernavin [Wed, 15 Jan 2020 11:45:47 +0000 (06:45 -0500)]
ip6: during icmp to icmp6 translation truncate error messages

All translated ICMPv6 packets that exceed the minimal IPv6 MTU get
truncated but according to RFC 4443 2.4 only ICMPv6 error messages
(type < 128) need to be truncated.

With this commit, truncate only ICMPv6 error messages.

Type: fix

Change-Id: Ic455352de2ff4ff6aa3421b46a2a54923f2d3f80
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
4 years agoquic: add FEATURE.yaml 23/24323/2
Aloys Augustin [Tue, 14 Jan 2020 13:23:37 +0000 (14:23 +0100)]
quic: add FEATURE.yaml

Type: docs
Change-Id: Ica60b42e64703879c5c229209e4a4fac278bda31
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
4 years agosrv6-mobile: Revert "srv6-mobile:" 30/24330/4
Andrew Yourtchenko [Tue, 14 Jan 2020 19:26:27 +0000 (19:26 +0000)]
srv6-mobile: Revert "srv6-mobile:"

This reverts commit 57584d99dd8a8524db90c67c88525d58879d9b8e.

The reasons for reverting:

- the documentation seems "work in progress". Also, 500K of pngs
  should probably go on wiki, rather than in the repo. Please
  make sure that newly added documentation renders correctly
  and sensibly as part of the review/commit process.

- runner.py seems to contain unit tests, so it should
  be rewritten in a manner that allows the testing from within
  CI (including an unprivileged docker container)

- the above items, especially the testing one, warrant more
  work, and at a RC1 milestone time it is probably not
  a good idea to include a significant patch without
  proper care. I suggest to prepare it so it is ready
  for the next release, or cherrypick it for a
  20.01.1 release, if having it in stable/2001 is absolute necessity.

- when submitting it, ensure that the commit message
  makes sense, especially having "srv6-mobile:" with no further
  text should be absolutely avoided.

Change-Id: If81441f7ebf11a6ad5638b1327faf18e8ebe6a35
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agotls: add picotls session close process 13/24313/3
Simon Zhang [Tue, 14 Jan 2020 10:11:18 +0000 (18:11 +0800)]
tls: add picotls session close process

Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: If0a1691c1435f2826c8c83f8bc52e4cd3ecc6256

4 years agotcp: handle ack advancement with no holes and reneging 55/24255/5
Florin Coras [Wed, 8 Jan 2020 22:01:54 +0000 (22:01 +0000)]
tcp: handle ack advancement with no holes and reneging

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9afba8dc9e087b8c436fe568531c02614a577a7c

4 years agotests: fix worker thread initialization 03/23803/4
Paul Vinciguerra [Thu, 5 Dec 2019 00:43:53 +0000 (19:43 -0500)]
tests: fix worker thread initialization

from threading.thread __init__:

    This constructor should always be called with keyword arguments.

    If a subclass overrides the constructor, it must make sure to invoke
    the base class constructor (Thread.__init__()) before doing anything
    else to the thread.

Type: test
Change-Id: Ifa89202e97053a4baf19e9a0ca0913430d5087a3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agosrv6-mobile: 75/24275/10
Tetsuya Murakami [Thu, 9 Jan 2020 22:22:04 +0000 (14:22 -0800)]
srv6-mobile:

Type: feature

Add new functions in SRv6 Mobile Plug-in

GTP4.DT and GTP6.DT

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I573a0c27bd463dd56a4d11b940941b8a8c826e08
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
4 years agoclassify: Reduce the include dependencies on vnet_classify.h 59/24259/3
Neale Ranns [Thu, 9 Jan 2020 06:43:14 +0000 (06:43 +0000)]
classify: Reduce the include dependencies on vnet_classify.h

Type: refactor

currently vnet_classify.h is included in ip.h where it's not required.

Change-Id: Id55682637601655aa2edda681536a979c8e323bd
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agodpdk: enforce max tx retries 18/24218/2
Benoît Ganne [Tue, 7 Jan 2020 12:40:17 +0000 (13:40 +0100)]
dpdk: enforce max tx retries

n_retry was never decremented and so never enforced.

Type: fix

Change-Id: I71d60a72c156286f7e5b82b1c77a723361317c69
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoacl: Remove unsued type 95/24195/2
Neale Ranns [Mon, 6 Jan 2020 02:48:19 +0000 (02:48 +0000)]
acl: Remove unsued type

Type: style

and add some indent offs.

Change-Id: I31cf3ab9ff9b64d2cd1f2034dcedd4a9c453efb4
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoct6: dst,src copy typo 09/24209/4
Neale Ranns [Tue, 7 Jan 2020 01:41:16 +0000 (01:41 +0000)]
ct6: dst,src copy typo

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I266fa5dc637383fd8dac6592c9c266a1b70a73e9

4 years agomisc: feature file for unsupported feature l2tp 81/24281/3
Ole Troan [Fri, 10 Jan 2020 10:31:10 +0000 (11:31 +0100)]
misc: feature file for unsupported feature l2tp

Type: docs
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I11db583650bc051f88f38358b877410f355b110f
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agotests: disable the tap test for the time being 91/24291/5
Andrew Yourtchenko [Sat, 11 Jan 2020 17:57:31 +0000 (17:57 +0000)]
tests: disable the tap test for the time being

TAP tests require root access, which breaks
the testing in unprivileged scenario.
Disable the test until we find consensus on how
to deal with it.

Type: test
Change-Id: I66ee2b130723233682d858cad0b6e424ab0b2383
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agotls: enable TLS OpenSSL plugin works in 3.0.0 77/24277/3
Yu Ping [Thu, 9 Jan 2020 19:45:06 +0000 (03:45 +0800)]
tls: enable TLS OpenSSL plugin works in 3.0.0

Type: fix

Change-Id: Id1602981fcc6efed1b0efe79a1fc8177457acdb5
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agomisc: VPP 19.08.1 release notes 92/24292/1
Andrew Yourtchenko [Sat, 11 Jan 2020 18:07:14 +0000 (18:07 +0000)]
misc: VPP 19.08.1 release notes

Change-Id: I365696bfcf11fcc74a698f764dec62e470fc7853
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Type: docs

4 years agoip: avoid fib lookup for consecutive pkts having same source IP 92/24192/4
Nitin Saxena [Sat, 4 Jan 2020 06:58:42 +0000 (12:28 +0530)]
ip: avoid fib lookup for consecutive pkts having same source IP

Type: fix
Fixes: be2286b0

This patch does following:

- If terminating frame has consecutive packets with same source IP, this patch
  avoids fib lookup for those packets in ip4-local node. This drops cycle count
  for ip4-local node on both ARM and x86. It being done by enabling dead code in
  else {} case of ip4_local_check_src_x2() and ip4_local_check_src() functions.

- In case all packets in terminating frame have unique source IP (e.g:
  incrementing), ip4-local is costlier by 2 cycles (broadwell)

Change-Id: I472ddc324716cec8bfe601568b8aeb7565f97ab3
Signed-off-by: Nitin Saxena <nsaxena@marvell.com>
4 years agogso: add FEATURE.yaml 48/24248/2
Mohsin Kazmi [Wed, 8 Jan 2020 17:18:50 +0000 (18:18 +0100)]
gso: add FEATURE.yaml

Type: docs

Change-Id: I64743c9f5ad7eef21855e883e1a00f355fddf3ee
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agosr: feature YAML files for Segment Routing 74/24274/5
pcamaril [Thu, 9 Jan 2020 17:31:47 +0000 (18:31 +0100)]
sr: feature YAML files for Segment Routing

Type: docs
Signed-off-by: pcamaril <pcamaril@cisco.com>
Change-Id: Ia35d18113e17fd2ba5310e81ca527d3569cd110e
Signed-off-by: pcamaril <pcamaril@cisco.com>
4 years agodocs: Edit FEATURE.yaml files so they can be published 88/24288/4
John DeNisco [Fri, 10 Jan 2020 15:07:26 +0000 (10:07 -0500)]
docs: Edit FEATURE.yaml files so they can be published

Type: docs
Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: I7280e5c5ad10a66c0787a5282291a2ef000bff5f

4 years agobonding: process lacp when bond is admin down 30/24230/2
Matthew Smith [Tue, 7 Jan 2020 17:34:43 +0000 (11:34 -0600)]
bonding: process lacp when bond is admin down

Type: fix
Fixes: 6dfd3785e4

When a bond interface is administratively down but the slaves are
up, process inbound LACP packets received over the slaves. This
was the old behavior with bond interfaces in LACP mode and was
altered unintentionally by another change. Restore the old behavior.

Change-Id: I61b0b700211dea4859b6ee447ab83b33197d9d11
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
4 years agofib: leverage well-optimized clib_memcpy 62/24262/2
Zhiyong Yang [Thu, 9 Jan 2020 09:20:57 +0000 (04:20 -0500)]
fib: leverage well-optimized clib_memcpy

Type: fix

Change-Id: I684910837ca4d9c8a07262459158bbb0423a33af
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
4 years agosession: remove io event dispatch dbg msg 73/24273/1
Florin Coras [Thu, 9 Jan 2020 16:41:31 +0000 (16:41 +0000)]
session: remove io event dispatch dbg msg

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I166ab7b96444587a3252925d3a28505e0db52d74

4 years agotcp: fix persist assert 56/24256/3
Florin Coras [Wed, 8 Jan 2020 23:30:15 +0000 (23:30 +0000)]
tcp: fix persist assert

Type: fix

Persist and retransmit can pop at the same time.

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia9530645cc84c83a881a75d7b4627197dc50ed29

4 years agomisc: fix feature description spelling 65/24265/2
Ole Troan [Thu, 9 Jan 2020 13:03:14 +0000 (14:03 +0100)]
misc: fix feature description spelling

Type: docs
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I46856db81d42c3f10c03a7bf9a245cc998cd8a01

4 years agomisc: feature tracking markdown improvements 39/24239/5
Ole Troan [Wed, 8 Jan 2020 11:37:55 +0000 (12:37 +0100)]
misc: feature tracking markdown improvements

Add table of contents to markdown file.
Added --exclude and --include options to user select which
fts fields to include in report.
Sort output based on feature name.

E.g.: ./build-root/scripts/fts.py --all --markdown --exclude="maintainer"

Type: make
Change-Id: I3edf8c2188a9f3e312767bbe12d75cca7d8c5b39
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agotcp: fix scoreboard assert 50/24250/2
Florin Coras [Wed, 8 Jan 2020 18:49:59 +0000 (18:49 +0000)]
tcp: fix scoreboard assert

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3c70b331932708a1b773392e089aed9dba9b3b31

4 years agordma: api: prepare support for direct verb 25/24225/4
Benoît Ganne [Tue, 7 Jan 2020 15:08:43 +0000 (16:08 +0100)]
rdma: api: prepare support for direct verb

Prepare rdma interface creation API for direct verb support:
 - add new optional 'mode' parameters to select between ibverb or direct
   verb backend (optional, default to 'auto')
 - set default value for rxq_num (1), rxq_size (1024) and txq_size
   (1024) so they are now optional
 - bump default create value for rxq_size and txq_size to 1024 if
   unset (0) so they are coherent with default values above

Type: feature

Change-Id: Id9eae2b8eb0baaf34a0fcd55da6ad09515f57a93
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovirtio: fix ip4 checksum offload 30/24130/7
Mohsin Kazmi [Thu, 26 Dec 2019 19:42:18 +0000 (20:42 +0100)]
virtio: fix ip4 checksum offload

Type: fix

Change-Id: I08747ac308e5c1768a3a6aa5f83a016dc0274a1c
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agotap: split gso and checksum offload functionality 60/24060/12
Mohsin Kazmi [Wed, 18 Dec 2019 16:08:54 +0000 (17:08 +0100)]
tap: split gso and checksum offload functionality

Type: refactor

Change-Id: I0d4b79ef384c11c841576d264bfd8ccb21783e10
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agovirtio: split gso and checksum offload functionality 71/23971/14
Mohsin Kazmi [Fri, 3 Jan 2020 15:11:53 +0000 (15:11 +0000)]
virtio: split gso and checksum offload functionality

Type: refactor

Change-Id: I897e36bd5db593b417c2bac9f739bc51cf45bc08
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agotls: improve connection formating 31/24231/2
Florin Coras [Tue, 7 Jan 2020 19:01:26 +0000 (19:01 +0000)]
tls: improve connection formating

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iea8abe33cf33036267ccaf58760abc2f48470202

4 years agotcp: fix last sacked with no holes 33/24233/4
Florin Coras [Wed, 8 Jan 2020 00:33:02 +0000 (00:33 +0000)]
tcp: fix last sacked with no holes

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id12b0a9b8bc47aef8b393544e5b4c8228ed6a606

4 years agovppinfra: retry socket connect on EAGAIN 01/24201/5
Florin Coras [Mon, 6 Jan 2020 20:23:07 +0000 (20:23 +0000)]
vppinfra: retry socket connect on EAGAIN

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I93577acf559a8fa639aab7ec3f7cdbe7df9a248d

4 years agosvm: fix eventfd signal write error check 34/24234/2
Florin Coras [Wed, 8 Jan 2020 02:37:57 +0000 (02:37 +0000)]
svm: fix eventfd signal write error check

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I706c8642ca0877430a42cc0ca5bc61a45428fc98

4 years agol2: fix MAC learn counter update on adding MAC entry 32/24232/2
John Lo [Tue, 7 Jan 2020 21:35:29 +0000 (16:35 -0500)]
l2: fix MAC learn counter update on adding MAC entry

Type: fix

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I711432f589ee4a4527cf795526d3b4031999f71d

4 years agoacl: add FEATURE.yaml 35/24235/3
Andrew Yourtchenko [Wed, 8 Jan 2020 05:22:20 +0000 (05:22 +0000)]
acl: add FEATURE.yaml

Change-Id: If6f13e7962c27f35528058224928def927fff19f
Type: docs
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agordma: add FEATURE.yaml 21/24221/3
Benoît Ganne [Tue, 7 Jan 2020 13:53:09 +0000 (14:53 +0100)]
rdma: add FEATURE.yaml

Type: docs

Change-Id: I91d701814e4bd9953616d2b7c76ae2ea7c07074b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovlib: fix coverity warning / real bug 29/24229/1
Dave Barach [Tue, 7 Jan 2020 17:29:10 +0000 (12:29 -0500)]
vlib: fix coverity warning / real bug

The path must be next-to-impossible to hit, because the code has been
wrong for at least 5 years.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I23b8c4e1631827e7931f353c561c1e19c596c598

4 years agotls: Make tls CPS test run for a quite long time 10/24210/4
Yu Ping [Mon, 6 Jan 2020 20:02:55 +0000 (04:02 +0800)]
tls: Make tls CPS test run for a quite long time

Type: fix

Change-Id: I8cfb48bd7f92689b296861dd368186408918061b
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agotcp: fix duplicate sack whith reneging 90/24190/9
Florin Coras [Sat, 4 Jan 2020 00:53:04 +0000 (00:53 +0000)]
tcp: fix duplicate sack whith reneging

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I6f7fb91e059996ff702eb9c36e3abaed237fe221

4 years agovppinfra: hash [un]set malloc/free takes a const key 02/24202/3
Neale Ranns [Mon, 6 Jan 2020 21:09:12 +0000 (21:09 +0000)]
vppinfra: hash [un]set malloc/free takes a const key

Type: refactor

the key is not modified by these functions

Change-Id: I578f054355fca69e8a086bb69013155a01ed759f
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agobonding: fix feature.yaml error 11/24211/2
Ole Troan [Tue, 7 Jan 2020 08:30:05 +0000 (09:30 +0100)]
bonding: fix feature.yaml error

Type: fix
Fixes: 6b32b4aad
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8bd6bb95135dc280565f357aa5850292f66979a1
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agobonding: Add FEATURE.yaml 03/24203/2
Steven Luong [Mon, 6 Jan 2020 21:28:34 +0000 (13:28 -0800)]
bonding: Add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I53522a60122014741d1c6533a0456bf31445529a

4 years agoipsec: Add FEATURE/yaml 05/24205/2
Neale Ranns [Mon, 6 Jan 2020 23:16:18 +0000 (23:16 +0000)]
ipsec: Add FEATURE/yaml

Type: docs

Change-Id: I9cb093589b84fdca3f4239da90c431e8bc4d74f1
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoqos: Add FEATURE.yaml 07/24207/2
Neale Ranns [Mon, 6 Jan 2020 23:22:38 +0000 (23:22 +0000)]
qos: Add FEATURE.yaml

Type: docs

Change-Id: Id719ad59dd70f1d97b3cb3722621b10cd63badfb
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agompls: Add FEATURE.yaml 08/24208/2
Neale Ranns [Mon, 6 Jan 2020 23:30:59 +0000 (23:30 +0000)]
mpls: Add FEATURE.yaml

Type: docs

Change-Id: Ic76a4bbfe2e2e45b7ea44556bc974c243970e9bf
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoip-neighbor: Add FEATURE.yaml 04/24204/2
Neale Ranns [Mon, 6 Jan 2020 23:11:09 +0000 (23:11 +0000)]
ip-neighbor: Add FEATURE.yaml

Type: docs

Change-Id: I4c51dad23cf431692ef5b8bdd2391975fb7264d6
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agovmxnet3: add FEATURE.yaml 99/24199/2
Steven Luong [Mon, 6 Jan 2020 18:22:02 +0000 (10:22 -0800)]
vmxnet3: add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I8b0432a3a384dc2431fcb0b4e7c3f0cfb1713d8e

4 years agolacp: Add FEATURE.yaml 00/24200/1
Steven Luong [Mon, 6 Jan 2020 19:17:18 +0000 (11:17 -0800)]
lacp: Add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6fe5555a9ec867d4e39f0751662256717b45e0f9

4 years agoquic: update quicly to v0.0.9-vpp 98/24198/2
MathiasRaoul [Mon, 6 Jan 2020 15:09:50 +0000 (15:09 +0000)]
quic: update quicly to v0.0.9-vpp

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I5cef549de8380b9b9534b8774819e42988f6b784

4 years agol2: Update FEATURE.yaml 97/24197/2
John Lo [Mon, 6 Jan 2020 14:54:36 +0000 (09:54 -0500)]
l2: Update FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: Ib34440c137f24621002ce9463515c632c472a293

4 years agogre: fix feature.yaml error 96/24196/2
Ole Troan [Mon, 6 Jan 2020 11:15:24 +0000 (12:15 +0100)]
gre: fix feature.yaml error

vnet/gre/FEATURE.yaml does not conform with the JSON schema definition.
This bug should no longer happen with the patch that ensures
validation is run as part of checkstyle.

Signed-off-by: Ole Troan <ot@cisco.com>
Type: fix
Change-Id: I25bf8d2a442bf7ccdbf693b031a7a383444dfee3

4 years agoquic: call quic_send_packets only once per ctx 95/24095/3
Aloys Augustin [Fri, 20 Dec 2019 12:14:00 +0000 (13:14 +0100)]
quic: call quic_send_packets only once per ctx

This prevents unnecessary calls to quic_send_packets.

Type: fix
Change-Id: I7abe509aa8b7b9d5a01c9876046cf0f4507a79cf
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
4 years agolb: add FEATURE file for lb/pppoe/gtpu/vxlan-gpe/pppoe 76/24176/2
Hongjun Ni [Fri, 3 Jan 2020 14:34:38 +0000 (22:34 +0800)]
lb: add FEATURE file for lb/pppoe/gtpu/vxlan-gpe/pppoe

Type: docs

Change-Id: Ia3949954423eb7691c02e99444767a9f01a14adf
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
4 years agogre: Add FEATURE.yaml 93/24193/5
Neale Ranns [Sun, 5 Jan 2020 22:10:35 +0000 (22:10 +0000)]
gre: Add FEATURE.yaml

Type: docs

Change-Id: Icda0c8d2141294d78447177dd4823d1b2228e830
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoip6-nd: Add FEATURE.yaml 94/24194/1
Neale Ranns [Sun, 5 Jan 2020 22:17:53 +0000 (22:17 +0000)]
ip6-nd: Add FEATURE.yaml

Type: docs

Change-Id: I907f2c7f5d73dd88b16a6ff78ef072e13af9739e
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agomisc: fix feature.yaml 86/24186/3
Ole Troan [Fri, 3 Jan 2020 15:37:27 +0000 (16:37 +0100)]
misc: fix feature.yaml

Add checkfeaturelist validation to checkstyle.
Fix two files with errors.

Type: docs
Change-Id: I81eda0e25b271f2006b4da22efdf7218d52a67d3
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agovxlan: Add FEATURE.yaml 91/24191/4
John Lo [Sat, 4 Jan 2020 05:32:46 +0000 (00:32 -0500)]
vxlan: Add FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I4372195121e05af671a3f48b1c2796cd0132b279

4 years agol2: Add FEATURE.yaml 88/24188/3
John Lo [Fri, 3 Jan 2020 22:47:34 +0000 (17:47 -0500)]
l2: Add FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: Icd22f2ec7076bb11d6ac7e7d147bd58dc5ad1527

4 years agoipsec: AH copy destination and source address from template 49/24149/2
Neale Ranns [Thu, 2 Jan 2020 05:04:00 +0000 (05:04 +0000)]
ipsec: AH copy destination and source address from template

Type: fix

Change-Id: I63d4df68eed6589763b5ce62bcd7f3fd867c60e1
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoipsec: Targeted unit testing 88/24088/4
Neale Ranns [Fri, 20 Dec 2019 00:54:57 +0000 (00:54 +0000)]
ipsec: Targeted unit testing

Type: fix

1 - big packets; chained buffers and those without enoguh space to add
ESP header
2 - IPv6 extension headers in packets that are encrypted/decrypted
3 - Interface protection with SAs that have null algorithms

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ie330861fb06a9b248d9dcd5c730e21326ac8e973

4 years agotcp: fix rate samples for old acks 19/24119/2
Florin Coras [Mon, 23 Dec 2019 18:03:27 +0000 (10:03 -0800)]
tcp: fix rate samples for old acks

Type: fix

Change-Id: Ieab35bbfba81faae61b1267d8661df5195877824
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agohsa: fix coverity warning 87/24187/3
Florin Coras [Fri, 3 Jan 2020 16:44:47 +0000 (16:44 +0000)]
hsa: fix coverity warning

Type:fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I38b155f7617d002ac16943c2c031269a17f4ba73

4 years agosession: fix per slice fifo prealloc 58/24158/3
Florin Coras [Thu, 2 Jan 2020 19:22:51 +0000 (19:22 +0000)]
session: fix per slice fifo prealloc

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If6db37af6c2863a80d0787a98026b3b8171dad37

4 years agofib: Add dpo FEATURE.yaml file 75/24175/4
Neale Ranns [Fri, 3 Jan 2020 03:55:08 +0000 (03:55 +0000)]
fib: Add dpo FEATURE.yaml file

Type: docs

Change-Id: I9c4727db8d498d0b513157b19ad306b7aaacc222
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agobfd: add feature.yaml 84/24184/3
Klement Sekera [Fri, 3 Jan 2020 12:15:16 +0000 (12:15 +0000)]
bfd: add feature.yaml

Type: docs

Change-Id: Ica2b4a9d4fe2ceaafd6d707ebe3c4a7fa0af1c07
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agotcp: api clenup 79/24179/3
Jakub Grajciar [Fri, 3 Jan 2020 09:02:32 +0000 (10:02 +0100)]
tcp: api clenup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I48f08cc657c28ad1eef50c917a560425137bb70e
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>