vpp.git
4 years agosr: some fixes for SRv6 CLI/API 64/23864/4
Ahmed Abdelsalam [Sun, 8 Dec 2019 11:58:27 +0000 (12:58 +0100)]
sr: some fixes for SRv6 CLI/API

Return FIB table_id instead of vrf_index to clients

Type: fix
Signed-off-by: Ahmed Abdelsalam <ahabdels@cisco.com>
Change-Id: I76a97bad3ecd3ac8eb045efb1657eaa90c2a57b6

4 years agomisc: binary-api sw_interface_vhost_user_dump is broken 77/24377/2
Steven Luong [Thu, 16 Jan 2020 16:45:53 +0000 (08:45 -0800)]
misc: binary-api sw_interface_vhost_user_dump is broken

Recent modificaton to vhost_user APIs for typing which added a sw_if_index
filter to the API sw_interface_vhost_user_dump with the default value -1 to
mean all interfaces. But the default is not set from api_format.c, causing the
binary-api command for sw_interface_vhost_user_dump to display nothing.

Also missing is the proper display on custom dump for the aformentioned API.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I05546e2318165af7531977fbed66ea7224c4a7ce

4 years agogso: fix typo in the quad-loop 79/24379/1
Steven Luong [Thu, 16 Jan 2020 17:57:22 +0000 (09:57 -0800)]
gso: fix typo in the quad-loop

Fix minor typo in the quad-loop for swif which may actually causes problem
if swif0 != swif1 or swif2 or swif3.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ib81f323479c7ecbd28d84956cffbc20b1072d2c2

4 years agotests: fix typo in test doc string 37/24137/4
Paul Vinciguerra [Fri, 27 Dec 2019 05:19:23 +0000 (00:19 -0500)]
tests: fix typo in test doc string

Type: test

Change-Id: I97e02ebc5989eee794511c1ed6049e300be7d64e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agotests: fix TypeError in run_tests.py 27/23927/4
Paul Vinciguerra [Wed, 11 Dec 2019 04:36:05 +0000 (23:36 -0500)]
tests: fix TypeError in run_tests.py

Traceback (most recent call last):
  File "run_tests.py", line 886, in <module>
    exit_code, suites = parse_results(results)
  File "run_tests.py", line 732, in parse_results
    results_per_suite.print_results()
  File "run_tests.py", line 683, in print_results
    result.get_testcase_names(failed_test_id)
TypeError: 'NoneType' object is not iterable

Type: test

Change-Id: I2c5ae0b9e11be6bfb4490d9ce057db0b0a84c9bf
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agotcp: fix rxt delivered without sacks 57/24357/5
Florin Coras [Wed, 15 Jan 2020 20:18:35 +0000 (20:18 +0000)]
tcp: fix rxt delivered without sacks

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I69c245cb0e3f6d599a3270a485fa0a5845cde8eb

4 years agovcl: add rx event on epoll ctl if needed 32/24332/3
Florin Coras [Wed, 15 Jan 2020 01:30:46 +0000 (01:30 +0000)]
vcl: add rx event on epoll ctl if needed

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ib6d0387076a4bb0b52e4cdfdcd62b6060b704fe6

4 years agoudp: fix ipv6 listen port registration 34/24334/3
Florin Coras [Wed, 15 Jan 2020 02:32:07 +0000 (02:32 +0000)]
udp: fix ipv6 listen port registration

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7f2233eb9bf3d81a697f76ba985083cf1040e2e9

4 years agotcp: fix listen node coverity warning 63/24363/3
Florin Coras [Thu, 16 Jan 2020 04:04:54 +0000 (04:04 +0000)]
tcp: fix listen node coverity warning

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If5ec3ec4f46d3840c2b3c3005f093b5dddefc289

4 years agovppinfra: fixing compilation issues in 32-bit 60/24360/2
Vijayabhaskar Katamreddy [Wed, 15 Jan 2020 21:45:19 +0000 (13:45 -0800)]
vppinfra: fixing compilation issues in 32-bit

Fixing compilation issuues for 32-bit also setting init flag for shm based bihash

Type: fix
Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Change-Id: Ic2072c5ba7fc77d061ca9f1b844a71f6e22e58b2

4 years agobuild: Add missing version.h dependency in vnet 62/24362/1
Chris Luke [Thu, 16 Jan 2020 01:30:04 +0000 (20:30 -0500)]
build: Add missing version.h dependency in vnet

Two modules in vnet include vpp/app/version.h but there is
no explicit build dependency for this generated file. This
leaves a race condition in the build system that the Coverity
build has recently started triggering.

Change-Id: I8e2bb32feeb16e1bdd8efb0d2633cfdba60f51aa
Type: fix
Signed-off-by: Chris Luke <chrisy@flirble.org>
4 years agomisc: Initial 20.05-rc0 commit 58/24358/3
Andrew Yourtchenko [Wed, 15 Jan 2020 20:54:40 +0000 (20:54 +0000)]
misc: Initial 20.05-rc0 commit

Type: docs

Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: I935a28d96078629607b23ce9c2aecec47e88b0b1
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agoip: align reass.save_rewrite_length 45/24345/2 v20.05-rc0
Klement Sekera [Wed, 15 Jan 2020 10:30:48 +0000 (10:30 +0000)]
ip: align reass.save_rewrite_length

By aligning vnet_buffer_opaque.ip.save_rewrite_length and
vnet_buffer_opaque.ip.reass.save_rewrite_length we prevent shallow
virtual reassembly code from overwrite save_rewrite_length, allowing
other features down the pipe to rely on this value.

A static assert is added to guard this alignment.

Type: fix
Fixes: f126e746fc01c75bc99329d10ce9127b26b23814

Change-Id: Ie7c7f3abc2a221bbcf2830c0f006a4368088b342
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agobuild: install vpp_echo for CSIT QUIC perf tests 54/24354/1
Dave Wallace [Wed, 15 Jan 2020 18:16:31 +0000 (18:16 +0000)]
build: install vpp_echo for CSIT QUIC perf tests

Type: make

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Iddfcce1f662efe63c5a6788a0a604917b1c9d81e

4 years agotcp: fix tcp check tx offload issue 58/24258/7
Simon Zhang [Tue, 24 Dec 2019 12:02:20 +0000 (20:02 +0800)]
tcp: fix tcp check tx offload issue

Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: I3b8755831d762abf51e1cbe1b57024f9297de9a4
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
4 years agotls: enable async node on demand 35/24335/2
Yu Ping [Tue, 14 Jan 2020 22:24:44 +0000 (06:24 +0800)]
tls: enable async node on demand

Type: fix

Change-Id: Iab7c65614c94497e8ec5a96624be72c1a139e486
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agoip6: during icmp to icmp6 translation truncate error messages 47/24347/2
Alexander Chernavin [Wed, 15 Jan 2020 11:45:47 +0000 (06:45 -0500)]
ip6: during icmp to icmp6 translation truncate error messages

All translated ICMPv6 packets that exceed the minimal IPv6 MTU get
truncated but according to RFC 4443 2.4 only ICMPv6 error messages
(type < 128) need to be truncated.

With this commit, truncate only ICMPv6 error messages.

Type: fix

Change-Id: Ic455352de2ff4ff6aa3421b46a2a54923f2d3f80
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>
4 years agoquic: add FEATURE.yaml 23/24323/2
Aloys Augustin [Tue, 14 Jan 2020 13:23:37 +0000 (14:23 +0100)]
quic: add FEATURE.yaml

Type: docs
Change-Id: Ica60b42e64703879c5c229209e4a4fac278bda31
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
4 years agosrv6-mobile: Revert "srv6-mobile:" 30/24330/4
Andrew Yourtchenko [Tue, 14 Jan 2020 19:26:27 +0000 (19:26 +0000)]
srv6-mobile: Revert "srv6-mobile:"

This reverts commit 57584d99dd8a8524db90c67c88525d58879d9b8e.

The reasons for reverting:

- the documentation seems "work in progress". Also, 500K of pngs
  should probably go on wiki, rather than in the repo. Please
  make sure that newly added documentation renders correctly
  and sensibly as part of the review/commit process.

- runner.py seems to contain unit tests, so it should
  be rewritten in a manner that allows the testing from within
  CI (including an unprivileged docker container)

- the above items, especially the testing one, warrant more
  work, and at a RC1 milestone time it is probably not
  a good idea to include a significant patch without
  proper care. I suggest to prepare it so it is ready
  for the next release, or cherrypick it for a
  20.01.1 release, if having it in stable/2001 is absolute necessity.

- when submitting it, ensure that the commit message
  makes sense, especially having "srv6-mobile:" with no further
  text should be absolutely avoided.

Change-Id: If81441f7ebf11a6ad5638b1327faf18e8ebe6a35
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agotls: add picotls session close process 13/24313/3
Simon Zhang [Tue, 14 Jan 2020 10:11:18 +0000 (18:11 +0800)]
tls: add picotls session close process

Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: If0a1691c1435f2826c8c83f8bc52e4cd3ecc6256

4 years agotcp: handle ack advancement with no holes and reneging 55/24255/5
Florin Coras [Wed, 8 Jan 2020 22:01:54 +0000 (22:01 +0000)]
tcp: handle ack advancement with no holes and reneging

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9afba8dc9e087b8c436fe568531c02614a577a7c

4 years agotests: fix worker thread initialization 03/23803/4
Paul Vinciguerra [Thu, 5 Dec 2019 00:43:53 +0000 (19:43 -0500)]
tests: fix worker thread initialization

from threading.thread __init__:

    This constructor should always be called with keyword arguments.

    If a subclass overrides the constructor, it must make sure to invoke
    the base class constructor (Thread.__init__()) before doing anything
    else to the thread.

Type: test
Change-Id: Ifa89202e97053a4baf19e9a0ca0913430d5087a3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agosrv6-mobile: 75/24275/10
Tetsuya Murakami [Thu, 9 Jan 2020 22:22:04 +0000 (14:22 -0800)]
srv6-mobile:

Type: feature

Add new functions in SRv6 Mobile Plug-in

GTP4.DT and GTP6.DT

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I573a0c27bd463dd56a4d11b940941b8a8c826e08
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
4 years agoclassify: Reduce the include dependencies on vnet_classify.h 59/24259/3
Neale Ranns [Thu, 9 Jan 2020 06:43:14 +0000 (06:43 +0000)]
classify: Reduce the include dependencies on vnet_classify.h

Type: refactor

currently vnet_classify.h is included in ip.h where it's not required.

Change-Id: Id55682637601655aa2edda681536a979c8e323bd
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agodpdk: enforce max tx retries 18/24218/2
Benoît Ganne [Tue, 7 Jan 2020 12:40:17 +0000 (13:40 +0100)]
dpdk: enforce max tx retries

n_retry was never decremented and so never enforced.

Type: fix

Change-Id: I71d60a72c156286f7e5b82b1c77a723361317c69
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agoacl: Remove unsued type 95/24195/2
Neale Ranns [Mon, 6 Jan 2020 02:48:19 +0000 (02:48 +0000)]
acl: Remove unsued type

Type: style

and add some indent offs.

Change-Id: I31cf3ab9ff9b64d2cd1f2034dcedd4a9c453efb4
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoct6: dst,src copy typo 09/24209/4
Neale Ranns [Tue, 7 Jan 2020 01:41:16 +0000 (01:41 +0000)]
ct6: dst,src copy typo

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I266fa5dc637383fd8dac6592c9c266a1b70a73e9

4 years agomisc: feature file for unsupported feature l2tp 81/24281/3
Ole Troan [Fri, 10 Jan 2020 10:31:10 +0000 (11:31 +0100)]
misc: feature file for unsupported feature l2tp

Type: docs
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I11db583650bc051f88f38358b877410f355b110f
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agotests: disable the tap test for the time being 91/24291/5
Andrew Yourtchenko [Sat, 11 Jan 2020 17:57:31 +0000 (17:57 +0000)]
tests: disable the tap test for the time being

TAP tests require root access, which breaks
the testing in unprivileged scenario.
Disable the test until we find consensus on how
to deal with it.

Type: test
Change-Id: I66ee2b130723233682d858cad0b6e424ab0b2383
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agotls: enable TLS OpenSSL plugin works in 3.0.0 77/24277/3
Yu Ping [Thu, 9 Jan 2020 19:45:06 +0000 (03:45 +0800)]
tls: enable TLS OpenSSL plugin works in 3.0.0

Type: fix

Change-Id: Id1602981fcc6efed1b0efe79a1fc8177457acdb5
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agomisc: VPP 19.08.1 release notes 92/24292/1
Andrew Yourtchenko [Sat, 11 Jan 2020 18:07:14 +0000 (18:07 +0000)]
misc: VPP 19.08.1 release notes

Change-Id: I365696bfcf11fcc74a698f764dec62e470fc7853
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Type: docs

4 years agoip: avoid fib lookup for consecutive pkts having same source IP 92/24192/4
Nitin Saxena [Sat, 4 Jan 2020 06:58:42 +0000 (12:28 +0530)]
ip: avoid fib lookup for consecutive pkts having same source IP

Type: fix
Fixes: be2286b0

This patch does following:

- If terminating frame has consecutive packets with same source IP, this patch
  avoids fib lookup for those packets in ip4-local node. This drops cycle count
  for ip4-local node on both ARM and x86. It being done by enabling dead code in
  else {} case of ip4_local_check_src_x2() and ip4_local_check_src() functions.

- In case all packets in terminating frame have unique source IP (e.g:
  incrementing), ip4-local is costlier by 2 cycles (broadwell)

Change-Id: I472ddc324716cec8bfe601568b8aeb7565f97ab3
Signed-off-by: Nitin Saxena <nsaxena@marvell.com>
4 years agogso: add FEATURE.yaml 48/24248/2
Mohsin Kazmi [Wed, 8 Jan 2020 17:18:50 +0000 (18:18 +0100)]
gso: add FEATURE.yaml

Type: docs

Change-Id: I64743c9f5ad7eef21855e883e1a00f355fddf3ee
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agosr: feature YAML files for Segment Routing 74/24274/5
pcamaril [Thu, 9 Jan 2020 17:31:47 +0000 (18:31 +0100)]
sr: feature YAML files for Segment Routing

Type: docs
Signed-off-by: pcamaril <pcamaril@cisco.com>
Change-Id: Ia35d18113e17fd2ba5310e81ca527d3569cd110e
Signed-off-by: pcamaril <pcamaril@cisco.com>
4 years agodocs: Edit FEATURE.yaml files so they can be published 88/24288/4
John DeNisco [Fri, 10 Jan 2020 15:07:26 +0000 (10:07 -0500)]
docs: Edit FEATURE.yaml files so they can be published

Type: docs
Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: I7280e5c5ad10a66c0787a5282291a2ef000bff5f

4 years agobonding: process lacp when bond is admin down 30/24230/2
Matthew Smith [Tue, 7 Jan 2020 17:34:43 +0000 (11:34 -0600)]
bonding: process lacp when bond is admin down

Type: fix
Fixes: 6dfd3785e4

When a bond interface is administratively down but the slaves are
up, process inbound LACP packets received over the slaves. This
was the old behavior with bond interfaces in LACP mode and was
altered unintentionally by another change. Restore the old behavior.

Change-Id: I61b0b700211dea4859b6ee447ab83b33197d9d11
Signed-off-by: Matthew Smith <mgsmith@netgate.com>
4 years agofib: leverage well-optimized clib_memcpy 62/24262/2
Zhiyong Yang [Thu, 9 Jan 2020 09:20:57 +0000 (04:20 -0500)]
fib: leverage well-optimized clib_memcpy

Type: fix

Change-Id: I684910837ca4d9c8a07262459158bbb0423a33af
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
4 years agosession: remove io event dispatch dbg msg 73/24273/1
Florin Coras [Thu, 9 Jan 2020 16:41:31 +0000 (16:41 +0000)]
session: remove io event dispatch dbg msg

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I166ab7b96444587a3252925d3a28505e0db52d74

4 years agotcp: fix persist assert 56/24256/3
Florin Coras [Wed, 8 Jan 2020 23:30:15 +0000 (23:30 +0000)]
tcp: fix persist assert

Type: fix

Persist and retransmit can pop at the same time.

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia9530645cc84c83a881a75d7b4627197dc50ed29

4 years agomisc: fix feature description spelling 65/24265/2
Ole Troan [Thu, 9 Jan 2020 13:03:14 +0000 (14:03 +0100)]
misc: fix feature description spelling

Type: docs
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I46856db81d42c3f10c03a7bf9a245cc998cd8a01

4 years agomisc: feature tracking markdown improvements 39/24239/5
Ole Troan [Wed, 8 Jan 2020 11:37:55 +0000 (12:37 +0100)]
misc: feature tracking markdown improvements

Add table of contents to markdown file.
Added --exclude and --include options to user select which
fts fields to include in report.
Sort output based on feature name.

E.g.: ./build-root/scripts/fts.py --all --markdown --exclude="maintainer"

Type: make
Change-Id: I3edf8c2188a9f3e312767bbe12d75cca7d8c5b39
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agotcp: fix scoreboard assert 50/24250/2
Florin Coras [Wed, 8 Jan 2020 18:49:59 +0000 (18:49 +0000)]
tcp: fix scoreboard assert

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3c70b331932708a1b773392e089aed9dba9b3b31

4 years agordma: api: prepare support for direct verb 25/24225/4
Benoît Ganne [Tue, 7 Jan 2020 15:08:43 +0000 (16:08 +0100)]
rdma: api: prepare support for direct verb

Prepare rdma interface creation API for direct verb support:
 - add new optional 'mode' parameters to select between ibverb or direct
   verb backend (optional, default to 'auto')
 - set default value for rxq_num (1), rxq_size (1024) and txq_size
   (1024) so they are now optional
 - bump default create value for rxq_size and txq_size to 1024 if
   unset (0) so they are coherent with default values above

Type: feature

Change-Id: Id9eae2b8eb0baaf34a0fcd55da6ad09515f57a93
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovirtio: fix ip4 checksum offload 30/24130/7
Mohsin Kazmi [Thu, 26 Dec 2019 19:42:18 +0000 (20:42 +0100)]
virtio: fix ip4 checksum offload

Type: fix

Change-Id: I08747ac308e5c1768a3a6aa5f83a016dc0274a1c
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agotap: split gso and checksum offload functionality 60/24060/12
Mohsin Kazmi [Wed, 18 Dec 2019 16:08:54 +0000 (17:08 +0100)]
tap: split gso and checksum offload functionality

Type: refactor

Change-Id: I0d4b79ef384c11c841576d264bfd8ccb21783e10
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agovirtio: split gso and checksum offload functionality 71/23971/14
Mohsin Kazmi [Fri, 3 Jan 2020 15:11:53 +0000 (15:11 +0000)]
virtio: split gso and checksum offload functionality

Type: refactor

Change-Id: I897e36bd5db593b417c2bac9f739bc51cf45bc08
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
4 years agotls: improve connection formating 31/24231/2
Florin Coras [Tue, 7 Jan 2020 19:01:26 +0000 (19:01 +0000)]
tls: improve connection formating

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iea8abe33cf33036267ccaf58760abc2f48470202

4 years agotcp: fix last sacked with no holes 33/24233/4
Florin Coras [Wed, 8 Jan 2020 00:33:02 +0000 (00:33 +0000)]
tcp: fix last sacked with no holes

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id12b0a9b8bc47aef8b393544e5b4c8228ed6a606

4 years agovppinfra: retry socket connect on EAGAIN 01/24201/5
Florin Coras [Mon, 6 Jan 2020 20:23:07 +0000 (20:23 +0000)]
vppinfra: retry socket connect on EAGAIN

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I93577acf559a8fa639aab7ec3f7cdbe7df9a248d

4 years agosvm: fix eventfd signal write error check 34/24234/2
Florin Coras [Wed, 8 Jan 2020 02:37:57 +0000 (02:37 +0000)]
svm: fix eventfd signal write error check

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I706c8642ca0877430a42cc0ca5bc61a45428fc98

4 years agol2: fix MAC learn counter update on adding MAC entry 32/24232/2
John Lo [Tue, 7 Jan 2020 21:35:29 +0000 (16:35 -0500)]
l2: fix MAC learn counter update on adding MAC entry

Type: fix

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I711432f589ee4a4527cf795526d3b4031999f71d

4 years agoacl: add FEATURE.yaml 35/24235/3
Andrew Yourtchenko [Wed, 8 Jan 2020 05:22:20 +0000 (05:22 +0000)]
acl: add FEATURE.yaml

Change-Id: If6f13e7962c27f35528058224928def927fff19f
Type: docs
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
4 years agordma: add FEATURE.yaml 21/24221/3
Benoît Ganne [Tue, 7 Jan 2020 13:53:09 +0000 (14:53 +0100)]
rdma: add FEATURE.yaml

Type: docs

Change-Id: I91d701814e4bd9953616d2b7c76ae2ea7c07074b
Signed-off-by: Benoît Ganne <bganne@cisco.com>
4 years agovlib: fix coverity warning / real bug 29/24229/1
Dave Barach [Tue, 7 Jan 2020 17:29:10 +0000 (12:29 -0500)]
vlib: fix coverity warning / real bug

The path must be next-to-impossible to hit, because the code has been
wrong for at least 5 years.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I23b8c4e1631827e7931f353c561c1e19c596c598

4 years agotls: Make tls CPS test run for a quite long time 10/24210/4
Yu Ping [Mon, 6 Jan 2020 20:02:55 +0000 (04:02 +0800)]
tls: Make tls CPS test run for a quite long time

Type: fix

Change-Id: I8cfb48bd7f92689b296861dd368186408918061b
Signed-off-by: Yu Ping <ping.yu@intel.com>
4 years agotcp: fix duplicate sack whith reneging 90/24190/9
Florin Coras [Sat, 4 Jan 2020 00:53:04 +0000 (00:53 +0000)]
tcp: fix duplicate sack whith reneging

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I6f7fb91e059996ff702eb9c36e3abaed237fe221

4 years agovppinfra: hash [un]set malloc/free takes a const key 02/24202/3
Neale Ranns [Mon, 6 Jan 2020 21:09:12 +0000 (21:09 +0000)]
vppinfra: hash [un]set malloc/free takes a const key

Type: refactor

the key is not modified by these functions

Change-Id: I578f054355fca69e8a086bb69013155a01ed759f
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agobonding: fix feature.yaml error 11/24211/2
Ole Troan [Tue, 7 Jan 2020 08:30:05 +0000 (09:30 +0100)]
bonding: fix feature.yaml error

Type: fix
Fixes: 6b32b4aad
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8bd6bb95135dc280565f357aa5850292f66979a1
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agobonding: Add FEATURE.yaml 03/24203/2
Steven Luong [Mon, 6 Jan 2020 21:28:34 +0000 (13:28 -0800)]
bonding: Add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I53522a60122014741d1c6533a0456bf31445529a

4 years agoipsec: Add FEATURE/yaml 05/24205/2
Neale Ranns [Mon, 6 Jan 2020 23:16:18 +0000 (23:16 +0000)]
ipsec: Add FEATURE/yaml

Type: docs

Change-Id: I9cb093589b84fdca3f4239da90c431e8bc4d74f1
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoqos: Add FEATURE.yaml 07/24207/2
Neale Ranns [Mon, 6 Jan 2020 23:22:38 +0000 (23:22 +0000)]
qos: Add FEATURE.yaml

Type: docs

Change-Id: Id719ad59dd70f1d97b3cb3722621b10cd63badfb
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agompls: Add FEATURE.yaml 08/24208/2
Neale Ranns [Mon, 6 Jan 2020 23:30:59 +0000 (23:30 +0000)]
mpls: Add FEATURE.yaml

Type: docs

Change-Id: Ic76a4bbfe2e2e45b7ea44556bc974c243970e9bf
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoip-neighbor: Add FEATURE.yaml 04/24204/2
Neale Ranns [Mon, 6 Jan 2020 23:11:09 +0000 (23:11 +0000)]
ip-neighbor: Add FEATURE.yaml

Type: docs

Change-Id: I4c51dad23cf431692ef5b8bdd2391975fb7264d6
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agovmxnet3: add FEATURE.yaml 99/24199/2
Steven Luong [Mon, 6 Jan 2020 18:22:02 +0000 (10:22 -0800)]
vmxnet3: add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I8b0432a3a384dc2431fcb0b4e7c3f0cfb1713d8e

4 years agolacp: Add FEATURE.yaml 00/24200/1
Steven Luong [Mon, 6 Jan 2020 19:17:18 +0000 (11:17 -0800)]
lacp: Add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6fe5555a9ec867d4e39f0751662256717b45e0f9

4 years agoquic: update quicly to v0.0.9-vpp 98/24198/2
MathiasRaoul [Mon, 6 Jan 2020 15:09:50 +0000 (15:09 +0000)]
quic: update quicly to v0.0.9-vpp

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I5cef549de8380b9b9534b8774819e42988f6b784

4 years agol2: Update FEATURE.yaml 97/24197/2
John Lo [Mon, 6 Jan 2020 14:54:36 +0000 (09:54 -0500)]
l2: Update FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: Ib34440c137f24621002ce9463515c632c472a293

4 years agogre: fix feature.yaml error 96/24196/2
Ole Troan [Mon, 6 Jan 2020 11:15:24 +0000 (12:15 +0100)]
gre: fix feature.yaml error

vnet/gre/FEATURE.yaml does not conform with the JSON schema definition.
This bug should no longer happen with the patch that ensures
validation is run as part of checkstyle.

Signed-off-by: Ole Troan <ot@cisco.com>
Type: fix
Change-Id: I25bf8d2a442bf7ccdbf693b031a7a383444dfee3

4 years agoquic: call quic_send_packets only once per ctx 95/24095/3
Aloys Augustin [Fri, 20 Dec 2019 12:14:00 +0000 (13:14 +0100)]
quic: call quic_send_packets only once per ctx

This prevents unnecessary calls to quic_send_packets.

Type: fix
Change-Id: I7abe509aa8b7b9d5a01c9876046cf0f4507a79cf
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
4 years agolb: add FEATURE file for lb/pppoe/gtpu/vxlan-gpe/pppoe 76/24176/2
Hongjun Ni [Fri, 3 Jan 2020 14:34:38 +0000 (22:34 +0800)]
lb: add FEATURE file for lb/pppoe/gtpu/vxlan-gpe/pppoe

Type: docs

Change-Id: Ia3949954423eb7691c02e99444767a9f01a14adf
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
4 years agogre: Add FEATURE.yaml 93/24193/5
Neale Ranns [Sun, 5 Jan 2020 22:10:35 +0000 (22:10 +0000)]
gre: Add FEATURE.yaml

Type: docs

Change-Id: Icda0c8d2141294d78447177dd4823d1b2228e830
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agoip6-nd: Add FEATURE.yaml 94/24194/1
Neale Ranns [Sun, 5 Jan 2020 22:17:53 +0000 (22:17 +0000)]
ip6-nd: Add FEATURE.yaml

Type: docs

Change-Id: I907f2c7f5d73dd88b16a6ff78ef072e13af9739e
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agomisc: fix feature.yaml 86/24186/3
Ole Troan [Fri, 3 Jan 2020 15:37:27 +0000 (16:37 +0100)]
misc: fix feature.yaml

Add checkfeaturelist validation to checkstyle.
Fix two files with errors.

Type: docs
Change-Id: I81eda0e25b271f2006b4da22efdf7218d52a67d3
Signed-off-by: Ole Troan <ot@cisco.com>
4 years agovxlan: Add FEATURE.yaml 91/24191/4
John Lo [Sat, 4 Jan 2020 05:32:46 +0000 (00:32 -0500)]
vxlan: Add FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I4372195121e05af671a3f48b1c2796cd0132b279

4 years agol2: Add FEATURE.yaml 88/24188/3
John Lo [Fri, 3 Jan 2020 22:47:34 +0000 (17:47 -0500)]
l2: Add FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: Icd22f2ec7076bb11d6ac7e7d147bd58dc5ad1527

4 years agoipsec: AH copy destination and source address from template 49/24149/2
Neale Ranns [Thu, 2 Jan 2020 05:04:00 +0000 (05:04 +0000)]
ipsec: AH copy destination and source address from template

Type: fix

Change-Id: I63d4df68eed6589763b5ce62bcd7f3fd867c60e1
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoipsec: Targeted unit testing 88/24088/4
Neale Ranns [Fri, 20 Dec 2019 00:54:57 +0000 (00:54 +0000)]
ipsec: Targeted unit testing

Type: fix

1 - big packets; chained buffers and those without enoguh space to add
ESP header
2 - IPv6 extension headers in packets that are encrypted/decrypted
3 - Interface protection with SAs that have null algorithms

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ie330861fb06a9b248d9dcd5c730e21326ac8e973

4 years agotcp: fix rate samples for old acks 19/24119/2
Florin Coras [Mon, 23 Dec 2019 18:03:27 +0000 (10:03 -0800)]
tcp: fix rate samples for old acks

Type: fix

Change-Id: Ieab35bbfba81faae61b1267d8661df5195877824
Signed-off-by: Florin Coras <fcoras@cisco.com>
4 years agohsa: fix coverity warning 87/24187/3
Florin Coras [Fri, 3 Jan 2020 16:44:47 +0000 (16:44 +0000)]
hsa: fix coverity warning

Type:fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I38b155f7617d002ac16943c2c031269a17f4ba73

4 years agosession: fix per slice fifo prealloc 58/24158/3
Florin Coras [Thu, 2 Jan 2020 19:22:51 +0000 (19:22 +0000)]
session: fix per slice fifo prealloc

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If6db37af6c2863a80d0787a98026b3b8171dad37

4 years agofib: Add dpo FEATURE.yaml file 75/24175/4
Neale Ranns [Fri, 3 Jan 2020 03:55:08 +0000 (03:55 +0000)]
fib: Add dpo FEATURE.yaml file

Type: docs

Change-Id: I9c4727db8d498d0b513157b19ad306b7aaacc222
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agobfd: add feature.yaml 84/24184/3
Klement Sekera [Fri, 3 Jan 2020 12:15:16 +0000 (12:15 +0000)]
bfd: add feature.yaml

Type: docs

Change-Id: Ica2b4a9d4fe2ceaafd6d707ebe3c4a7fa0af1c07
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agotcp: api clenup 79/24179/3
Jakub Grajciar [Fri, 3 Jan 2020 09:02:32 +0000 (10:02 +0100)]
tcp: api clenup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I48f08cc657c28ad1eef50c917a560425137bb70e
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agolldp: add feature.yaml 83/24183/2
Klement Sekera [Fri, 3 Jan 2020 12:02:27 +0000 (12:02 +0000)]
lldp: add feature.yaml

Type: docs

Change-Id: I713ced931e26d5db70cd4678a9d02c5285a1a909
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoip: API cleanup 03/22603/4
Jakub Grajciar [Tue, 8 Oct 2019 12:05:18 +0000 (14:05 +0200)]
ip: API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I17b95bba2327049d2b99e59cea79208814a24b22
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
4 years agodevices: virtio API cleanup 79/22279/2
Jakub Grajciar [Thu, 26 Sep 2019 08:34:41 +0000 (10:34 +0200)]
devices: virtio API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I38a409af770c88c1eb2c68b24abef2a5a91e1b9a

4 years agoqos: api clenup 78/24178/2
Jakub Grajciar [Fri, 3 Jan 2020 09:01:03 +0000 (10:01 +0100)]
qos: api clenup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ia66810293e41427c686fbf1ab9be5c8a7db4056a

4 years agompls: api cleanup 77/24177/2
Jakub Grajciar [Fri, 3 Jan 2020 08:59:07 +0000 (09:59 +0100)]
mpls: api cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I44633df6d189da707657fbf9f9ba49c5f3879e9f

4 years agovxlan-gbp: api cleanup 80/24180/2
Jakub Grajciar [Fri, 3 Jan 2020 09:03:32 +0000 (10:03 +0100)]
vxlan-gbp: api cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I26bd57ba506165bf2dd574fa39a81adc4295d796

4 years agobuild: Fix Subject-line feature list extraction 39/23639/4
Jon Loeliger [Tue, 26 Nov 2019 14:11:11 +0000 (08:11 -0600)]
build: Fix Subject-line feature list extraction

Bang on sed until a better incantation appears.

Change-Id: Ib8ad0996b6325db0fe983c86dd7dc553c9d388c4
Type: fix
Fixes: 26ce6ca1fe6f524a9049444fe8d55042fd7530a6
Signed-off-by: Jon Loeliger <jdl@netgate.com>
4 years agomap: fix ip4-map-t DF behavior 90/24090/7
Vladimir Ratnikov [Fri, 20 Dec 2019 09:55:50 +0000 (04:55 -0500)]
map: fix ip4-map-t DF behavior

ip4_is_fragment(header)
or ip4_is_first_fragment(header) didn't changed
when packet with fragmentation needed arrives.

This patch checks DF flag and MTU with packet
length and if DF is set and length > MTU, packet
is dropped. In case if ignore_df is set, DF flag
makes no sense.

Type: fix
Fixes: d6d50cebde647f9a5ee7251a7fef977506f315d7

Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Change-Id: I720e25167c19a0b13ac5fdfb41b12c0bbdc00d09

4 years agonat: use SVR 63/23963/8
Klement Sekera [Thu, 10 Oct 2019 09:46:06 +0000 (09:46 +0000)]
nat: use SVR

Remove NAT's implementation of shallow virtual reassembly with
corresponding CLIs, APIs & tests. Replace with standalone shallow
virtual reassembly provided by ipX-sv-reass* nodes.

Type: refactor
Change-Id: I7e6c7487a5a500d591f6871474a359e0993e59b6
Signed-off-by: Klement Sekera <ksekera@cisco.com>
4 years agoabf: add feature.yaml 64/24164/4
Neale Ranns [Thu, 2 Jan 2020 23:34:33 +0000 (23:34 +0000)]
abf: add feature.yaml

Type: docs

Change-Id: I4959010617b0fb51652beafe6967afd556f27e92
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agotls: add features.yaml 62/24162/5
Florin Coras [Thu, 2 Jan 2020 23:28:14 +0000 (23:28 +0000)]
tls: add features.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I847463fd38b9d569d2607b8a17f6d45a04b6fe09

4 years agotcp: add FEATURE.yaml 61/24161/8
Florin Coras [Thu, 2 Jan 2020 22:11:41 +0000 (22:11 +0000)]
tcp: add FEATURE.yaml

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I21f822b597bfa44004bf2afaaf54463cb0ae2efc

4 years agofib: add adjacency feature.yaml 69/24169/5
Neale Ranns [Fri, 3 Jan 2020 00:16:12 +0000 (00:16 +0000)]
fib: add adjacency feature.yaml

Type: docs

Change-Id: I6cdfbae5a0eab8a69dfa2ae054945c510a3c63f6
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
4 years agobier: add FEATURE.yaml 74/24174/2
Neale Ranns [Fri, 3 Jan 2020 03:36:40 +0000 (03:36 +0000)]
bier: add FEATURE.yaml

Type: docs

Change-Id: I843a410b7a14c7c61e44ea38cf7cb74f40ccf853
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoarp: add FEATURE.yaml 73/24173/2
Neale Ranns [Fri, 3 Jan 2020 03:03:33 +0000 (03:03 +0000)]
arp: add FEATURE.yaml

Type: docs

Change-Id: If03488de772204a984e1785c33646833f2de6e1e
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agoigmp: Add feature.yaml 65/24165/2
Neale Ranns [Thu, 2 Jan 2020 23:36:52 +0000 (23:36 +0000)]
igmp: Add feature.yaml

Type: docs

Change-Id: I8d6ab1b4fd9f059a3f4c8ba28fc9f20debfb65cb
Signed-off-by: Neale Ranns <nranns@cisco.com>
4 years agol3xc: add feature.yaml 66/24166/2
Neale Ranns [Thu, 2 Jan 2020 23:46:10 +0000 (23:46 +0000)]
l3xc: add feature.yaml

Type: docs

Change-Id: I0d939b26079e9e45fba1cbb7c8e668918c128526
Signed-off-by: Neale Ranns <nranns@cisco.com>