vpp.git
7 years agoVhost: Add thread sync while receiving vhost message 40/3740/1 stable/1609
Pierre Pfister [Wed, 9 Nov 2016 10:16:57 +0000 (10:16 +0000)]
Vhost: Add thread sync while receiving vhost message

It is important to stop the working threads while
some operations are performed on the working threads.

This is a backport of a fix brought in commit e21c52861d.
This should solve Jira ticket VPP526

Change-Id: I6deb27f5de44f0f19401161ee6adecaba86dae1a
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoUpdate tx and output node runtime when recycling interface 94/3694/2
Pierre Pfister [Mon, 17 Oct 2016 14:58:29 +0000 (15:58 +0100)]
Update tx and output node runtime when recycling interface

When an interface is removed, and another one is created,
the nodes from the previous interface are reused. The current
code fails when the new interface type differs from the original.
It is necessary to update the node runtime, in particular the
node function, and the node format function.

Jira: VPP-460

Change-Id: I2fc3c609e0173a7f62597230768669039853ab03
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
(cherry picked from commit 064f55da7798f3a4c790b656dba71b32a3b82a5c)

7 years agoUse released 1609 CSIT branch for test in stable/1609 VPP branch 98/3698/1
Jan [Fri, 4 Nov 2016 11:03:59 +0000 (12:03 +0100)]
Use released 1609 CSIT branch for test in stable/1609 VPP branch

 - csit branch changed from oper-rls1609-161009 to rls1609

Change-Id: I20b70960794f67a4f779a7cbae446a7f485a0336
Signed-off-by: Jan Gelety <jgelety@cisco.com>
7 years agoUpdate CSIT tests 160919 -> 160925 41/3141/1
Jan [Mon, 26 Sep 2016 10:16:52 +0000 (12:16 +0200)]
Update CSIT tests 160919 -> 160925

- update of CSIT operational branch to be used for VPP-patch test
  in VPP branch stable/1609

Change-Id: I7e9d4993356016f02fe173b94b5477231480290d
Signed-off-by: Jan Gelety <jgelety@cisco.com>
7 years agoTemporary fix for CLI doc macro expansion; VPP-417 13/3013/2
Chris Luke [Wed, 21 Sep 2016 01:39:05 +0000 (21:39 -0400)]
Temporary fix for CLI doc macro expansion; VPP-417

One CLI initializer has been modified temporarily to
avoid macro expansion that the siphon CLI documentation parser
doesn't understand.

Removed macros: ila_type_list, ila_csum_list and ila_direction_list.

Also make docs use the official version without the offset-from-tag
count we would other wise get in this stable release.

Change-Id: I52e1fa215f540583f0610200ec28349e67f56a32
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoUpdate CSIT tests 160912 -> 160919 42/2942/1
Jan [Mon, 19 Sep 2016 10:38:16 +0000 (12:38 +0200)]
Update CSIT tests 160912 -> 160919

- update of CSIT operational branch to be used for VPP-patch test
  in VPP branch stable/1609

Change-Id: I0045726035b09f97f55f817f1581b86fd9f34b1a
Signed-off-by: Jan <jgelety@cisco.com>
7 years agoUpdate of release notes, disable SIXRD; VPP-412 23/2923/2 v16.09
Keith Burns (alagalah) [Fri, 16 Sep 2016 16:22:56 +0000 (09:22 -0700)]
Update of release notes, disable SIXRD; VPP-412

Change-Id: I74ca4846e41f1bd8b4bf384f4c1e5791d0481f6d
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoAdd ILA API and API test plugin VPP-412 00/2900/4
Pierre Pfister [Thu, 15 Sep 2016 12:45:31 +0000 (13:45 +0100)]
Add ILA API and API test plugin VPP-412

The ILA plugin could only be configured through CLI.
This patch adds API support to ila_interface and
ila_add_del_entry functions.
The patch also adds a test plugin for vpp_api_test.

Change-Id: I35d96c4e56bb32862cd08cc86a9fa25ff56ef583
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoFix vpp-plugins rpms 96/2896/2
Ed Warnicke [Wed, 14 Sep 2016 23:58:33 +0000 (16:58 -0700)]
Fix vpp-plugins rpms

vpp by default looks in /usr/lib/vpp_plugins
rpmbuild has ${_libdir} as /usr/lib64

Thus vpp doesn't see the plugins.

Change-Id: Iecbc491940678728305c181b04bb0914ad174bf1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years ago16.09 Release Notes - VPP-135 91/2891/9
Keith Burns (alagalah) [Wed, 14 Sep 2016 12:43:32 +0000 (05:43 -0700)]
16.09 Release Notes - VPP-135

Change-Id: I9a2ae5dc859e73682003175a8987d49bf0729d02
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoAdd structure to some of the documentation; VPP-223 90/2890/2
Chris Luke [Wed, 14 Sep 2016 16:42:54 +0000 (12:42 -0400)]
Add structure to some of the documentation; VPP-223

Moves the random .md files into a config examples tree

Change-Id: If423b82f1047f1c84f90876a786313054b5f7c77
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoVPP-282: Document changes for vnet/vnet/ethernet 67/2867/3
Billy McFall [Wed, 14 Sep 2016 01:47:55 +0000 (21:47 -0400)]
VPP-282: Document changes for vnet/vnet/ethernet

Change-Id: Ie75f43516fdd76ba3720f65f38d66f14749e3e2d
Signed-off-by: Billy McFall <bmcfall@redhat.com>
7 years agoVPP-306: Document changes for vnet/vnet/vxlan 87/2887/1
Billy McFall [Wed, 14 Sep 2016 14:39:58 +0000 (10:39 -0400)]
VPP-306: Document changes for vnet/vnet/vxlan

Change-Id: I1ec4a80ee431758998716014e3fb6f80a5b9c168
Signed-off-by: Billy McFall <bmcfall@redhat.com>
7 years agoUpdate CSIT tests 160904 -> 160912 32/2832/2
Jan [Mon, 12 Sep 2016 20:40:59 +0000 (22:40 +0200)]
Update CSIT tests 160904 -> 160912

- update of CSIT operational branch to be used for VPP-patch test
  in VPP branch stable/1609

Change-Id: Ia053d152dd20bbd0f967313ac058e0b7be1db585
Signed-off-by: Jan <jgelety@cisco.com>
7 years agoVPP-402 Provide vpp-plugins rpm packaging 34/2834/1
Ed Warnicke [Mon, 12 Sep 2016 20:40:24 +0000 (20:40 +0000)]
VPP-402 Provide vpp-plugins rpm packaging

Change-Id: Ifbd99818ead5f38c5f8ad3ecdb36b24a9fa59798
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agovhost user buffer allocation and counter fix for 1609 62/2762/2
Pierre Pfister [Fri, 9 Sep 2016 12:50:35 +0000 (13:50 +0100)]
vhost user buffer allocation and counter fix for 1609

This patch backports parts of ba1d04641454 to 1609 branch:
- Bug allocation error (Not enough buffers were allocated)
- Dropped packet counting bugfix

Those fixes are more critical than what I expected.

DO NOT CHERRY-PICK TO MASTER
Sorry for the inconveniance.

Change-Id: I96bd9beb54924ab13fc87e6d4546cd9fa4dd6725
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVPP-341: iOAM plugin documentation 97/2797/3
Shwetha [Thu, 1 Sep 2016 06:29:19 +0000 (07:29 +0100)]
VPP-341: iOAM plugin documentation

Change-Id: I0042ce8b8a70bb709765037c3636be667ad88aa2
Signed-off-by: Shwetha <shwethab@cisco.com>
(cherry picked from commit f074eef0409a64475e840f59581306273313b218)

7 years agoMove CLI examples from wiki to code - VPP-165 93/2793/2
Keith Burns (alagalah) [Sat, 10 Sep 2016 21:55:04 +0000 (14:55 -0700)]
Move CLI examples from wiki to code - VPP-165

Change-Id: I50ad0d79a6ffaf0a51848abf2c5ed57e83c8640f
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoPeg vpp and vpp-plugins to depend on specific versions; VPP-367 95/2795/2
Ed Warnicke [Sat, 10 Sep 2016 23:13:36 +0000 (16:13 -0700)]
Peg vpp and vpp-plugins to depend on specific versions; VPP-367

vpp now depends on the version of vpp-lib it was built with
vpp-plugins now depends on the version of vpp it was built with

Change-Id: Idf706f94d3a35bdf51930badf61cac288855873d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoCheck for zero-sized Graphvix config file on Ubuntu; VPP-396 89/2789/1
Chris Luke [Sat, 10 Sep 2016 00:16:04 +0000 (20:16 -0400)]
Check for zero-sized Graphvix config file on Ubuntu; VPP-396

- The previous change only accounted for a missing Graphviz config
  file; apparently it can be zero-sized too.

Change-Id: Ic6957d10cdc7cb7b9da72d2b2a0f8913100870c5
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoOn Ubuntu check for graphviz system config; VPP-396 86/2786/1
Chris Luke [Fri, 9 Sep 2016 21:51:42 +0000 (17:51 -0400)]
On Ubuntu check for graphviz system config; VPP-396

- Sometimes it seems Ubuntu doesn't always set up the Graphviz
  handler config. If it's missing, generate it.
  https://bugs.launchpad.net/ubuntu/+source/graphviz/+bug/1349026

Change-Id: I2c1e566817de8415f8b360c6f967cd76307a2a52
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoVPP-388 Improve IP header lookup in ipsec_output 12/2712/6
Florin Coras [Tue, 6 Sep 2016 13:18:21 +0000 (15:18 +0200)]
VPP-388 Improve IP header lookup in ipsec_output

Change-Id: I5df0067c9ce56d7a15a991b82d4761924d91758b
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit fb28e9a80c8e36db0a3a484a20e9e0114be517bd)

7 years agoVPP-223 Various documentation fixes. 11/2711/2
Chris Luke [Wed, 7 Sep 2016 19:01:31 +0000 (15:01 -0400)]
VPP-223 Various documentation fixes.

[Note: This is an amalgamation of two patches on master with
only the parts relevant to stable included. See 16bcf7d8 and
d4024f58]

This is a cleanup of some obvious syntactic issues with Doxygen
tags in the documentation. It is not an attempt to improve the
documentation itself.

Change-Id: I278ad91fe980243778f84560c5e4b84a9423dc09
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoVPP-221 CLI auto-documentation infrastructure 10/2710/2
Chris Luke [Mon, 25 Jul 2016 20:38:11 +0000 (16:38 -0400)]
VPP-221 CLI auto-documentation infrastructure

[Note: This is an amalgamation of several patches cherry-picked from
master all related to introducing auto-CLI documentation. See commits
d4024f58 ee4743ad 16bcf7d8 e0d802bc 54ccf226]

As a step before Doxygen, extract CLI-related struct initializers
from the code and parse that into a summary of the CLI commands
available with the provided help text, such as it is. At the moment
this only renders this into an indexed Markdown file that Doxygen
then picks up but later we can use this information to enrich the
existing VLIB_CLI_COMMAND macro documentor as well as provide
runtime documentation to VPP that is stored on disk outside the
binary image.

Additionally support a comment block immediately prior to
VLIB_CLI_COMMAND CLI command definitions in the form /*? ... ?*/
that can be used to include long-form documentation without having
it compiled into VPP.

Examples of documenting CLI commands can be found in
vlib/vlib/unix/cli.c which, whilst not perfect, should provide a
starting point. Screen captures of sample output can be seen at
https://chrisy.flirble.org/vpp/doxy-cli-example.png and
https://chrisy.flirble.org/vpp/doxy-cli-index.png .

Next, shift the Doxygen root makefile targets to their own Makefile.
The primary reason for this is that the siphon targets do dependency
tracking which means it needs to generate those dependencies whenever
make is run; that is pointless if we're not going to generate any
documentation. This includes the package dependencies since they since
they sometimes unnecessarily interfere with the code build in some cases
at the moment; later we will look to building a Python venv to host the
Python modules we use.

One final remark: In future we may consider deprecating .long_help
in the VLIB_CLI_COMMAND structure entirely but add perhaps .usage_help.
.short_help would be reserved for a summary of the command function
and .usage_help provide the syntax of that command. These changes would
provide great semantic value to the automaticly generated CLI
documentation. I could also see having .long_help replaced by a
mechanism that reads it from disk at runtime with a rudimentary
Markdown/Doxygen filter so that we can use the same text that is used in
the published documentation.

Change-Id: I8afccfd7fe2096411d8064ac954ca5a2cbca9ae7
Signed-off-by: Chris Luke <chrisy@flirble.org>
7 years agoVPP-390: include *.so symlinks in vpp-lib 07/2707/1
Ed Warnicke [Wed, 7 Sep 2016 17:12:52 +0000 (17:12 +0000)]
VPP-390: include *.so symlinks in vpp-lib

Currently, vpp-lib rpm includes symlinks for

*.so.0 -> *.so.0.0.0

but not

*.so -> *.so.0.0.0

This causes linker issues in cases where vpp-lib and vpp-devel rpms
are installed and sources are built that rely on libraries in vpp-lib.

Example:

libtool: link: gcc -shared -fPIC -DPIC jvpp/.libs/libjvpp_nsh_la-jvpp_nsh.o -lvlibmemoryclient -lvlibapi -lsvm -lvppinfra -lpthread -lm -lrt -ljvpp_common -L/usr/lib64 -O2 -Wl,-soname -Wl,libjvpp_nsh.so.0 -o .libs/libjvpp_nsh.so.0.0.0
/usr/bin/ld: cannot find -lvlibmemoryclient
/usr/bin/ld: cannot find -lvlibapi
/usr/bin/ld: cannot find -lsvm
/usr/bin/ld: cannot find -lvppinfra
collect2: error: ld returned 1 exit status

Change-Id: Ic8eebc696f973ea348be0b43e7cfb289efbe44fe
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoVPP-307 - vnet/vnet/vxlan-gpe Documentation fixes 30/2530/2
Keith Burns (alagalah) [Sat, 27 Aug 2016 22:52:46 +0000 (15:52 -0700)]
VPP-307 - vnet/vnet/vxlan-gpe Documentation fixes

Change-Id: Icd7b82306f49e8148d5e7b2fccd8b5f1005f935d
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-303 - Documentation changes for vnet/vnet/sr 29/2529/2
Keith Burns (alagalah) [Mon, 8 Aug 2016 22:56:50 +0000 (15:56 -0700)]
VPP-303 - Documentation changes for vnet/vnet/sr

Change-Id: If8b76959d7c29c216bf03609483a2c9e1d034f46
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-386 Fix map-server output in lisp-cp-lookup trace 77/2677/2
Florin Coras [Tue, 6 Sep 2016 14:29:34 +0000 (16:29 +0200)]
VPP-386 Fix map-server output in lisp-cp-lookup trace

Change-Id: I67dd7896932b8ea96062b9ff074959c172b51ba4
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 5a1c11b53f60f4339e893b1a24cfc6515d2b08f7)

7 years agoVPP-381 Add LISP interfaces to sw_interface_dump 78/2678/1
Florin Coras [Tue, 6 Sep 2016 11:36:11 +0000 (13:36 +0200)]
VPP-381 Add LISP interfaces to sw_interface_dump

Change-Id: I62b65472e77a33b1fc94f7c4975b5e9cbf358f41
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit ce98275ac31f1120c263d22d667841e6e7a7b936)

7 years agoUpdate CSIT tests 160821 -> 160904 36/2636/2
Jan [Mon, 5 Sep 2016 11:05:46 +0000 (13:05 +0200)]
Update CSIT tests 160821 -> 160904

- update of CSIT operational branch to be used for VPP-patch test
  in VPP branch stable/1609

Change-Id: I4dfd568d1078e0ce92053dd64225dd043f556575
Signed-off-by: Jan <jgelety@cisco.com>
7 years agoVPP-385: Fix ARP for indirect adjacencies 73/2673/1
Florin Coras [Mon, 5 Sep 2016 17:54:17 +0000 (19:54 +0200)]
VPP-385: Fix ARP for indirect adjacencies

Change-Id: I48cffb8acbd9e6655d7ec661ee8f7e0689b12a2d
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-374: getting jvppgen.py into rpm vpp-devel package 96/2596/3
Ed Warnicke [Thu, 1 Sep 2016 01:48:47 +0000 (18:48 -0700)]
VPP-374: getting jvppgen.py into rpm vpp-devel package

Change-Id: Ia2643f33170da92fde0f8228c8d8393f23e98d11
Signed-off-by: Ed Warnicke <eaw@cisco.com>
(cherry picked from commit 406ab9d3657d028c974069ce63807a88dfa62a4f)

7 years agoVPP-373: stop building from /vpp mount 95/2595/2
Ed Warnicke [Thu, 1 Sep 2016 18:54:27 +0000 (11:54 -0700)]
VPP-373: stop building from /vpp mount

Change-Id: I7f8fe8fa6c24b4229b0cb45e6c83e7cb2828e2da
Signed-off-by: Ed Warnicke <eaw@cisco.com>
(cherry picked from commit 3ba4d36d927444cfd1929c3d130af7dc9194ea6c)

7 years agoVPP-375: Fix LSIP locator set hash table on addition 13/2613/1
Filip Tehlar [Fri, 2 Sep 2016 15:45:56 +0000 (17:45 +0200)]
VPP-375: Fix LSIP locator set hash table on addition

Change-Id: Iec9e6538d2731ba12ae8338b72fdc3a0bd5f0c69
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-371: Fix for vppctl to suppress "load_one_plugin:63: Loaded plugin:" msgs 88/2588/1
Ed Warnicke [Wed, 31 Aug 2016 01:09:24 +0000 (18:09 -0700)]
VPP-371: Fix for vppctl to suppress "load_one_plugin:63: Loaded plugin:" msgs

Change-Id: I06fcb024036b48a6401d2865a2181b122cb32108
Signed-off-by: Ed Warnicke <eaw@cisco.com>
(cherry picked from commit f53db2a6c2a7e511716018aa37bc8ae8d0c18156)

7 years agoVPP-365: Fix sending of bd_index in lisp_eid_table_add_del_map 56/2556/1
Filip Tehlar [Tue, 30 Aug 2016 13:05:18 +0000 (15:05 +0200)]
VPP-365: Fix sending of bd_index in lisp_eid_table_add_del_map

Change-Id: I1f8fd65fa33b0bc7ee07aa0eeb5f794a7ede9537
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
(cherry picked from commit 5a4e2dde94262a6f93c0c87be81a10317f2ae426)

7 years agoVPP-361: Memory leak on delete of VXLAN over IPv6 tunnel 42/2542/1
John Lo [Tue, 30 Aug 2016 04:10:09 +0000 (00:10 -0400)]
VPP-361: Memory leak on delete of VXLAN over IPv6 tunnel

The key for VXLAN over IPv6 tunnel is allocated on create and should
be freed on delete.

Change-Id: I11bdd9465030fed57cc4bbd28dbccdf952633b34
Signed-off-by: John Lo <loj@cisco.com>
7 years agovhost-user: unmap previously configured memory if necessary 40/2540/2
Steve Shin [Fri, 19 Aug 2016 00:34:52 +0000 (17:34 -0700)]
vhost-user: unmap previously configured memory if necessary

If there's any memory-mapped region configued previously,
it should be unmapped before setting up a new vhost memory table.
Otherwise, huge page leakage will happen.

Change-Id: I375f603ea303919f1502df44a26a7384ab2ea00e
Signed-off-by: Steve Shin <jonshin@cisco.com>
(cherry picked from commit 5e15c91b6c2b5fbd7f989c5dc4edde506d254926)

7 years agotuntap_rx modification to handle jumbo packets ( > 2K bytes) 41/2541/1
Steve Shin [Thu, 18 Aug 2016 15:16:27 +0000 (08:16 -0700)]
tuntap_rx modification to handle jumbo packets ( > 2K bytes)

Change-Id: Iebe30b87457741ac268b24c96fa7ea8ad1e101a6
Signed-off-by: Steve Shin <jonshin@cisco.com>
(cherry picked from commit 82a7af95e7553747dcebdb865a9c9a67826745d4)

7 years agoVPP-356: Fix wrong byte order in LISP API 19/2519/2
Filip Tehlar [Fri, 26 Aug 2016 10:44:38 +0000 (12:44 +0200)]
VPP-356: Fix wrong byte order in LISP API

Change-Id: Ib2284025b8394a87f1d5765713adb7070b450cba
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
(cherry picked from commit e3552c45f38d1f101cf512c9046647201d6c121b)

7 years agoVPP-357 Fix vni for LISP fwd entry removals 22/2522/1
Florin Coras [Thu, 25 Aug 2016 23:47:47 +0000 (19:47 -0400)]
VPP-357 Fix vni for LISP fwd entry removals

Change-Id: I5d20c1939f7a5a142bf696b34143f7ebca6afbcb
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-345: pull in upstream checksum patch for ICMP packets 98/2498/2
Sean Chandler [Mon, 22 Aug 2016 20:32:22 +0000 (16:32 -0400)]
VPP-345: pull in upstream checksum patch for ICMP packets

http://www.dpdk.org/dev/patchwork/patch/15216/

Change-Id: I91b67f3e5c0abff52626e504e2707814ae0c3ed0
Signed-off-by: Sean Chandler <seandchandler@gmail.com>
(cherry picked from commit dc731bd4b1ad6ea588334c681d1409cbdec9ce67)

7 years agoVPP-305: Documentation for vnet/vnet/unix 07/2507/2
Keith Burns (alagalah) [Thu, 25 Aug 2016 20:37:37 +0000 (13:37 -0700)]
VPP-305: Documentation for vnet/vnet/unix

Change-Id: I3f1a225033ecebe0cedfc3466b552176461b76ab
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-307: Documentation for vnet/vnet/vxlan-gpe 05/2505/2
Keith Burns (alagalah) [Thu, 25 Aug 2016 18:21:39 +0000 (11:21 -0700)]
VPP-307: Documentation for vnet/vnet/vxlan-gpe

Change-Id: Iaab6f4b63ed0d986be1ac0636c692b46098ad54d
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-321: Fix param order of unformat_lisp_eid_api 78/2478/2
Filip Tehlar [Mon, 22 Aug 2016 10:29:21 +0000 (12:29 +0200)]
VPP-321: Fix param order of unformat_lisp_eid_api

Change-Id: Ib00ca0f0dab4784a3fb34ffd91c18a3940e9a5d5
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
(cherry picked from commit 251aec436b9e3be15f92a464fa4559396b115b2a)

7 years agoFix issues with vhost-user when dpdk vhost-user is disabled, fixes VPP-347, VPP-349 87/2487/2
Damjan Marion [Wed, 24 Aug 2016 12:32:39 +0000 (14:32 +0200)]
Fix issues with vhost-user when dpdk vhost-user is disabled, fixes VPP-347, VPP-349

Change-Id: I774bab98e43d55678a67a7708ca50edbbd4cbb06
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-340: MAP-T wrong destination address 90/2490/1
Ole Troan [Wed, 24 Aug 2016 14:17:29 +0000 (16:17 +0200)]
VPP-340: MAP-T wrong destination address

The bug was in VAT MAP code parsing a 32 bit integer into a 8 bit
type.  Perhaps we should try to build some defences in
unformat_chech_input() to avoid these errors.

Rebuild.

Change-Id: Iae4959f7e04d889da2e9650a4201c4db15d74201
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoVPP-342: Don't allow remote mapping to overwrite local or static mapping 73/2473/1
Filip Tehlar [Tue, 23 Aug 2016 08:52:44 +0000 (10:52 +0200)]
VPP-342: Don't allow remote mapping to overwrite local or static mapping

Change-Id: I9888d7c087da538b81a6a1967edbdf1103cc095a
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
(cherry picked from commit 3cd9e730f9db0d998e5e8a27ddff1da5a123625b)

7 years agoChange default branch in .gitreview 22/2422/1
Dave Barach [Thu, 18 Aug 2016 00:25:38 +0000 (20:25 -0400)]
Change default branch in .gitreview

Change-Id: Ia39cdfd2b3d6c9dbe252dff0bcea3ba0adabdaaf
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-202: L2-GRE over IPSec 11/2311/5
Matus Fabian [Wed, 10 Aug 2016 08:55:36 +0000 (01:55 -0700)]
VPP-202: L2-GRE over IPSec

GRE encapsulate layer 2 traffic and IPSec encrypt what is encapsulated by GRE.
The whole point of L2-GRE over IPSec is to tunnel layer 2 over GRE and IPSec by
bridging the physical interface with IPSec-GRE tunnel interface.

Change-Id: Ia4cf9ed407bf663770e0d8905c0ad44ce73bd23b
Signed-off-by: Matus Fabian <matfabia@cisco.com>
7 years agoVPP-336: Fix build order for jvpp_{core,registry}.la dependency on jvpp_common.la 21/2421/2
Ed Warnicke [Wed, 17 Aug 2016 18:53:08 +0000 (11:53 -0700)]
VPP-336: Fix build order for jvpp_{core,registry}.la dependency on jvpp_common.la

Change-Id: I886d087532d20bf7e6555da44e4e75ee0ca38268
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoCoding standards cleanup in vnet/vnet/devices, fixes VPP-248 19/2419/2
Damjan Marion [Wed, 17 Aug 2016 15:05:46 +0000 (17:05 +0200)]
Coding standards cleanup in vnet/vnet/devices, fixes VPP-248

Change-Id: I35cf89bf1aa54b76294876e9feb0ed0ccc316975
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-205: documentation update 14/2414/4
Marek Gradzki [Wed, 17 Aug 2016 10:33:50 +0000 (12:33 +0200)]
VPP-205: documentation update

Change-Id: I98e5bdbd0472c2973885defe2712b53d9da8a536
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoVPP-261 Coding standards cleanup - vnet/vnet/lisp-gpe 10/2410/3
Florin Coras [Tue, 16 Aug 2016 21:04:00 +0000 (23:04 +0200)]
VPP-261 Coding standards cleanup - vnet/vnet/lisp-gpe

Change-Id: I1bc2098e79ce753f3d72f05f2fcac9ab00d0d052
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-260 Coding standards cleanup - vnet/vnet/lisp-cp 07/2407/2
Florin Coras [Tue, 16 Aug 2016 19:09:14 +0000 (21:09 +0200)]
VPP-260 Coding standards cleanup - vnet/vnet/lisp-cp

Change-Id: I29b84c44c12ab746e9e61c30efa0ac3418d1a09a
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoFix coverity issues in IPSec code, fixes VPP-189 02/2402/3
Damjan Marion [Tue, 16 Aug 2016 09:27:02 +0000 (11:27 +0200)]
Fix coverity issues in IPSec code, fixes VPP-189

Change-Id: I4e43606884ebad9a84abda779b82417192727ef3
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoCoding standards cleanup - remove trailing whitespace, fixes VPP-332 06/2406/3
Damjan Marion [Tue, 16 Aug 2016 20:53:54 +0000 (22:53 +0200)]
Coding standards cleanup - remove trailing whitespace, fixes VPP-332

Change-Id: I649a17f8fa47599faf438b2e596f53761790d10c
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoCoding standards cleanup in vnet/vnet/devices/dpdk, partially fixes VPP-248 04/2404/2
Damjan Marion [Tue, 16 Aug 2016 16:56:08 +0000 (18:56 +0200)]
Coding standards cleanup in vnet/vnet/devices/dpdk, partially fixes VPP-248

Change-Id: Ie3ee4ccc126c5db9020779cbd06b0d1da99c8411
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP-205: jvpp plugin support. 61/2361/6
Marek Gradzki [Tue, 26 Jul 2016 13:28:22 +0000 (15:28 +0200)]
VPP-205: jvpp plugin support.

Splits jvpp into two jars
jvpp-registry.jar - base jvpp functionality
jvpp-core.jar - Java wrapper for vpe.api

Plugins can be generated the same way jvpp-core.jar is.
Example (nsh):
https://gerrit.fd.io/r/#/c/2118/

Change-Id: I2254f90b2c3e423563bb91bf70877979f1e90a7d
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoVPP-330 Track pending map-requests with a fifo 03/2403/2
Florin Coras [Mon, 15 Aug 2016 17:16:32 +0000 (19:16 +0200)]
VPP-330 Track pending map-requests with a fifo

Change-Id: Icc64abb91047f756c955c880f6f85b26faef666a
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoCreate python package for jvpp generation. 34/1934/17
Ed Warnicke [Mon, 11 Jul 2016 17:29:41 +0000 (10:29 -0700)]
Create python package for jvpp generation.

Change-Id: I2254f90b2c3e423563bb91bf70877979f1e86a6b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
7 years agoVPP-258: Style change for l2tp 17/2317/3
Calvin [Wed, 10 Aug 2016 15:01:41 +0000 (11:01 -0400)]
VPP-258: Style change for l2tp

Change-Id: Ib456558974820d8d45114b2bbad014a3a3aa2d21
Signed-off-by: Calvin <calvin.ference@gmail.com>
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoFix coverity issues in DPDK code, fixes VPP-189 98/2398/2
Damjan Marion [Tue, 16 Aug 2016 11:25:59 +0000 (13:25 +0200)]
Fix coverity issues in DPDK code, fixes VPP-189

Change-Id: Ie2ebb29451200158504bda8c616d57821edbd749
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoFix coverity issues in vhost-user code, fixes VPP-189 97/2397/1
Damjan Marion [Tue, 16 Aug 2016 10:37:24 +0000 (12:37 +0200)]
Fix coverity issues in vhost-user code, fixes VPP-189

Change-Id: Ief95aac5d4451f411dbed8050528708c0b1b7732
Signed-off-by: Damjan Marion <damarion@cisco.com>
7 years agoVPP251 - Code style vnet/vnet/ethernet 93/2393/5
Keith Burns (alagalah) [Tue, 16 Aug 2016 01:33:19 +0000 (18:33 -0700)]
VPP251 - Code style vnet/vnet/ethernet

Change-Id: I3e51ca70a8e1ac7f6584bc5b0271ee4daacc1084
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
7 years agoVPP-266: style change for vnet/vnet/osi 50/2350/4
Calvin [Thu, 11 Aug 2016 18:10:51 +0000 (14:10 -0400)]
VPP-266: style change for vnet/vnet/osi

Change-Id: I6004a96f9f791fb9fbc961440c9988f7a3ca7db0
Signed-off-by: Calvin <calvin.ference@gmail.com>
7 years agoVhost-User: Fix calculate memory region size 33/2333/4
Jianfeng Tan [Thu, 11 Aug 2016 02:17:30 +0000 (02:17 +0000)]
Vhost-User: Fix calculate memory region size

The memory region size calculation is wrong. For example, a region
with size of 1G (hugepage size is also 1G), and offset is zero, use
the previous way to calculate, the ultimate size to mmap and munmap
is 2G, which could lead to segment fault when munmap is executed.

This patch refers the way in DPDK to calculate the region size.

Change-Id: I6f35cde15e2402be0025c556c192b87a46bbf978
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
7 years agoUpdate CSIT tests 160807 -> 160815 86/2386/3
Jan [Mon, 15 Aug 2016 14:56:42 +0000 (16:56 +0200)]
Update CSIT tests 160807 -> 160815

- update of CSIT operational branch to be used for VPP-patch test

Change-Id: Ia9cb275d9471f3c25a02f943d0ace65aec425f8d
Signed-off-by: Jan <jgelety@cisco.com>
7 years agoVPP-257 Coding standards cleanup for vnet/vnet/l2 90/2390/1
Dave Barach [Mon, 15 Aug 2016 19:31:15 +0000 (15:31 -0400)]
VPP-257 Coding standards cleanup for vnet/vnet/l2

Change-Id: Iba5f33675bb2eb806e9becdc42b11da5d3932d55
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-198: LISP map-resolver failover algorithm 42/2042/6
Filip Tehlar [Mon, 18 Jul 2016 15:35:40 +0000 (17:35 +0200)]
VPP-198: LISP map-resolver failover algorithm

Change-Id: Iadd49e58a359a2e58610bd1793818ec8a25d51f1
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP-327 Coding standards cleanup for vppinfra 88/2388/1
Dave Barach [Mon, 15 Aug 2016 15:12:27 +0000 (11:12 -0400)]
VPP-327 Coding standards cleanup for vppinfra

Fix additional a few additional deviations reported elsewhere by
checkstyle

Change-Id: I026a8ae1c5b1856bbe3c4a555e1b690e7501b045
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-236 Support 64-bit vector lengths, shared memory segments >4 GB 07/2207/4
Dave Barach [Wed, 3 Aug 2016 18:34:38 +0000 (14:34 -0400)]
VPP-236 Support 64-bit vector lengths, shared memory segments >4 GB

Change-Id: I02aee33e96e7ae32094b9f82f6a667d30bb52f59
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Fix another batch of coverity warnings 79/2379/1
Dave Barach [Mon, 15 Aug 2016 12:43:41 +0000 (08:43 -0400)]
VPP-189 Fix another batch of coverity warnings

Change-Id: I1d56bc9377db161ae9226e2b2da7c1916c8d1c3b
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-237: Checkstyle script to check for new checkstyle breakage 35/2235/17
Ed Warnicke [Fri, 5 Aug 2016 18:43:58 +0000 (11:43 -0700)]
VPP-237: Checkstyle script to check for new checkstyle breakage

indent is... cantankerous

It sometimes happens that if you run

indent A

resulting in A'

and then

indent A'

you get back A.  Since the check here is premised on being able
to run indent and not see any changed... we have to run it twice
to be sure.

Change-Id: I5b73e02f5996d8a01ec2e46741affbc6d62da6c9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoVPP-237: indent fixes in prep for checkstyle 56/2356/2
Ed Warnicke [Fri, 12 Aug 2016 18:42:26 +0000 (11:42 -0700)]
VPP-237: indent fixes in prep for checkstyle

Ran indent *twice*

Change-Id: If9c18b81983bb859cc8dc3b415c67cbf318fc618
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoVPP-237: Bracket VL_API_PACKED(...) macros, which indent mangles 53/2353/4
Ed Warnicke [Thu, 11 Aug 2016 20:30:57 +0000 (13:30 -0700)]
VPP-237: Bracket VL_API_PACKED(...) macros, which indent mangles

Change-Id: I208be749350ddb093ecfae149d420f580846c52a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBracket CLIB_PACKED(...) macros, which indent mangles 52/2352/2
Dave Barach [Thu, 11 Aug 2016 20:03:03 +0000 (16:03 -0400)]
Bracket CLIB_PACKED(...) macros, which indent mangles

Change-Id: I39722d7b778e6e0dc5a2d12d005c102845159116
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 fix more coverity warnings 63/2363/1
Dave Barach [Fri, 12 Aug 2016 13:26:47 +0000 (09:26 -0400)]
VPP-189 fix more coverity warnings

Change-Id: If464a5f06ab15eead9eaf12e89792d3761796956
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-223 Add doxygen tags to counter.h 54/2354/2
Dave Barach [Thu, 11 Aug 2016 21:21:02 +0000 (17:21 -0400)]
VPP-223 Add doxygen tags to counter.h

Change-Id: Ifddf37db04b2ecfa7b470cd52e8eaa2211823f3d
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-321: Fix filtering in LISP EID dump call 51/2351/2
Filip Tehlar [Thu, 11 Aug 2016 19:29:30 +0000 (21:29 +0200)]
VPP-321: Fix filtering in LISP EID dump call

Change-Id: Ide5d461cf324c0d9010f20732748d9c71cf6f02e
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoVPP: NXP dpaa2 platform porting to dpdk-16.07 84/2284/2
Sachin [Tue, 9 Aug 2016 09:07:05 +0000 (14:37 +0530)]
VPP: NXP dpaa2 platform porting to dpdk-16.07

This patch will temporary add the "dpaa2" driver support in VPP in-built DPDK v16.07

Change-Id: Ieb7005c73bdb72e5eac88e17c21474479ad087f0
Signed-off-by: Sachin <sachin.saxena@nxp.com>
7 years agoCoverty error: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) 13/2313/2
Ole Troan [Thu, 4 Aug 2016 08:19:17 +0000 (10:19 +0200)]
Coverty error: Incorrect expression  (PW.ASSIGN_WHERE_COMPARE_MEANT)

While the code is correct (assignment was intended) I have rewritten
it for readability.

Change-Id: I5f6fd7d7377c3904e74de4edfd478322a75af612
Signed-off-by: Ole Troan <ot@cisco.com>
7 years agoVPP-319: Fix handling of ERANGE from getgrnam_r 18/2318/4
Ed Warnicke [Wed, 10 Aug 2016 15:06:10 +0000 (08:06 -0700)]
VPP-319: Fix handling of ERANGE from getgrnam_r

Change-Id: I1c5b3ed678622a0352fb881f2236a514743f3c50
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoDon't re-add *INDENT-OFF* ... *INDENT-ON* tags 48/2348/2
Dave Barach [Thu, 11 Aug 2016 16:13:55 +0000 (12:13 -0400)]
Don't re-add *INDENT-OFF* ... *INDENT-ON* tags

Change-Id: Ifd2249c0152805e7b23c4629acce31634dca6f04
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-130: LoadBal: Add lookup bypass and fix adjacency format function 45/2345/1
Pierre Pfister [Thu, 11 Aug 2016 15:04:05 +0000 (16:04 +0100)]
VPP-130: LoadBal: Add lookup bypass and fix adjacency format function

Change-Id: Ib83c6ba04c41dbb80603c6a08c324d71eb44a102
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoCustom adjacency formatting fix (Revived) 08/2308/3
Pierre Pfister [Thu, 4 Aug 2016 13:25:01 +0000 (14:25 +0100)]
Custom adjacency formatting fix (Revived)

Looks like something strange is going on with indentation.

Change-Id: I8e734a2119a4a744d7ce76ce83ecc7b237828d3b
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVPP-130: MagLev-like Load Balancer 17/2217/9
Pierre Pfister [Thu, 4 Aug 2016 15:13:09 +0000 (16:13 +0100)]
VPP-130: MagLev-like Load Balancer

This plugin provides load balancing for VPP in a way that is largely inspired
from Google's MagLev: http://research.google.com/pubs/pub44824.html

More info in the README.md

Change-Id: I1223f495d5c2d5200808a398504119f2830337e9
Signed-off-by: Pierre Pfister <ppfister@cisco.com>
7 years agoVPP-196 LISP L2/L3 tunnel multihoming 88/2288/6
Florin Coras [Mon, 8 Aug 2016 14:04:26 +0000 (16:04 +0200)]
VPP-196 LISP L2/L3 tunnel multihoming

Change-Id: If96d9ff23a7aacdb684494f854d4029f55837065
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoVPP-321: Fix wrong checking of LISP mapping local flag 40/2340/1
Filip Tehlar [Thu, 11 Aug 2016 12:43:19 +0000 (14:43 +0200)]
VPP-321: Fix wrong checking of LISP mapping local flag

Change-Id: Ia1d5a53742a5ebe34566de0a68c2d0a81e002ffa
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
7 years agoRename DPDK-16.07 patch file from 0007... to 0008... to avoid conflict 25/2325/2
John Lo [Wed, 10 Aug 2016 23:41:34 +0000 (19:41 -0400)]
Rename DPDK-16.07 patch file from 0007... to 0008... to avoid conflict

There are now two 0007... patch files. So renaming one to 0008...

Change-Id: I82ab883db3436b1fce6b169065b257df052fe63c
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-223 Document vlib cooperative multi-tasking threads 24/2324/2
Dave Barach [Wed, 10 Aug 2016 22:38:36 +0000 (18:38 -0400)]
VPP-223 Document vlib cooperative multi-tasking threads

Change-Id: I283963b004ed6d91133e7e36811f75834280bbe7
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Fix coverity warnings 23/2323/1
Dave Barach [Wed, 10 Aug 2016 20:56:16 +0000 (16:56 -0400)]
VPP-189 Fix coverity warnings

Change-Id: Iea6d338e60a95f7f30c10c2e751d4827e816f700
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-189 Fix coverity warnings 20/2320/1
Dave Barach [Wed, 10 Aug 2016 15:35:54 +0000 (11:35 -0400)]
VPP-189 Fix coverity warnings

in api_format.c.

Change-Id: Iedc510fe962b6e8fb8614be4038e695b13e12ef9
Signed-off-by: Dave Barach <dave@barachs.net>
7 years agoVPP-315: Fix "show vxlan-gpe" issue 10/2210/3
Hongjun Ni [Thu, 4 Aug 2016 16:58:20 +0000 (00:58 +0800)]
VPP-315: Fix "show vxlan-gpe" issue

Change-Id: If721d3b701a7182e595ece1294c2767981d29d3e
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>
7 years agoVPP-313: Wrong API dump message in vxlan_add_del_tunnel 05/2305/2
John Lo [Wed, 10 Aug 2016 00:53:09 +0000 (20:53 -0400)]
VPP-313: Wrong API dump message in vxlan_add_del_tunnel

Fix API custom-dump format of ip4/ip6 addresses in the message.

Change-Id: I822e036691846ce6a437834df933c44098944c1f
Signed-off-by: John Lo <loj@cisco.com>
7 years agoDPDK: Fix a crash in igb_uio driver when the device is removed. 12/2312/2
Ray Kinsella [Wed, 10 Aug 2016 11:48:06 +0000 (12:48 +0100)]
DPDK: Fix a crash in igb_uio driver when the device is removed.

This crash happens because the device still has MSI configured,
the fix is to free the IRQ. Adding pending further investigation.

Change-Id: Ifcd3404fcc25fe27dcccc67d0dcf9d8f0ec18582
Signed-off-by: Todd Foggoa (tfoggoa) <tfoggoa@cisco.com>
Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
7 years agoTemporarily disable unthrottled log message from DPDK 16.07 06/2306/2
John Lo [Wed, 10 Aug 2016 02:33:51 +0000 (22:33 -0400)]
Temporarily disable unthrottled log message from DPDK 16.07

Patch to prevent the unthrottled message from spilling to syslog and
fill up disk space.

Change-Id: I239ca27a7568182217a675692e0be966fc3486f5
Signed-off-by: John Lo <loj@cisco.com>
7 years agoVPP-314: Vxlan wrong name of decap node 02/2302/1
John Lo [Tue, 9 Aug 2016 23:20:51 +0000 (19:20 -0400)]
VPP-314: Vxlan wrong name of decap node

Fix VXLAN decap node counter update using the correct node index.

Change-Id: Iebfd2bfd97747bc6d0758f4c5829e23ef9899d74
Signed-off-by: John Lo <loj@cisco.com>
7 years agodpdk: allow applications to override rte delay 92/2292/2
Ray [Tue, 9 Aug 2016 17:35:13 +0000 (18:35 +0100)]
dpdk: allow applications to override rte delay

Some applications may wish to define their own implentation of
usec delay other than the existing blocking one. The default
behavior remains unchanged.

Change-Id: I6cb626e7a5d9d985928aa266e522a849d264a2b2
Signed-off-by: Todd Foggoa (tfoggoa) <tfoggoa@cisco.com>
Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>
7 years agoVPP-245 Coding standards cleanup for vnet/vnet/cdp 85/2285/2
Dave Barach [Tue, 9 Aug 2016 12:55:49 +0000 (08:55 -0400)]
VPP-245 Coding standards cleanup for vnet/vnet/cdp

Change-Id: I5253c52eace4b635f7791aa019ab01ec55d7fb4d
Signed-off-by: Dave Barach <dave@barachs.net>