Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
7520e17
)
qos: Uninitialised variable (coverity)
95/20995/2
author
Neale Ranns
<nranns@cisco.com>
Thu, 1 Aug 2019 08:04:24 +0000
(
01:04
-0700)
committer
Dave Barach
<openvpp@barachs.net>
Thu, 1 Aug 2019 11:51:26 +0000
(11:51 +0000)
Type: fix
Fixes:
83832e7ced8be8b7de394415feaba70c32e3c38d
Change-Id: I63130c442f71d1aef0d389ab00bac8092224bec2
Signed-off-by: Neale Ranns <nranns@cisco.com>
src/vnet/qos/qos_store.c
patch
|
blob
|
history
diff --git
a/src/vnet/qos/qos_store.c
b/src/vnet/qos/qos_store.c
index
18e79a3
..
0633643
100644
(file)
--- a/
src/vnet/qos/qos_store.c
+++ b/
src/vnet/qos/qos_store.c
@@
-168,6
+168,7
@@
qos_store_cli (vlib_main_t * vm,
qs = 0xff;
enable = 1;
sw_if_index = ~0;
+ value = ~0;
while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
{
@@
-188,6
+189,8
@@
qos_store_cli (vlib_main_t * vm,
if (~0 == sw_if_index)
return clib_error_return (0, "interface must be specified");
+ if (~0 == value)
+ return clib_error_return (0, "value to be stored must be specified");
if (0xff == qs)
return clib_error_return (0, "input location must be specified");