Code Review
/
vpp.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
review
|
tree
raw
|
patch
| inline |
side by side
(parent:
e7d8996
)
classify: fix "show classify filter" debug CLI
54/25054/2
author
Dave Barach
<dave@barachs.net>
Wed, 12 Feb 2020 19:42:57 +0000
(14:42 -0500)
committer
Damjan Marion
<dmarion@me.com>
Wed, 12 Feb 2020 22:07:12 +0000
(22:07 +0000)
Null pointer bug, memory leak. D'oh!
Type: fix
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ic2865757ed9cbb7f48d23c7c30b64299eb5f6674
src/vnet/classify/vnet_classify.c
patch
|
blob
|
history
diff --git
a/src/vnet/classify/vnet_classify.c
b/src/vnet/classify/vnet_classify.c
index
165d4fc
..
bf03024
100755
(executable)
--- a/
src/vnet/classify/vnet_classify.c
+++ b/
src/vnet/classify/vnet_classify.c
@@
-2065,7
+2065,6
@@
show_classify_filter_command_fn (vlib_main_t * vm,
if (verbose)
{
- u8 *s = 0;
u32 table_index;
for (j = 0; j < vec_len (set->table_indices); j++)
@@
-2082,8
+2081,7
@@
show_classify_filter_command_fn (vlib_main_t * vm,
}
else
{
- u8 *s = 0;
- table_index = set->table_indices[0];
+ table_index = set->table_indices ? set->table_indices[0] : ~0;
if (table_index != ~0)
s = format (s, " %u", table_index);