IPSEC: remove duplicate memcy 59/16059/2
authorNeale Ranns <nranns@cisco.com>
Tue, 20 Nov 2018 17:06:25 +0000 (09:06 -0800)
committerDamjan Marion <dmarion@me.com>
Tue, 20 Nov 2018 20:10:56 +0000 (20:10 +0000)
Change-Id: If91257fa23ba74c09e5c3b5528eb2fd4c4b36b6a
Signed-off-by: Neale Ranns <nranns@cisco.com>
src/vnet/ipsec/ipsec.c

index 8ebc579..bb62560 100644 (file)
@@ -195,14 +195,12 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
          if (policy->is_ipv6)
            {
              vec_add1 (spd->ipv6_outbound_policies, policy_index);
-             clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
              vec_sort_with_function (spd->ipv6_outbound_policies,
                                      ipsec_spd_entry_sort);
            }
          else
            {
              vec_add1 (spd->ipv4_outbound_policies, policy_index);
-             clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
              vec_sort_with_function (spd->ipv4_outbound_policies,
                                      ipsec_spd_entry_sort);
            }
@@ -215,7 +213,6 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
                {
                  vec_add1 (spd->ipv6_inbound_protect_policy_indices,
                            policy_index);
-                 clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
                  vec_sort_with_function
                    (spd->ipv6_inbound_protect_policy_indices,
                     ipsec_spd_entry_sort);
@@ -225,7 +222,6 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
                  vec_add1
                    (spd->ipv6_inbound_policy_discard_and_bypass_indices,
                     policy_index);
-                 clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
                  vec_sort_with_function
                    (spd->ipv6_inbound_policy_discard_and_bypass_indices,
                     ipsec_spd_entry_sort);
@@ -237,7 +233,6 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
                {
                  vec_add1 (spd->ipv4_inbound_protect_policy_indices,
                            policy_index);
-                 clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
                  vec_sort_with_function
                    (spd->ipv4_inbound_protect_policy_indices,
                     ipsec_spd_entry_sort);
@@ -247,7 +242,6 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add)
                  vec_add1
                    (spd->ipv4_inbound_policy_discard_and_bypass_indices,
                     policy_index);
-                 clib_memcpy (vp, policy, sizeof (ipsec_policy_t));
                  vec_sort_with_function
                    (spd->ipv4_inbound_policy_discard_and_bypass_indices,
                     ipsec_spd_entry_sort);