dhcp: disable extraneous vlib_log spew 03/24603/1
authorDave Barach <dave@barachs.net>
Tue, 28 Jan 2020 22:03:05 +0000 (17:03 -0500)
committerDave Barach <dave@barachs.net>
Tue, 28 Jan 2020 22:05:58 +0000 (17:05 -0500)
When there are no dhcp client interfaces configured, it's not
useful to make periodic / timeout log entries.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I16b68fe15ad9de789e49ad1b782b3b0e536bad60

src/plugins/dhcp/client.c

index 441590c..8dc57cb 100644 (file)
@@ -887,15 +887,18 @@ dhcp_client_process (vlib_main_t * vm,
          break;
 
        case ~0:
-          /* *INDENT-OFF* */
-          DHCP_INFO ("timeout");
-         pool_foreach (c, dcm->clients,
-          ({
-            timeout = dhcp_client_sm (now, timeout,
-                                      (uword) (c - dcm->clients));
-          }));
-          /* *INDENT-ON* */
-         if (pool_elts (dcm->clients) == 0)
+         if (pool_elts (dcm->clients))
+           {
+             DHCP_INFO ("timeout");
+              /* *INDENT-OFF* */
+              pool_foreach (c, dcm->clients,
+              ({
+                timeout = dhcp_client_sm (now, timeout,
+                                          (uword) (c - dcm->clients));
+              }));
+              /* *INDENT-ON* */
+           }
+         else
            timeout = 100.0;
          break;
        }